diff options
| author | Noel <noelgrandin@gmail.com> | 2020-11-13 14:29:59 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-11-17 09:57:35 +0100 |
| commit | 8ef6067596cf4b2c52fbce94b44bf7af9fefa643 (patch) | |
| tree | f4cca1a99ba97683b14fa6fe0f1f45f75bf855c2 /include/vcl | |
| parent | 75bada928cf08d2afc6efe52ba99b45088bc9eec (diff) | |
loplugin:stringviewparam check methods too
not just functions
Change-Id: Icca295dd159002b428b73f2c95d40725434f04d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105789
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'include/vcl')
| -rw-r--r-- | include/vcl/GraphicNativeTransform.hxx | 2 | ||||
| -rw-r--r-- | include/vcl/GraphicObject.hxx | 2 | ||||
| -rw-r--r-- | include/vcl/graphicfilter.hxx | 38 |
3 files changed, 21 insertions, 21 deletions
diff --git a/include/vcl/GraphicNativeTransform.hxx b/include/vcl/GraphicNativeTransform.hxx index 3b05ac323232..3b5071e1639c 100644 --- a/include/vcl/GraphicNativeTransform.hxx +++ b/include/vcl/GraphicNativeTransform.hxx @@ -32,7 +32,7 @@ class VCL_DLLPUBLIC GraphicNativeTransform final bool rotateBitmapOnly(Degree10 aRotation); void rotateJPEG(Degree10 aRotation); - bool rotateGeneric(Degree10 aRotation, const OUString& aType); + bool rotateGeneric(Degree10 aRotation, std::u16string_view aType); public: GraphicNativeTransform(Graphic& rGraphic); diff --git a/include/vcl/GraphicObject.hxx b/include/vcl/GraphicObject.hxx index e4c1edc817d6..c302387995ff 100644 --- a/include/vcl/GraphicObject.hxx +++ b/include/vcl/GraphicObject.hxx @@ -167,7 +167,7 @@ public: const Graphic& GetGraphic() const; void SetGraphic( const Graphic& rGraphic, const GraphicObject* pCopyObj = nullptr); - void SetGraphic( const Graphic& rGraphic, const OUString& rLink ); + void SetGraphic( const Graphic& rGraphic, std::u16string_view rLink ); /** Get graphic transformed according to given attributes diff --git a/include/vcl/graphicfilter.hxx b/include/vcl/graphicfilter.hxx index 83db7db95fb8..35728237dc7a 100644 --- a/include/vcl/graphicfilter.hxx +++ b/include/vcl/graphicfilter.hxx @@ -86,18 +86,18 @@ namespace o3tl #define EXP_PDF "SVEPDF" #define EXP_PNG "SVEPNG" -#define BMP_SHORTNAME "BMP" -#define GIF_SHORTNAME "GIF" -#define JPG_SHORTNAME "JPG" -#define MET_SHORTNAME "MET" -#define PCT_SHORTNAME "PCT" -#define PNG_SHORTNAME "PNG" -#define SVM_SHORTNAME "SVM" -#define TIF_SHORTNAME "TIF" -#define WMF_SHORTNAME "WMF" -#define EMF_SHORTNAME "EMF" -#define SVG_SHORTNAME "SVG" -#define PDF_SHORTNAME "PDF" +#define BMP_SHORTNAME u"BMP" +#define GIF_SHORTNAME u"GIF" +#define JPG_SHORTNAME u"JPG" +#define MET_SHORTNAME u"MET" +#define PCT_SHORTNAME u"PCT" +#define PNG_SHORTNAME u"PNG" +#define SVM_SHORTNAME u"SVM" +#define TIF_SHORTNAME u"TIF" +#define WMF_SHORTNAME u"WMF" +#define EMF_SHORTNAME u"EMF" +#define SVG_SHORTNAME u"SVG" +#define PDF_SHORTNAME u"PDF" // Info class for all supported file formats @@ -241,9 +241,9 @@ public: ~GraphicFilter(); sal_uInt16 GetImportFormatCount() const; - sal_uInt16 GetImportFormatNumber( const OUString& rFormatName ); - sal_uInt16 GetImportFormatNumberForShortName( const OUString& rShortName ); - sal_uInt16 GetImportFormatNumberForTypeName( const OUString& rType ); + sal_uInt16 GetImportFormatNumber( std::u16string_view rFormatName ); + sal_uInt16 GetImportFormatNumberForShortName( std::u16string_view rShortName ); + sal_uInt16 GetImportFormatNumberForTypeName( std::u16string_view rType ); OUString GetImportFormatName( sal_uInt16 nFormat ); OUString GetImportFormatTypeName( sal_uInt16 nFormat ); #ifdef _WIN32 @@ -253,11 +253,11 @@ public: OUString GetImportWildcard( sal_uInt16 nFormat, sal_Int32 nEntry ); sal_uInt16 GetExportFormatCount() const; - sal_uInt16 GetExportFormatNumber( const OUString& rFormatName ); - sal_uInt16 GetExportFormatNumberForMediaType( const OUString& rShortName ); - sal_uInt16 GetExportFormatNumberForShortName( const OUString& rShortName ); + sal_uInt16 GetExportFormatNumber( std::u16string_view rFormatName ); + sal_uInt16 GetExportFormatNumberForMediaType( std::u16string_view rShortName ); + sal_uInt16 GetExportFormatNumberForShortName( std::u16string_view rShortName ); OUString GetExportInternalFilterName( sal_uInt16 nFormat ); - sal_uInt16 GetExportFormatNumberForTypeName( const OUString& rType ); + sal_uInt16 GetExportFormatNumberForTypeName( std::u16string_view rType ); OUString GetExportFormatName( sal_uInt16 nFormat ); OUString GetExportFormatMediaType( sal_uInt16 nFormat ); OUString GetExportFormatShortName( sal_uInt16 nFormat ); |