diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2018-02-16 23:15:56 +0100 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2018-02-18 17:23:53 +0100 |
| commit | ff570b4b58dbf274d3094d21d974f18b613e9b4b (patch) | |
| tree | 4cd4afd59a1ceb3d2f383fe0cebd05d076a589bb /include/xmloff | |
| parent | 22c7aa82a2118e3f1a832521cea8df82eaff77c8 (diff) | |
DocumentSettingsSerializer must be SAL_DLLPUBLIC_RTTI for dynamic_cast
...in SdXMLImport::SetConfigurationSettings (xmloff/source/draw/sdxmlimp.cxx) to
work with instances of sd::DocumentSettings (defined in
sd/source/ui/unoidl/UnoDocumentSettings.cxx, derived from
DocumentSettingsSerializer), at least on platforms using the strict by-address
RTTI equality check form (e.g., macOS).
(Cross-casts like this are not detected by loplugin:dyncastvisibility.)
Change-Id: I3f8712f9c64852cc8cb17c0c25211963360f117c
Reviewed-on: https://gerrit.libreoffice.org/49884
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'include/xmloff')
| -rw-r--r-- | include/xmloff/settingsstore.hxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/xmloff/settingsstore.hxx b/include/xmloff/settingsstore.hxx index e78ae0a82ca3..0878a5ec288f 100644 --- a/include/xmloff/settingsstore.hxx +++ b/include/xmloff/settingsstore.hxx @@ -18,7 +18,7 @@ // Scans list of properties for certain URL properties that could refer // to internal objects, and initializes from these. -class DocumentSettingsSerializer { +class SAL_DLLPUBLIC_RTTI DocumentSettingsSerializer { public: // Import objects and update properties (eliding URLs) virtual css::uno::Sequence<css::beans::PropertyValue> |