diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2019-04-16 16:11:39 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2019-05-03 13:46:25 +0200 |
| commit | 9a7aa3326d087c79879e435179e359dd76aa5e0a (patch) | |
| tree | 444364cd0af0a8741b2ec206e29a8cb5cda1ef57 /include/xmloff | |
| parent | c0038f61aff45595c962911f16dfdef93f41924e (diff) | |
The -fvisibility-ms-compat hack is no longer needed for UBSan on Linux...
...with latest Clang trunk towards Clang 9. All the no-longer necessary hacks
are made conditional on new NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY, which is
still set for UBSan builds with older Clang on Linux (but which should
eventually be purged).
Various classes needed additional SAL_DLLPUBLIC_RTTI annotations, as building
with UBSan instrumentation can generate references to RTTI symbols from
additional places like outside a dynamic library that used to hide those symbols
by default (but used to not hide them for old UBSan builds thanks to the
-fvisibility-ms-compat hack).
The odr-violation suppressions in solenv/sanitizers/asan-suppressions (which is
not referenced from anywhere in the code base, but meant to be included in an
ASan/UBSan build's ASAN_OPTIONS env var) are also no longer needed when
NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY is false.
Change-Id: I24ec3e388b0cbab50dbe2bf008d9569bff7bf25a
Reviewed-on: https://gerrit.libreoffice.org/70829
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'include/xmloff')
| -rw-r--r-- | include/xmloff/NamedBoolPropertyHdl.hxx | 2 | ||||
| -rw-r--r-- | include/xmloff/controlpropertyhdl.hxx | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/include/xmloff/NamedBoolPropertyHdl.hxx b/include/xmloff/NamedBoolPropertyHdl.hxx index d5fe6eb83927..1a5609c4042e 100644 --- a/include/xmloff/NamedBoolPropertyHdl.hxx +++ b/include/xmloff/NamedBoolPropertyHdl.hxx @@ -26,7 +26,7 @@ /** PropertyHandler for a named xml bool type: */ -class XMLNamedBoolPropertyHdl : public XMLPropertyHandler +class SAL_DLLPUBLIC_RTTI XMLNamedBoolPropertyHdl : public XMLPropertyHandler { private: const OUString maTrueStr; diff --git a/include/xmloff/controlpropertyhdl.hxx b/include/xmloff/controlpropertyhdl.hxx index 141111816dad..51f95986af0d 100644 --- a/include/xmloff/controlpropertyhdl.hxx +++ b/include/xmloff/controlpropertyhdl.hxx @@ -36,7 +36,7 @@ namespace xmloff //= ORotationAngleHandler - class ORotationAngleHandler : public XMLPropertyHandler + class SAL_DLLPUBLIC_RTTI ORotationAngleHandler : public XMLPropertyHandler { public: ORotationAngleHandler(); @@ -48,7 +48,7 @@ namespace xmloff //= OFontWidthHandler - class OFontWidthHandler : public XMLPropertyHandler + class SAL_DLLPUBLIC_RTTI OFontWidthHandler : public XMLPropertyHandler { public: OFontWidthHandler(); @@ -60,7 +60,7 @@ namespace xmloff //= OControlBorderHandlerBase - class OControlBorderHandler : public XMLPropertyHandler + class SAL_DLLPUBLIC_RTTI OControlBorderHandler : public XMLPropertyHandler { public: enum BorderFacet |