loplugin:countusersofdefaultparams

Change-Id: I69f55593e6101906e0e97565f2cfc818852258dd
Reviewed-on: https://gerrit.libreoffice.org/28486
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

9 files changed, 28 insertions, 31 deletions

diff --git a/include/xmloff/SchXMLImportHelper.hxx b/include/xmloff/SchXMLImportHelper.hxx
index 765a96014c9e..0e513e076c82 100644
--- a/include/xmloff/SchXMLImportHelper.hxx
+++ b/include/xmloff/SchXMLImportHelper.hxx
@@ -137,7 +137,7 @@ public:
                     const css::uno::Reference< css::chart2::XChartDocument > & xDoc,
                     sal_Int32 nCoordinateSystemIndex,
                     const OUString & rChartTypeName,
-                    bool bPushLastChartType = false );
+                    bool bPushLastChartType );
 
     static void DeleteDataSeries(
                     const css::uno::Reference< css::chart2::XDataSeries >& xSeries,
diff --git a/include/xmloff/nmspmap.hxx b/include/xmloff/nmspmap.hxx
index 5f2bac1de514..0a2849df7d8c 100644
--- a/include/xmloff/nmspmap.hxx
+++ b/include/xmloff/nmspmap.hxx
@@ -119,7 +119,7 @@ public:
 
     /* This will replace the version with the unused 3rd default parameter */
     sal_uInt16 GetKeyByAttrName_( const OUString& rAttrName,
-                             OUString *pLocalName = nullptr) const;
+                             OUString *pLocalName) const;
 
     sal_uInt16 GetFirstKey() const;
     sal_uInt16 GetNextKey( sal_uInt16 nOldKey ) const;
@@ -134,7 +134,7 @@ public:
     static bool NormalizeURI( OUString& rName );
 
 /* deprecated */ void AddAtIndex( sal_uInt16 nIdx, const OUString& rPrefix,
-                     const OUString& rName, sal_uInt16 nKey = XML_NAMESPACE_UNKNOWN );
+                     const OUString& rName, sal_uInt16 nKey );
 /* deprecated */ static sal_uInt16 GetIndexByKey( sal_uInt16 nKey );
 /* deprecated */ sal_uInt16 GetIndexByPrefix( const OUString& rPrefix ) const;
 /* deprecated */ sal_uInt16 GetFirstIndex() const;
@@ -147,7 +147,7 @@ public:
 /* deprecated */ sal_uInt16 GetKeyByAttrName( const OUString& rAttrName,
                              OUString *pPrefix,
                              OUString *pLocalName,
-                             OUString *pNamespace=nullptr,
+                             OUString *pNamespace,
                              sal_uInt16 nIdxGuess = USHRT_MAX ) const;
 /* deprecated */ sal_uInt16 GetKeyByAttrName( const OUString& rAttrName,
                              OUString *pLocalName = nullptr,
diff --git a/include/xmloff/styleexp.hxx b/include/xmloff/styleexp.hxx
index 1f4cb92995c8..0e89d4880ea5 100644
--- a/include/xmloff/styleexp.hxx
+++ b/include/xmloff/styleexp.hxx
@@ -75,7 +75,7 @@ protected:
         const OUString& rXMLFamily,
         const rtl::Reference < SvXMLExportPropertyMapper >& rPropMapper,
         const css::uno::Reference< css::container::XNameAccess > & xStyles,
-        const OUString* pPrefix = nullptr );
+        const OUString* pPrefix );
 
     virtual void exportStyleAttributes(
         const css::uno::Reference< css::style::XStyle > & rStyle );
@@ -109,13 +109,13 @@ public:
     void exportStyleFamily(
         const OUString& rFamily, const OUString& rXMLFamily,
         const rtl::Reference < SvXMLExportPropertyMapper >& rPropMapper,
-        bool bUsed, sal_uInt16 nFamily = 0,
+        bool bUsed, sal_uInt16 nFamily,
         const OUString* pPrefix = nullptr);
 
     void exportStyleFamily(
         const sal_Char *pFamily, const OUString& rXMLFamily,
         const rtl::Reference < SvXMLExportPropertyMapper >& rPropMapper,
-        bool bUsed, sal_uInt16 nFamily = 0,
+        bool bUsed, sal_uInt16 nFamily,
         const OUString* pPrefix = nullptr);
 };
 
diff --git a/include/xmloff/table/XMLTableImport.hxx b/include/xmloff/table/XMLTableImport.hxx
index 7d5ddf041aa1..df5f5eddd619 100644
--- a/include/xmloff/table/XMLTableImport.hxx
+++ b/include/xmloff/table/XMLTableImport.hxx
@@ -57,7 +57,7 @@ public:
 
     void addTableTemplate( const OUString& rsStyleName, XMLTableTemplate& xTableTemplate );
     /// Inserts to the doc template with given name.
-    void insertTabletemplate( const OUString& rsStyleName, bool bOverwrite = false);
+    void insertTabletemplate( const OUString& rsStyleName, bool bOverwrite);
     /// Inserts all table templates.
     void finishStyles();
 
diff --git a/include/xmloff/txtimp.hxx b/include/xmloff/txtimp.hxx
index 225d8c7e15e9..ceaf392d6bb2 100644
--- a/include/xmloff/txtimp.hxx
+++ b/include/xmloff/txtimp.hxx
@@ -496,7 +496,7 @@ public:
             const OUString& rTargetFrameName,
             const OUString& rStyleName,
             const OUString& rVisitedStyleName,
-            XMLEventsImportContext* pEvents = nullptr);
+            XMLEventsImportContext* pEvents);
     void SetRuby(
             SvXMLImport& rImport,
             const css::uno::Reference< css::text::XTextCursor >& rCursor,
diff --git a/include/xmloff/txtparae.hxx b/include/xmloff/txtparae.hxx
index fc3edc0d7a8d..99d9ce877ca4 100644
--- a/include/xmloff/txtparae.hxx
+++ b/include/xmloff/txtparae.hxx
@@ -264,7 +264,7 @@ protected:
 
     void exportPageFrames( bool bProgress );
     void exportFrameFrames( bool bAutoStyles, bool bProgress,
-            const css::uno::Reference< css::text::XTextFrame > *pParentTxtFrame = nullptr );
+            const css::uno::Reference< css::text::XTextFrame > *pParentTxtFrame );
 
     void exportNumStyles( bool bUsed );
 
@@ -292,7 +292,7 @@ protected:
         bool bAutoStyles, bool bProgress,
         bool bExportParagraph,
         MultiPropertySetHelper& rPropSetHelper,
-        TextPNS eExtensionNS = TextPNS::ODF);
+        TextPNS eExtensionNS);
 
     virtual void exportTable(
         const css::uno::Reference< css::text::XTextContent > & rTextContent,
@@ -311,7 +311,7 @@ protected:
         const css::uno::Reference< css::text::XTextContent > & rTextContent,
         FrameType eTxpe,
         bool bAutoStyles, bool bProgress, bool bExportContent,
-        const css::uno::Reference< css::beans::XPropertySet > *pRangePropSet = nullptr );
+        const css::uno::Reference< css::beans::XPropertySet > *pRangePropSet );
     void _exportTextFrame(
         const css::uno::Reference< css::beans::XPropertySet > & rPropSet,
         const css::uno::Reference< css::beans::XPropertySetInfo > & rPropSetInfo,
@@ -457,9 +457,7 @@ public:
                                                 SvXMLExport& rExport);
 
     // This methods exports all (or all used) styles
-    void exportTextStyles( bool bUsed
-                           , bool bProg = false
-                         );
+    void exportTextStyles( bool bUsed, bool bProg );
 
     /// This method exports (text field) declarations etc.
     void exportTextDeclarations();
@@ -512,15 +510,14 @@ public:
     void collectTextAutoStyles(
         const css::uno::Reference< css::text::XText > & rText,
         const css::uno::Reference< css::text::XTextSection > & rBaseSection,
-        bool bIsProgress = false )
+        bool bIsProgress )
     {
         exportText( rText, rBaseSection, true, bIsProgress, true/*bExportParagraph*/ );
     }
 
     // It the model implements the xAutoStylesSupplier interface, the automatic
     // styles can exported without iterating over the text portions
-    bool collectTextAutoStylesOptimized(
-        bool bIsProgress = false );
+    bool collectTextAutoStylesOptimized( bool bIsProgress );
 
     // This method exports all automatic styles that have been collected.
     void exportTextAutoStyles();
@@ -543,19 +540,19 @@ public:
     void exportText(
         const css::uno::Reference< css::text::XText > & rText,
         const css::uno::Reference< css::text::XTextSection > & rBaseSection,
-        bool bIsProgress = false,
+        bool bIsProgress,
         TextPNS eExtensionNS = TextPNS::ODF)
     {
         exportText( rText, rBaseSection, false, bIsProgress, true/*bExportParagraph*/, eExtensionNS );
     }
 
-    void exportFramesBoundToPage( bool bIsProgress = false )
+    void exportFramesBoundToPage( bool bIsProgress )
     {
         exportPageFrames( bIsProgress );
     }
     void exportFramesBoundToFrame(
             const css::uno::Reference< css::text::XTextFrame >& rParentTxtFrame,
-            bool bIsProgress = false )
+            bool bIsProgress )
     {
         exportFrameFrames( false, bIsProgress, &rParentTxtFrame );
     }
diff --git a/include/xmloff/xmlexppr.hxx b/include/xmloff/xmlexppr.hxx
index 0df386996248..7ad68bb981f4 100644
--- a/include/xmloff/xmlexppr.hxx
+++ b/include/xmloff/xmlexppr.hxx
@@ -88,7 +88,7 @@ protected:
                      const SvXMLUnitConverter& rUnitConverter,
                      const SvXMLNamespaceMap& rNamespaceMap,
                      SvXmlExportFlags nFlags,
-                     const ::std::vector< XMLPropertyState > *pProperties = nullptr,
+                     const ::std::vector< XMLPropertyState > *pProperties,
                      sal_uInt32 nIdx = 0 ) const;
 
     void exportElementItems(
@@ -133,7 +133,7 @@ public:
     void exportXML(
             SvXMLExport& rExport,
             const ::std::vector< XMLPropertyState >& rProperties,
-            SvXmlExportFlags nFlags = SvXmlExportFlags::NONE,
+            SvXmlExportFlags nFlags,
             bool bUseExtensionNamespaceForGraphicProperties = false ) const;
 
     /** like above but only properties whose property map index is within the
@@ -145,7 +145,7 @@ public:
             SvXMLExport& rExport,
             const ::std::vector< XMLPropertyState >& rProperties,
             sal_Int32 nPropMapStartIdx, sal_Int32 nPropMapEndIdx,
-            SvXmlExportFlags nFlags = SvXmlExportFlags::NONE, bool bExtensionNamespace = false ) const;
+            SvXmlExportFlags nFlags, bool bExtensionNamespace = false ) const;
 
     /** this method is called for every item that has the
         MID_FLAG_ELEMENT_EXPORT flag set */
@@ -153,7 +153,7 @@ public:
             SvXMLExport& rExport,
             const XMLPropertyState& rProperty,
             SvXmlExportFlags nFlags,
-            const ::std::vector< XMLPropertyState > *pProperties = nullptr,
+            const ::std::vector< XMLPropertyState > *pProperties,
             sal_uInt32 nIdx = 0 ) const;
 
     /** this method is called for every item that has the
@@ -163,7 +163,7 @@ public:
             const XMLPropertyState& rProperty,
             const SvXMLUnitConverter& rUnitConverter,
             const SvXMLNamespaceMap& rNamespaceMap,
-            const ::std::vector< XMLPropertyState > *pProperties = nullptr,
+            const ::std::vector< XMLPropertyState > *pProperties,
             sal_uInt32 nIdx = 0 ) const;
 
     const rtl::Reference<XMLPropertySetMapper>& getPropertySetMapper() const;
diff --git a/include/xmloff/xmlimppr.hxx b/include/xmloff/xmlimppr.hxx
index cd140e8bca0b..308f6be0ec84 100644
--- a/include/xmloff/xmlimppr.hxx
+++ b/include/xmloff/xmlimppr.hxx
@@ -133,7 +133,7 @@ public:
 
         // parameter for use by txtstyli.cxx; allows efficient
         // catching the combined characters property
-        ContextID_Index_Pair* pSpecialContextIds = nullptr );
+        ContextID_Index_Pair* pSpecialContextIds );
 
     /** implementation helper for FillPropertySet: fill an XMultiPropertySet.
      * If unsuccessul, set return value. */
@@ -145,7 +145,7 @@ public:
 
         // parameters for use by txtstyli.cxx; allows efficient
         // catching the combined characters property
-        ContextID_Index_Pair* pSpecialContextIds = nullptr );
+        ContextID_Index_Pair* pSpecialContextIds );
 
     /** implementation helper for FillPropertySet: fill an XTolerantMultiPropertySet.
      * If unsuccessul, set return value. */
@@ -157,7 +157,7 @@ public:
 
         // parameters for use by txtstyli.cxx; allows efficient
         // catching the combined characters property
-        ContextID_Index_Pair* pSpecialContextIds = nullptr );
+        ContextID_Index_Pair* pSpecialContextIds );
 
 
     static void PrepareForMultiPropertySet_(
diff --git a/include/xmloff/xmlnume.hxx b/include/xmloff/xmlnume.hxx
index e343865494dc..9fe84190e0d4 100644
--- a/include/xmloff/xmlnume.hxx
+++ b/include/xmloff/xmlnume.hxx
@@ -52,7 +52,7 @@ class XMLOFF_DLLPUBLIC SvxXMLNumRuleExport
     SAL_DLLPRIVATE void exportLevelStyle(
             sal_Int32 nLevel,
             const css::uno::Sequence< css::beans::PropertyValue>& rProps,
-            bool bOutline=false );
+            bool bOutline );
 
 protected:
 
@@ -76,7 +76,7 @@ public:
 
     void exportStyles( bool bUsed,
                        XMLTextListAutoStylePool *pPool,
-                       bool bExportChapterNumbering = true );
+                       bool bExportChapterNumbering );
     void exportNumberingRule(
             const OUString& rName, bool bIsHidden,
             const css::uno::Reference< css::container::XIndexReplace > & xNumRule );