clang-tidy performance-unnecessary-value-param in vcl

Change-Id: I403f148060891feec56d7d2ef173a9c4934baf9e
Reviewed-on: https://gerrit.libreoffice.org/23995
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

5 files changed, 7 insertions, 7 deletions

diff --git a/include/vcl/bitmap.hxx b/include/vcl/bitmap.hxx
index 7dcc84442801..e534d200e085 100644
--- a/include/vcl/bitmap.hxx
+++ b/include/vcl/bitmap.hxx
@@ -718,7 +718,7 @@ public:
 
     SAL_DLLPRIVATE void     ImplMakeUnique();
     std::shared_ptr<ImpBitmap> ImplGetImpBitmap() const { return mxImpBmp;}
-    SAL_DLLPRIVATE void     ImplSetImpBitmap( std::shared_ptr<ImpBitmap> xImpBmp );
+    SAL_DLLPRIVATE void     ImplSetImpBitmap( const std::shared_ptr<ImpBitmap>& xImpBmp );
     SAL_DLLPRIVATE void     ImplAssignWithSize( const Bitmap& rBitmap );
 
     SAL_DLLPRIVATE void     ImplAdaptBitCount(Bitmap& rNew) const;
diff --git a/include/vcl/embeddedfontshelper.hxx b/include/vcl/embeddedfontshelper.hxx
index cae59da32ab7..e986e500032a 100644
--- a/include/vcl/embeddedfontshelper.hxx
+++ b/include/vcl/embeddedfontshelper.hxx
@@ -46,7 +46,7 @@ public:
       @param key key to xor the data with, from the start until the key's length (not repeated)
       @param eot whether the data is compressed in Embedded OpenType format
     */
-    static bool addEmbeddedFont( css::uno::Reference< css::io::XInputStream > stream,
+    static bool addEmbeddedFont( const css::uno::Reference< css::io::XInputStream >& stream,
         const OUString& fontName, const char* extra,
         std::vector< unsigned char > key = std::vector< unsigned char >(), bool eot = false);
 
diff --git a/include/vcl/floatwin.hxx b/include/vcl/floatwin.hxx
index d414fb811a93..92ca7937d4a0 100644
--- a/include/vcl/floatwin.hxx
+++ b/include/vcl/floatwin.hxx
@@ -131,7 +131,7 @@ public:
                                                  sal_uInt16& rArrangeIndex );
                    static Point     ImplConvertToAbsPos(vcl::Window* pReference, const Point& rPos);
                    static Rectangle ImplConvertToAbsPos(vcl::Window* pReference, const Rectangle& rRect);
-    SAL_DLLPRIVATE void             ImplEndPopupMode( FloatWinPopupEndFlags nFlags = FloatWinPopupEndFlags::NONE, VclPtr<vcl::Window> xFocusId = nullptr );
+    SAL_DLLPRIVATE void             ImplEndPopupMode( FloatWinPopupEndFlags nFlags = FloatWinPopupEndFlags::NONE, const VclPtr<vcl::Window>& xFocusId = nullptr );
     SAL_DLLPRIVATE Rectangle&       ImplGetItemEdgeClipRect();
     SAL_DLLPRIVATE bool             ImplIsInPrivatePopupMode() const { return mbInPopupMode; }
     virtual        void             doDeferredInit(WinBits nBits) override;
diff --git a/include/vcl/print.hxx b/include/vcl/print.hxx
index 9133ed2f0b35..e92e13d60d82 100644
--- a/include/vcl/print.hxx
+++ b/include/vcl/print.hxx
@@ -381,13 +381,13 @@ public:
     static bool                 PreparePrintJob( std::shared_ptr<vcl::PrinterController> i_pController,
                                     const JobSetup& i_rInitSetup );
     static bool                 ExecutePrintJob( std::shared_ptr<vcl::PrinterController> i_pController );
-    static void                 FinishPrintJob( std::shared_ptr<vcl::PrinterController> i_pController );
+    static void                 FinishPrintJob( const std::shared_ptr<vcl::PrinterController>& i_pController );
 
     /** Implementation detail of PrintJob being asynchronous
 
         not exported, not usable outside vcl
     */
-    static void SAL_DLLPRIVATE  ImplPrintJob( std::shared_ptr<vcl::PrinterController> i_pController,
+    static void SAL_DLLPRIVATE  ImplPrintJob( const std::shared_ptr<vcl::PrinterController>& i_pController,
                                     const JobSetup& i_rInitSetup );
 };
 
diff --git a/include/vcl/window.hxx b/include/vcl/window.hxx
index 1f0cddd37d72..4c22c617e831 100644
--- a/include/vcl/window.hxx
+++ b/include/vcl/window.hxx
@@ -1229,7 +1229,7 @@ public:
     virtual css::uno::Reference< css::accessibility::XAccessible >
                                         CreateAccessible();
 
-    void                                SetAccessible( css::uno::Reference< css::accessibility::XAccessible > );
+    void                                SetAccessible( const css::uno::Reference< css::accessibility::XAccessible >& );
 
     vcl::Window*                        GetAccessibleParentWindow() const;
     sal_uInt16                          GetAccessibleChildWindowCount();
@@ -1508,7 +1508,7 @@ public:
      * Adds this widget to the xGroup VclSizeGroup
      *
      */
-    void add_to_size_group(std::shared_ptr<VclSizeGroup> xGroup);
+    void add_to_size_group(const std::shared_ptr<VclSizeGroup>& xGroup);
     void remove_from_all_size_groups();
 
     /*