clang-tidy performance-unnecessary-value-param

Change-Id: I6ed8c54c7c45931d91709cc818f2483c70197192
Reviewed-on: https://gerrit.libreoffice.org/38400
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

11 files changed, 30 insertions, 30 deletions

diff --git a/include/avmedia/MediaControlBase.hxx b/include/avmedia/MediaControlBase.hxx
index bc73f64cf66a..29e1ab7b4fc4 100644
--- a/include/avmedia/MediaControlBase.hxx
+++ b/include/avmedia/MediaControlBase.hxx
@@ -72,10 +72,10 @@ protected:
     static Image GetImage(sal_Int32 nImageId);
     virtual void InitializeWidgets();
     virtual void UpdateToolBoxes( MediaItem aMediaItem );
-    void UpdateVolumeSlider( MediaItem aMediaItem );
-    void UpdateTimeSlider( MediaItem aMediaItem );
-    void UpdateTimeField( MediaItem aMediaItem, double fTime );
-    void SelectPlayToolBoxItem( MediaItem& aExecItem, MediaItem aItem, sal_uInt16 nId);
+    void UpdateVolumeSlider( MediaItem const & aMediaItem );
+    void UpdateTimeSlider( MediaItem const & aMediaItem );
+    void UpdateTimeField( MediaItem const & aMediaItem, double fTime );
+    void SelectPlayToolBoxItem( MediaItem& aExecItem, MediaItem const & aItem, sal_uInt16 nId);
 };
 
 }
diff --git a/include/oox/core/relationshandler.hxx b/include/oox/core/relationshandler.hxx
index 314e95a29b39..1aa84ad1aa48 100644
--- a/include/oox/core/relationshandler.hxx
+++ b/include/oox/core/relationshandler.hxx
@@ -44,7 +44,7 @@ class RelationsFragment : public FragmentHandler
 public:
     explicit            RelationsFragment(
                             XmlFilterBase& rFilter,
-                            RelationsRef xRelations );
+                            const RelationsRef& xRelations );
 
     virtual css::uno::Reference< css::xml::sax::XFastContextHandler > SAL_CALL
                         createFastChildContext(
diff --git a/include/oox/drawingml/connectorshapecontext.hxx b/include/oox/drawingml/connectorshapecontext.hxx
index 71b5e50ff6bf..57982230bc34 100644
--- a/include/oox/drawingml/connectorshapecontext.hxx
+++ b/include/oox/drawingml/connectorshapecontext.hxx
@@ -34,7 +34,7 @@ namespace oox { namespace drawingml {
 class OOX_DLLPUBLIC ConnectorShapeContext : public ShapeContext
 {
 public:
-    ConnectorShapeContext( ::oox::core::ContextHandler2Helper& rParent, ShapePtr pMasterShapePtr, ShapePtr pGroupShapePtr );
+    ConnectorShapeContext( ::oox::core::ContextHandler2Helper& rParent, const ShapePtr& pMasterShapePtr, const ShapePtr& pGroupShapePtr );
     virtual ~ConnectorShapeContext() override;
     virtual ::oox::core::ContextHandlerRef onCreateContext( ::sal_Int32 Element, const ::oox::AttributeList& rAttribs ) override;
 };
diff --git a/include/oox/drawingml/graphicshapecontext.hxx b/include/oox/drawingml/graphicshapecontext.hxx
index 22218fdee265..403fdea79018 100644
--- a/include/oox/drawingml/graphicshapecontext.hxx
+++ b/include/oox/drawingml/graphicshapecontext.hxx
@@ -36,7 +36,7 @@ namespace oox { namespace drawingml {
 class OOX_DLLPUBLIC GraphicShapeContext : public ShapeContext
 {
 public:
-    GraphicShapeContext( ::oox::core::ContextHandler2Helper& rParent, ShapePtr pMasterShapePtr, ShapePtr pShapePtr );
+    GraphicShapeContext( ::oox::core::ContextHandler2Helper& rParent, const ShapePtr& pMasterShapePtr, const ShapePtr& pShapePtr );
 
     virtual ::oox::core::ContextHandlerRef onCreateContext( ::sal_Int32 Element, const ::oox::AttributeList& rAttribs ) override;
 };
@@ -45,7 +45,7 @@ public:
 class OOX_DLLPUBLIC GraphicalObjectFrameContext : public ShapeContext
 {
 public:
-    GraphicalObjectFrameContext( ::oox::core::ContextHandler2Helper& rParent, ShapePtr pMasterShapePtr, ShapePtr pShapePtr, bool bEmbedShapesInChart );
+    GraphicalObjectFrameContext( ::oox::core::ContextHandler2Helper& rParent, const ShapePtr& pMasterShapePtr, const ShapePtr& pShapePtr, bool bEmbedShapesInChart );
 
     virtual ::oox::core::ContextHandlerRef onCreateContext( ::sal_Int32 Element, const ::oox::AttributeList& rAttribs ) override;
     virtual void onEndElement() override;
@@ -59,7 +59,7 @@ private:
 class OleObjectGraphicDataContext : public ShapeContext
 {
 public:
-    OleObjectGraphicDataContext( ::oox::core::ContextHandler2Helper& rParent, ShapePtr pShapePtr );
+    OleObjectGraphicDataContext( ::oox::core::ContextHandler2Helper& rParent, const ShapePtr& pShapePtr );
     virtual ~OleObjectGraphicDataContext() override;
     virtual ::oox::core::ContextHandlerRef onCreateContext( ::sal_Int32 Element, const ::oox::AttributeList& rAttribs ) override;
 
@@ -72,7 +72,7 @@ class DiagramGraphicDataContext
     : public ShapeContext
 {
 public:
-    DiagramGraphicDataContext( ::oox::core::ContextHandler2Helper& rParent, ShapePtr pShapePtr );
+    DiagramGraphicDataContext( ::oox::core::ContextHandler2Helper& rParent, const ShapePtr& pShapePtr );
     virtual ~DiagramGraphicDataContext() override;
     virtual ::oox::core::ContextHandlerRef onCreateContext( ::sal_Int32 Element, const ::oox::AttributeList& rAttribs ) override;
 
diff --git a/include/oox/ppt/pptgraphicshapecontext.hxx b/include/oox/ppt/pptgraphicshapecontext.hxx
index 44b0438f6bc9..ba01f726c552 100644
--- a/include/oox/ppt/pptgraphicshapecontext.hxx
+++ b/include/oox/ppt/pptgraphicshapecontext.hxx
@@ -36,7 +36,7 @@ class PPTGraphicShapeContext : public ::oox::drawingml::GraphicShapeContext
     SlidePersistPtr     mpSlidePersistPtr;
 
 public:
-    PPTGraphicShapeContext( ::oox::core::ContextHandler2Helper& rParent, const SlidePersistPtr& rSlidePersistPtr, oox::drawingml::ShapePtr pMasterShapePtr, oox::drawingml::ShapePtr pShapePtr );
+    PPTGraphicShapeContext( ::oox::core::ContextHandler2Helper& rParent, const SlidePersistPtr& rSlidePersistPtr, const oox::drawingml::ShapePtr& pMasterShapePtr, const oox::drawingml::ShapePtr& pShapePtr );
     virtual ::oox::core::ContextHandlerRef onCreateContext( ::sal_Int32 Element, const ::oox::AttributeList& rAttribs ) override;
 };
 
diff --git a/include/oox/ppt/pptshapecontext.hxx b/include/oox/ppt/pptshapecontext.hxx
index f3a643f9f175..c58296ff0ccd 100644
--- a/include/oox/ppt/pptshapecontext.hxx
+++ b/include/oox/ppt/pptshapecontext.hxx
@@ -36,7 +36,7 @@ class PPTShapeContext : public ::oox::drawingml::ShapeContext
     SlidePersistPtr     mpSlidePersistPtr;
 
 public:
-    PPTShapeContext( ::oox::core::ContextHandler2Helper& rParent, const SlidePersistPtr& rSlidePersistPtr, oox::drawingml::ShapePtr pMasterShapePtr, oox::drawingml::ShapePtr pShapePtr );
+    PPTShapeContext( ::oox::core::ContextHandler2Helper& rParent, const SlidePersistPtr& rSlidePersistPtr, const oox::drawingml::ShapePtr& pMasterShapePtr, const oox::drawingml::ShapePtr& pShapePtr );
     virtual ::oox::core::ContextHandlerRef onCreateContext( ::sal_Int32 Element, const ::oox::AttributeList& rAttribs ) override;
 };
 
diff --git a/include/oox/ppt/pptshapegroupcontext.hxx b/include/oox/ppt/pptshapegroupcontext.hxx
index 91d78e904b0c..011cdff62a86 100644
--- a/include/oox/ppt/pptshapegroupcontext.hxx
+++ b/include/oox/ppt/pptshapegroupcontext.hxx
@@ -47,8 +47,8 @@ public:
         ::oox::core::ContextHandler2Helper& rParent,
         const oox::ppt::SlidePersistPtr& rSlidePersistPtr,
         const oox::ppt::ShapeLocation eShapeLocation,
-        oox::drawingml::ShapePtr pMasterShapePtr,
-        oox::drawingml::ShapePtr pGroupShapePtr );
+        const oox::drawingml::ShapePtr& pMasterShapePtr,
+        const oox::drawingml::ShapePtr& pGroupShapePtr );
 
     virtual ::oox::core::ContextHandlerRef
         onCreateContext( ::sal_Int32 Element, const ::oox::AttributeList& rAttribs ) override;
diff --git a/include/oox/ppt/slidefragmenthandler.hxx b/include/oox/ppt/slidefragmenthandler.hxx
index b6b4a3d57721..545a55bd1a56 100644
--- a/include/oox/ppt/slidefragmenthandler.hxx
+++ b/include/oox/ppt/slidefragmenthandler.hxx
@@ -37,7 +37,7 @@ namespace oox { namespace ppt {
 class SlideFragmentHandler : public ::oox::core::FragmentHandler2
 {
 public:
-    SlideFragmentHandler( ::oox::core::XmlFilterBase& rFilter, const OUString& rFragmentPath, SlidePersistPtr pPersistPtr, const ShapeLocation eShapeLocation );
+    SlideFragmentHandler( ::oox::core::XmlFilterBase& rFilter, const OUString& rFragmentPath, const SlidePersistPtr& pPersistPtr, const ShapeLocation eShapeLocation );
     virtual ~SlideFragmentHandler() override;
 
     virtual void finalizeImport() override;
diff --git a/include/svtools/svlbitm.hxx b/include/svtools/svlbitm.hxx
index c9db0cbf5a46..16106511a0b5 100644
--- a/include/svtools/svlbitm.hxx
+++ b/include/svtools/svlbitm.hxx
@@ -229,8 +229,8 @@ class SVT_DLLPUBLIC SvLBoxContextBmp : public SvLBoxItem
 {
     std::unique_ptr<SvLBoxContextBmp_Impl>  m_pImpl;
 public:
-    SvLBoxContextBmp(Image aBmp1,
-                     Image aBmp2,
+    SvLBoxContextBmp(const Image& aBmp1,
+                     const Image& aBmp2,
                      bool bExpanded);
     SvLBoxContextBmp();
     virtual ~SvLBoxContextBmp() override;
diff --git a/include/svx/cube3d.hxx b/include/svx/cube3d.hxx
index e065eef242c5..2cb6569b8e53 100644
--- a/include/svx/cube3d.hxx
+++ b/include/svx/cube3d.hxx
@@ -77,7 +77,7 @@ protected:
     virtual sdr::contact::ViewContact* CreateObjectSpecificViewContact() override;
 
 public:
-    E3dCubeObj(E3dDefaultAttributes& rDefault, basegfx::B3DPoint aPos, const basegfx::B3DVector& r3DSize);
+    E3dCubeObj(E3dDefaultAttributes& rDefault, const basegfx::B3DPoint& aPos, const basegfx::B3DVector& r3DSize);
     E3dCubeObj();
 
     virtual sal_uInt16 GetObjIdentifier() const override;
diff --git a/include/vcl/uitest/uiobject.hxx b/include/vcl/uitest/uiobject.hxx
index 2edec77ae109..de413107903e 100644
--- a/include/vcl/uitest/uiobject.hxx
+++ b/include/vcl/uitest/uiobject.hxx
@@ -105,7 +105,7 @@ class UITEST_DLLPUBLIC WindowUIObject : public UIObject
 
 public:
 
-    WindowUIObject(VclPtr<vcl::Window> xWindow);
+    WindowUIObject(const VclPtr<vcl::Window>& xWindow);
 
     virtual StringMap get_state() override;
 
@@ -138,7 +138,7 @@ class UITEST_DLLPUBLIC ButtonUIObject : public WindowUIObject
     VclPtr<Button> mxButton;
 public:
 
-    ButtonUIObject(VclPtr<Button> xButton);
+    ButtonUIObject(const VclPtr<Button>& xButton);
     virtual ~ButtonUIObject() override;
 
     virtual StringMap get_state() override;
@@ -159,7 +159,7 @@ class UITEST_DLLPUBLIC DialogUIObject : public WindowUIObject
 
 public:
 
-    DialogUIObject(VclPtr<Dialog> xDialog);
+    DialogUIObject(const VclPtr<Dialog>& xDialog);
     virtual ~DialogUIObject() override;
 
     virtual StringMap get_state() override;
@@ -177,7 +177,7 @@ class UITEST_DLLPUBLIC EditUIObject : public WindowUIObject
 
 public:
 
-    EditUIObject(VclPtr<Edit> xEdit);
+    EditUIObject(const VclPtr<Edit>& xEdit);
     virtual ~EditUIObject() override;
 
     virtual void execute(const OUString& rAction,
@@ -199,7 +199,7 @@ private:
     VclPtr<CheckBox> mxCheckBox;
 
 public:
-    CheckBoxUIObject(VclPtr<CheckBox> xCheckbox);
+    CheckBoxUIObject(const VclPtr<CheckBox>& xCheckbox);
     virtual ~CheckBoxUIObject() override;
 
     virtual void execute(const OUString& rAction,
@@ -220,7 +220,7 @@ private:
     VclPtr<RadioButton> mxRadioButton;
 
 public:
-    RadioButtonUIObject(VclPtr<RadioButton> xCheckbox);
+    RadioButtonUIObject(const VclPtr<RadioButton>& xCheckbox);
     virtual ~RadioButtonUIObject() override;
 
     virtual void execute(const OUString& rAction,
@@ -240,7 +240,7 @@ class UITEST_DLLPUBLIC TabPageUIObject : public WindowUIObject
 private:
     VclPtr<TabPage> mxTabPage;
 public:
-    TabPageUIObject(VclPtr<TabPage> xTabPage);
+    TabPageUIObject(const VclPtr<TabPage>& xTabPage);
     virtual ~TabPageUIObject() override;
 
     virtual void execute(const OUString& rAction,
@@ -262,7 +262,7 @@ private:
 
 public:
 
-    ListBoxUIObject(VclPtr<ListBox> xListBox);
+    ListBoxUIObject(const VclPtr<ListBox>& xListBox);
     virtual ~ListBoxUIObject() override;
 
     virtual void execute(const OUString& rAction,
@@ -287,7 +287,7 @@ private:
 
 public:
 
-    ComboBoxUIObject(VclPtr<ComboBox> xListBox);
+    ComboBoxUIObject(const VclPtr<ComboBox>& xListBox);
     virtual ~ComboBoxUIObject() override;
 
     virtual void execute(const OUString& rAction,
@@ -309,7 +309,7 @@ private:
 
 public:
 
-    SpinUIObject(VclPtr<SpinButton> xSpinButton);
+    SpinUIObject(const VclPtr<SpinButton>& xSpinButton);
     virtual ~SpinUIObject() override;
 
     virtual void execute(const OUString& rAction,
@@ -330,7 +330,7 @@ class UITEST_DLLPUBLIC SpinFieldUIObject : public EditUIObject
 
 public:
 
-    SpinFieldUIObject(VclPtr<SpinField> xEdit);
+    SpinFieldUIObject(const VclPtr<SpinField>& xEdit);
     virtual ~SpinFieldUIObject() override;
 
     virtual void execute(const OUString& rAction,
@@ -352,7 +352,7 @@ private:
 
 public:
 
-    TabControlUIObject(VclPtr<TabControl> mxTabControl);
+    TabControlUIObject(const VclPtr<TabControl>& mxTabControl);
     virtual ~TabControlUIObject() override;
 
     virtual void execute(const OUString& rAction,