clean up places accessing the NULL at the of an OUString

There were only a couple of real bugs fixed, but we're a little
bit safer now.
This also fixes the assert and the comment in OUString::operator[]
about this.

Change-Id: Ibe16b5794e0ba7ecd345fa0801586d25b015974c

1 files changed, 1 insertions, 5 deletions

diff --git a/include/rtl/ustring.hxx b/include/rtl/ustring.hxx
index ba8c3588aa58..45a7441f9591 100644
--- a/include/rtl/ustring.hxx
+++ b/include/rtl/ustring.hxx
@@ -417,11 +417,7 @@ public:
       @since LibreOffice 3.5
     */
     sal_Unicode operator [](sal_Int32 index) const {
-        assert(index >= 0 && index <= getLength());
-            //TODO: should really check for < getLength(), but there is quite
-            // some clever code out there that violates this function's
-            // documented precondition and relies on s[s.getLength()] == 0 and
-            // that would need to be fixed first
+        assert(index >= 0 && index < getLength());
         return getStr()[index];
     }