diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-16 09:13:14 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-16 10:15:36 +0200 |
commit | 27dadc070ec2c2a602d3c5b3494dd0bdc15c785f (patch) | |
tree | 79d9acfb57f8431b0ab224d9d2c6a5d2c840c540 /include | |
parent | 20a872d21602409cda873bb1f4830d50be3b6f8b (diff) |
loplugin:singlevalfields in sfx2
pParent in SfxDispatch_Impl was always nullptr, which led to a bunch of
dead code
similarly with pParent in SfxWorkWindow
Change-Id: I964a43fe094409ab4b6d1eda7225af997092e81c
Reviewed-on: https://gerrit.libreoffice.org/61811
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'include')
-rw-r--r-- | include/sfx2/dispatch.hxx | 4 | ||||
-rw-r--r-- | include/sfx2/printer.hxx | 3 | ||||
-rw-r--r-- | include/sfx2/progress.hxx | 1 |
3 files changed, 2 insertions, 6 deletions
diff --git a/include/sfx2/dispatch.hxx b/include/sfx2/dispatch.hxx index 9d91d7f60966..9e2f0a0379a2 100644 --- a/include/sfx2/dispatch.hxx +++ b/include/sfx2/dispatch.hxx @@ -101,7 +101,7 @@ friend class SfxHelp; SAL_DLLPRIVATE void Update_Impl_( bool,bool,bool,SfxWorkWindow*); - bool FindServer_( sal_uInt16 nId, SfxSlotServer &rServer, bool bModal ); + bool FindServer_( sal_uInt16 nId, SfxSlotServer &rServer ); bool FillState_( const SfxSlotServer &rServer, SfxItemSet &rState, const SfxSlot *pRealSlot ); void Execute_( SfxShell &rShell, const SfxSlot &rSlot, @@ -176,7 +176,7 @@ public: SAL_DLLPRIVATE void Update_Impl( bool bForce = false ); // ObjectBars etc. SAL_DLLPRIVATE bool IsUpdated_Impl() const; SAL_DLLPRIVATE bool GetShellAndSlot_Impl( sal_uInt16 nSlot, SfxShell **ppShell, const SfxSlot **ppSlot, - bool bOwnShellsOnly, bool bModal, bool bRealSlot=true ); + bool bOwnShellsOnly, bool bRealSlot ); SAL_DLLPRIVATE void SetReadOnly_Impl( bool bOn ); SAL_DLLPRIVATE bool GetReadOnly_Impl() const; SAL_DLLPRIVATE SfxSlotFilterState IsSlotEnabledByFilter_Impl( sal_uInt16 nSID ) const; diff --git a/include/sfx2/printer.hxx b/include/sfx2/printer.hxx index 9704a73562db..d7d690e78ea8 100644 --- a/include/sfx2/printer.hxx +++ b/include/sfx2/printer.hxx @@ -28,15 +28,12 @@ class SfxTabPage; class SfxItemSet; -struct SfxPrinter_Impl; - // class SfxPrinter ------------------------------------------------------ class SFX2_DLLPUBLIC SfxPrinter : public Printer { private: std::unique_ptr<SfxItemSet> pOptions; - std::unique_ptr< SfxPrinter_Impl > pImpl; bool bKnown; SAL_DLLPRIVATE void operator =(SfxPrinter &) = delete; diff --git a/include/sfx2/progress.hxx b/include/sfx2/progress.hxx index ba945002a64d..dbe529cdab29 100644 --- a/include/sfx2/progress.hxx +++ b/include/sfx2/progress.hxx @@ -55,7 +55,6 @@ public: void Suspend(); bool IsSuspended() const { return bSuspended; } - void UnLock(); void Reschedule(); void Stop(); |