make loplugin constantparam smarter about string params

Change-Id: Id3df69b38fd35f46735246a6d307a89aa10d4294
Reviewed-on: https://gerrit.libreoffice.org/37426
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

7 files changed, 8 insertions, 14 deletions

diff --git a/include/basic/sbx.hxx b/include/basic/sbx.hxx
index debfa2e535ea..6b2890688710 100644
--- a/include/basic/sbx.hxx
+++ b/include/basic/sbx.hxx
@@ -242,7 +242,7 @@ protected:
     virtual void CollRemove( SbxArray* pPar ) override;
 public:
     SBX_DECL_PERSIST_NODATA(SBXID_FIXCOLLECTION,1);
-    SbxStdCollection( const OUString& rClassname, const OUString& rElemClass );
+    SbxStdCollection();
     SbxStdCollection( const SbxStdCollection& );
     SbxStdCollection& operator=( const SbxStdCollection& );
     virtual void Insert( SbxVariable* ) override;
diff --git a/include/editeng/editview.hxx b/include/editeng/editview.hxx
index 3ff03cc7097b..a5768897a3e9 100644
--- a/include/editeng/editview.hxx
+++ b/include/editeng/editview.hxx
@@ -188,7 +188,7 @@ public:
     void                RemoveCharAttribs( sal_Int32 nPara, sal_uInt16 nWhich );
     void                RemoveAttribsKeepLanguages( bool bRemoveParaAttribs );
 
-    sal_uInt32          Read( SvStream& rInput, const OUString& rBaseURL, EETextFormat eFormat, SvKeyValueIterator* pHTTPHeaderAttrs );
+    sal_uInt32          Read( SvStream& rInput, EETextFormat eFormat, SvKeyValueIterator* pHTTPHeaderAttrs );
 
     void            SetBackgroundColor( const Color& rColor );
     Color           GetBackgroundColor() const;
diff --git a/include/svtools/imap.hxx b/include/svtools/imap.hxx
index e54bb3193ccb..871cf940ace0 100644
--- a/include/svtools/imap.hxx
+++ b/include/svtools/imap.hxx
@@ -111,8 +111,8 @@ public:
     void                Write ( SvStream& rOStm, const OUString& rBaseURL ) const;
     void                Read( SvStream& rIStm, const OUString& rBaseURL );
 
-    void                Write( SvStream& rOStm, sal_uLong nFormat, const OUString& rBaseURL ) const;
-    sal_uLong               Read( SvStream& rIStm, sal_uLong nFormat, const OUString& rBaseURL );
+    void                Write( SvStream& rOStm, sal_uLong nFormat ) const;
+    sal_uLong           Read( SvStream& rIStm, sal_uLong nFormat );
 };
 
 class IMapCompat
diff --git a/include/svtools/inetimg.hxx b/include/svtools/inetimg.hxx
index e257fc55f69d..1acee86b5d95 100644
--- a/include/svtools/inetimg.hxx
+++ b/include/svtools/inetimg.hxx
@@ -31,19 +31,16 @@ class INetImage
     OUString        aImageURL;
     OUString        aTargetURL;
     OUString        aTargetFrame;
-    OUString        aAlternateText;
     Size            aSizePixel;
 
 public:
                     INetImage(
                         const OUString& rImageURL,
                         const OUString& rTargetURL,
-                        const OUString& rTargetFrame,
-                        const OUString& rAlternateText )
+                        const OUString& rTargetFrame )
                     :   aImageURL( rImageURL ),
                         aTargetURL( rTargetURL ),
-                        aTargetFrame( rTargetFrame ),
-                        aAlternateText( rAlternateText )
+                        aTargetFrame( rTargetFrame )
                     {}
                     INetImage()
                     {}
diff --git a/include/unotools/historyoptions.hxx b/include/unotools/historyoptions.hxx
index 62457d3007bd..2d2994da7994 100644
--- a/include/unotools/historyoptions.hxx
+++ b/include/unotools/historyoptions.hxx
@@ -92,11 +92,10 @@ public:
         @param sURL      URL to save in history
         @param sFilter   filter name to save in history
         @param sTitle    document title to save in history
-        @param sPassword password to save in history
     */
     void AppendItem(EHistoryType eHistory,
             const OUString& sURL, const OUString& sFilter, const OUString& sTitle,
-            const OUString& sPassword, const boost::optional<OUString>& sThumbnail);
+            const boost::optional<OUString>& sThumbnail);
 
     /** Delete item from the specified list.
     */
diff --git a/include/vbahelper/vbahelper.hxx b/include/vbahelper/vbahelper.hxx
index 4d44a6968206..0aa29ecd6e79 100644
--- a/include/vbahelper/vbahelper.hxx
+++ b/include/vbahelper/vbahelper.hxx
@@ -262,7 +262,7 @@ class VBAHELPER_DLLPUBLIC DebugHelper
 {
 public:
     /// @throws css::script::BasicErrorException
-    static void basicexception( const OUString&  DetailedMessage, const css::uno::Exception& ex,  int err, const OUString& /*additionalArgument*/ );
+    static void basicexception( const css::uno::Exception& ex,  int err, const OUString& /*additionalArgument*/ );
 
     /// @throws css::script::BasicErrorException
     static void basicexception( int err,  const OUString& additionalArgument );
diff --git a/include/xmloff/styleexp.hxx b/include/xmloff/styleexp.hxx
index 5f215069d06a..fbe6b5107e59 100644
--- a/include/xmloff/styleexp.hxx
+++ b/include/xmloff/styleexp.hxx
@@ -57,7 +57,6 @@ class XMLOFF_DLLPUBLIC XMLStyleExport : public salhelper::SimpleReferenceObject
     const OUString sFollowStyle;
     const OUString sNumberingStyleName;
     const OUString sOutlineLevel;
-    const OUString sPoolStyleName;
     SvXMLAutoStylePoolP *pAutoStylePool;
 
 protected:
@@ -79,7 +78,6 @@ protected:
 public:
     XMLStyleExport(
         SvXMLExport& rExp,
-        const OUString& rPoolStyleName,
         SvXMLAutoStylePoolP *pAutoStyleP=nullptr );
     virtual ~XMLStyleExport() override;