perf: eliminate SfxSimpleHint and move to SfxHint, tdf#87101 related

There were over 150 places in *::Notify() functions that did some
dynamic_cast<SfxSimpleHint*> of which ~98% were unnecessary because the
base class SfxHint passed was an SfxSimpleHint anyway. dynamic_cast
operations come with quite some cost, so avoid if possible. Specifically
for ScFormulaCell::Notify() that created a bottleneck in scenarios where
cells were notified that already handled a previous notification. In
mass operations doing the dynamic_cast before it could be decided
whether having to act on it or not this made 2/3 of all time spent in
the Notify() call.

To get rid of that rename/move SfxSimpleHint to SfxHint and let classes
derive from SfxHint instead of SfxSimpleHint. This comes only with a
slight cost that an additional sal_uInt32 is transported in such hints,
initialized to 0, but this is neglectable compared to the huge gain.

For the rare cases where a Notify() actually expects both, an SfxHint
(formerly SfxSimpleHint) and a derived hint, this changed order of the
dynamic_cast involved so the simple SfxHint::GetId() is handled last.
Modules using such combinations can further optimize by treating the
simple SfxHint::GetId() first once verified that none of the other
derived hints use an ID not equal to zero respectively none of the ID
values the simple hint uses.

Change-Id: I9fcf723e3a4487ceb92336189d23a62c344cf0ce
Reviewed-on: https://gerrit.libreoffice.org/29205
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

6 files changed, 36 insertions, 68 deletions

diff --git a/include/basic/sbx.hxx b/include/basic/sbx.hxx
index 96fe6dbff9b1..35d09c45d450 100644
--- a/include/basic/sbx.hxx
+++ b/include/basic/sbx.hxx
@@ -21,7 +21,7 @@
 #define INCLUDED_BASIC_SBX_HXX
 
 #include <tools/ref.hxx>
-#include <svl/smplhint.hxx>
+#include <svl/hint.hxx>
 #include <svl/lstner.hxx>
 
 #include <basic/sbxdef.hxx>
@@ -90,11 +90,11 @@ public:
     void                SetComment( const OUString& r )   { aComment = r; }
 };
 
-class BASIC_DLLPUBLIC SbxHint : public SfxSimpleHint
+class BASIC_DLLPUBLIC SbxHint : public SfxHint
 {
     SbxVariable* pVar;
 public:
-    SbxHint( sal_uInt32 n, SbxVariable* v ) : SfxSimpleHint( n ), pVar( v ) {}
+    SbxHint( sal_uInt32 n, SbxVariable* v ) : SfxHint( n ), pVar( v ) {}
     SbxVariable* GetVar() const { return pVar; }
 };
 
diff --git a/include/sfx2/app.hxx b/include/sfx2/app.hxx
index 947387a1a090..7117b6c0bb3c 100644
--- a/include/sfx2/app.hxx
+++ b/include/sfx2/app.hxx
@@ -23,7 +23,6 @@
 #include <sfx2/dllapi.h>
 #include <sal/types.h>
 #include <tools/errcode.hxx>
-#include <svl/smplhint.hxx>
 #include <svl/poolitem.hxx>
 #include <vcl/image.hxx>
 #include <com/sun/star/script/XLibraryContainer.hpp>
diff --git a/include/svl/hint.hxx b/include/svl/hint.hxx
index 4aec70090c54..8de965d73af5 100644
--- a/include/svl/hint.hxx
+++ b/include/svl/hint.hxx
@@ -19,15 +19,43 @@
 #ifndef INCLUDED_SVL_HINT_HXX
 #define INCLUDED_SVL_HINT_HXX
 
+#include <sal/types.h>
 #include <svl/svldllapi.h>
 
+#define SFX_HINT_DYING              0x00000001
+#define SFX_HINT_NAMECHANGED        0x00000002
+#define SFX_HINT_TITLECHANGED       0x00000004
+#define SFX_HINT_DATACHANGED        0x00000008
+#define SFX_HINT_DOCCHANGED         0x00000010
+#define SFX_HINT_UPDATEDONE         0x00000020
+#define SFX_HINT_DEINITIALIZING     0x00000040
+#define SFX_HINT_MODECHANGED        0x00000080
+    // unused, formerly SFX_HINT_CANCELLABLE
+    // unused, formerly SFX_HINT_DATAAVAILABLE
+    // unused, formerly SFX_HINT_SAVECOMPLETED
+    // unused, formerly SFX_HINT_RELEASEREF
+#define SFX_HINT_COLORS_CHANGED     0x00001000
+#define SFX_HINT_CTL_SETTINGS_CHANGED   0x00002000
+#define SFX_HINT_ACCESSIBILITY_CHANGED  0x00004000
+    // unused, formerly SFX_HINT_VIEWCREATED
+#define SFX_HINT_USER00             0x00010000
+#define SFX_HINT_USER01             0x00020000
+#define SFX_HINT_USER02             0x00040000
+#define SFX_HINT_USER03             0x00080000
+#define SFX_HINT_USER04             0x00100000
+#define SFX_HINT_USER05             0x00200000
+
 class SVL_DLLPUBLIC SfxHint
 {
+private:
+    sal_uInt32 mnId;
 public:
+    SfxHint() : mnId(0) {}
+    explicit SfxHint( sal_uInt32 nId ) : mnId(nId) {}
     virtual ~SfxHint();
+    sal_uInt32 GetId() const { return mnId; }
 };
 
-
 #endif
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/svl/smplhint.hxx b/include/svl/smplhint.hxx
deleted file mode 100644
index bdf980073ab1..000000000000
--- a/include/svl/smplhint.hxx
+++ /dev/null
@@ -1,60 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the "License"); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-#ifndef INCLUDED_SVL_SMPLHINT_HXX
-#define INCLUDED_SVL_SMPLHINT_HXX
-
-#include <svl/svldllapi.h>
-#include <svl/hint.hxx>
-#include <tools/solar.h>
-
-#define SFX_HINT_DYING              0x00000001
-#define SFX_HINT_NAMECHANGED        0x00000002
-#define SFX_HINT_TITLECHANGED       0x00000004
-#define SFX_HINT_DATACHANGED        0x00000008
-#define SFX_HINT_DOCCHANGED         0x00000010
-#define SFX_HINT_UPDATEDONE         0x00000020
-#define SFX_HINT_DEINITIALIZING     0x00000040
-#define SFX_HINT_MODECHANGED        0x00000080
-    // unused, formerly SFX_HINT_CANCELLABLE
-    // unused, formerly SFX_HINT_DATAAVAILABLE
-    // unused, formerly SFX_HINT_SAVECOMPLETED
-    // unused, formerly SFX_HINT_RELEASEREF
-#define SFX_HINT_COLORS_CHANGED     0x00001000
-#define SFX_HINT_CTL_SETTINGS_CHANGED   0x00002000
-#define SFX_HINT_ACCESSIBILITY_CHANGED  0x00004000
-    // unused, formerly SFX_HINT_VIEWCREATED
-#define SFX_HINT_USER00             0x00010000
-#define SFX_HINT_USER01             0x00020000
-#define SFX_HINT_USER02             0x00040000
-#define SFX_HINT_USER03             0x00080000
-#define SFX_HINT_USER04             0x00100000
-#define SFX_HINT_USER05             0x00200000
-
-class SVL_DLLPUBLIC SfxSimpleHint: public SfxHint
-{
-private:
-    sal_uInt32 mnId;
-public:
-    SfxSimpleHint( sal_uInt32 nId ) { mnId = nId; }
-    sal_uInt32 GetId() const { return mnId; }
-};
-
-#endif
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/svx/svdpntv.hxx b/include/svx/svdpntv.hxx
index 158111542f3d..07cacf1ebfd7 100644
--- a/include/svx/svdpntv.hxx
+++ b/include/svx/svdpntv.hxx
@@ -22,7 +22,6 @@
 
 #include <svl/SfxBroadcaster.hxx>
 #include <svl/lstner.hxx>
-#include <svl/smplhint.hxx>
 #include <svl/undo.hxx>
 #include <svx/svddrag.hxx>
 #include <svx/svdlayer.hxx>
diff --git a/include/vcl/textdata.hxx b/include/vcl/textdata.hxx
index 7339f0f876b4..abcd6629dad3 100644
--- a/include/vcl/textdata.hxx
+++ b/include/vcl/textdata.hxx
@@ -20,8 +20,10 @@
 #ifndef INCLUDED_VCL_TEXTDATA_HXX
 #define INCLUDED_VCL_TEXTDATA_HXX
 
+#include <sal/types.h>
+#include <tools/solar.h>
 #include <rtl/ustring.hxx>
-#include <svl/smplhint.hxx>
+#include <svl/hint.hxx>
 #include <vcl/dllapi.h>
 
 enum class ExtTextInputAttr;
@@ -125,7 +127,7 @@ inline bool TextSelection::operator != ( const TextSelection& rSel ) const
 #define TEXT_HINT_VIEWSELECTIONCHANGED  101
 #define TEXT_HINT_VIEWCARETCHANGED      102
 
-class VCL_DLLPUBLIC TextHint : public SfxSimpleHint
+class VCL_DLLPUBLIC TextHint : public SfxHint
 {
 private:
     sal_uLong   mnValue;