loplugin:unuseddefaultparams

Change-Id: Ia414f7845425ef73859ed04853378e96cc738795
Reviewed-on: https://gerrit.libreoffice.org/22971
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

7 files changed, 16 insertions, 55 deletions

diff --git a/include/connectivity/sqlerror.hxx b/include/connectivity/sqlerror.hxx
index 06cc14504e62..fda344f0c19f 100644
--- a/include/connectivity/sqlerror.hxx
+++ b/include/connectivity/sqlerror.hxx
@@ -97,17 +97,10 @@ namespace connectivity
             error messages thrown by core components of OpenOffice.org Base will contain
             a standardized prefix "[OOoBase]" in every message.
 
-            @param _rParamValue1
-                the value which the placeholder $1$ should be replaced with. If this value is
-                not present (see <code>::boost::optional::operator !</code>), then no replacement
-                will happen, and <code>_rParamValue2</code> and <code>_rParamValue3</code> will be
-                ignored.
-
             @see css::sdb::ErrorCondition
         */
         OUString getErrorMessage(
-                            const ErrorCondition _eCondition,
-                            const ParamValue& _rParamValue1 = ParamValue()
+                            const ErrorCondition _eCondition
                         ) const;
 
         /** returns the error code associated with a given error condition
@@ -182,17 +175,11 @@ namespace connectivity
             @param  _eCondition
                 the ErrorCondition which hit you
 
-            @param _rParamValue1
-                a runtime-dependent value which should be filled into the error message
-                which is associated with <arg>_eCondition</arg>, replacing the first placeholder
-                in this message.
-
             @see getErrorMessage
             @see getErrorCode
         */
         void            raiseException(
-                            const ErrorCondition _eCondition,
-                            const ParamValue& _rParamValue1 = ParamValue()
+                            const ErrorCondition _eCondition
                         ) const;
 
         /** raises a typed exception, that is, a UNO exception which is derived from
@@ -209,11 +196,6 @@ namespace connectivity
                 the type of the exception to throw. This type <em>must</em> specify
                 an exception class derived from css::sdbc::SQLException.
 
-            @param _rParamValue1
-                a runtime-dependent value which should be filled into the error message
-                which is associated with <arg>_eCondition</arg>, replacing the first placeholder
-                in this message.
-
             @throws ::std::bad_cast
                 if <arg>_rExceptionType</arg> does not specify an exception class derived from
                 css::sdbc::SQLException.
@@ -224,8 +206,7 @@ namespace connectivity
         void            raiseTypedException(
                             const ErrorCondition _eCondition,
                             const css::uno::Reference< css::uno::XInterface >& _rxContext,
-                            const css::uno::Type& _rExceptionType,
-                            const ParamValue& _rParamValue1 = ParamValue()
+                            const css::uno::Type& _rExceptionType
                         ) const;
 
         /** retrieves an <code>SQLException</code> object which contains information about
diff --git a/include/sfx2/childwin.hxx b/include/sfx2/childwin.hxx
index bea7e9c8d5e5..1afc54dbd3e6 100644
--- a/include/sfx2/childwin.hxx
+++ b/include/sfx2/childwin.hxx
@@ -76,8 +76,7 @@ struct SAL_DLLPUBLIC_RTTI SfxChildWinInfo
                             bVisible = false;
                             nFlags = SfxChildWindowFlags::NONE;
                         }
-    bool                GetExtraData_Impl( SfxChildAlignment    *pAlign,
-                                           SfxChildAlignment    *pLastAlign = nullptr ) const;
+    bool                GetExtraData_Impl( SfxChildAlignment    *pAlign ) const;
 };
 
 // ChildWindow factory methods
diff --git a/include/svl/undo.hxx b/include/svl/undo.hxx
index cefb5fb50d85..4893dde77a1a 100644
--- a/include/svl/undo.hxx
+++ b/include/svl/undo.hxx
@@ -199,7 +199,7 @@ namespace svl
 
         virtual size_t          GetRedoActionCount( bool const i_currentLevel = CurrentLevel ) const = 0;
         virtual OUString        GetRedoActionComment( size_t nNo=0, bool const i_currentLevel = CurrentLevel ) const = 0;
-        virtual SfxUndoAction*  GetRedoAction( size_t nNo=0 ) const = 0;
+        virtual SfxUndoAction*  GetRedoAction() const = 0;
 
         virtual bool            Undo() = 0;
         virtual bool            Redo() = 0;
@@ -317,7 +317,7 @@ public:
     virtual SfxUndoAction*  GetUndoAction( size_t nNo=0 ) const override;
     virtual size_t          GetRedoActionCount( bool const i_currentLevel = CurrentLevel ) const override;
     virtual OUString        GetRedoActionComment( size_t nNo=0, bool const i_currentLevel = CurrentLevel ) const override;
-    virtual SfxUndoAction*  GetRedoAction( size_t nNo=0 ) const override;
+    virtual SfxUndoAction*  GetRedoAction() const override;
     virtual bool            Undo() override;
     virtual bool            Redo() override;
     virtual void            Clear() override;
diff --git a/include/svtools/ivctrl.hxx b/include/svtools/ivctrl.hxx
index eb803f8e2d07..0e5896512066 100644
--- a/include/svtools/ivctrl.hxx
+++ b/include/svtools/ivctrl.hxx
@@ -263,8 +263,7 @@ public:
 
 
     SvxIconChoiceCtrlEntry* InsertEntry( const OUString& rText,
-                                         const Image& rImage,
-                                         sal_uLong nPos = CONTAINER_APPEND );
+                                         const Image& rImage);
 
     /** creates automatic mnemonics for all icon texts in the control
 
diff --git a/include/svx/svdhdl.hxx b/include/svx/svdhdl.hxx
index 9afb4c05e3c3..9214f5acd8ec 100644
--- a/include/svx/svdhdl.hxx
+++ b/include/svx/svdhdl.hxx
@@ -470,7 +470,7 @@ public:
     void RemoveAllByKind(SdrHdlKind eKind);
 
     // Last inserted handles are likely hit (if the handles are above each other)
-    SdrHdl* IsHdlListHit(const Point& rPnt, bool bBack=false, bool bNext=false, SdrHdl* pHdl0=nullptr) const;
+    SdrHdl* IsHdlListHit(const Point& rPnt) const;
     SdrHdl* GetHdl(SdrHdlKind eKind1) const;
 };
 
diff --git a/include/tools/urlobj.hxx b/include/tools/urlobj.hxx
index e85d50f7f8e8..b127150739ce 100644
--- a/include/tools/urlobj.hxx
+++ b/include/tools/urlobj.hxx
@@ -327,9 +327,7 @@ public:
 
     inline bool
     GetNewAbsURL(OUString const & rTheRelURIRef,
-                 INetURLObject * pTheAbsURIRef,
-                 EncodeMechanism eMechanism = WAS_ENCODED,
-                 rtl_TextEncoding eCharset = RTL_TEXTENCODING_UTF8)
+                 INetURLObject * pTheAbsURIRef)
         const;
 
     /** @descr  If rTheRelURIRef cannot be converted to an absolute URL
@@ -576,20 +574,12 @@ public:
 
         @param rTheName  The new name.
 
-        @param nIndex  The non-negative index of the segment, or LAST_SEGMENT
-        if addressing the last segment.
-
-        @param bIgnoreFinalSlash  If true, a final slash at the end of the
-        hierarchical path does not denote an empty segment, but is ignored.
-
         @return  True if the name has successfully been modified (and the
         resulting URI is still valid).  If the path is not hierarchical, or
         the specified segment does not exist, false is returned.  If false is
         returned, the object is not modified.
      */
-    bool setName(OUString const & rTheName,
-                 sal_Int32 nIndex = LAST_SEGMENT,
-                 bool bIgnoreFinalSlash = true);
+    bool setName(OUString const & rTheName);
 
     /** Get the base of the name of a segment.
 
@@ -922,18 +912,12 @@ public:
 
     /** Get the 'extension' of the last segment in the path.
 
-        @param eMechanism  See the general discussion for get-methods.
-
-        @param eCharset  See the general discussion for get-methods.
-
         @return  For a hierarchical URL, everything after the first unencoded
         '.' in the last segment of the path.  Note that this 'extension' may
         be empty.  If the URL is not hierarchical, or if the last segment does
         not contain an unencoded '.', an empty string is returned.
      */
-    OUString GetFileExtension(DecodeMechanism eMechanism = DECODE_TO_IURI,
-                               rtl_TextEncoding eCharset
-                                   = RTL_TEXTENCODING_UTF8) const;
+    OUString GetFileExtension() const;
 
     inline bool Append(OUString const & rTheSegment,
                        EncodeMechanism eMechanism = WAS_ENCODED,
@@ -1264,15 +1248,13 @@ INetURLObject::smartRel2Abs(OUString const & rTheRelURIRef,
 }
 
 inline bool INetURLObject::GetNewAbsURL(OUString const & rTheRelURIRef,
-                                        INetURLObject * pTheAbsURIRef,
-                                        EncodeMechanism eMechanism,
-                                        rtl_TextEncoding eCharset)
+                                        INetURLObject * pTheAbsURIRef)
     const
 {
     INetURLObject aTheAbsURIRef;
     bool bWasAbsolute;
     if (!convertRelToAbs(rTheRelURIRef, false, aTheAbsURIRef, bWasAbsolute,
-                         eMechanism, eCharset, false/*bIgnoreFragment*/, false, false,
+                         WAS_ENCODED, RTL_TEXTENCODING_UTF8, false/*bIgnoreFragment*/, false, false,
                          FSYS_DETECT))
         return false;
     if (pTheAbsURIRef)
diff --git a/include/vcl/print.hxx b/include/vcl/print.hxx
index b594cc7c76c1..e432c935d4be 100644
--- a/include/vcl/print.hxx
+++ b/include/vcl/print.hxx
@@ -628,10 +628,10 @@ public:
     sal_Int64            getIntValue( const char* i_pPropName, sal_Int64 i_nDefault ) const
                              { return getIntValue( OUString::createFromAscii( i_pPropName ), i_nDefault ); }
 
-    OUString             getStringValue( const OUString& i_rPropertyName, const OUString& i_rDefault = OUString() ) const;
+    OUString             getStringValue( const OUString& i_rPropertyName ) const;
     // convenience for fixed strings
-    OUString             getStringValue( const char* i_pPropName, const OUString& i_rDefault = OUString() ) const
-                             { return getStringValue( OUString::createFromAscii( i_pPropName ), i_rDefault ); }
+    OUString             getStringValue( const char* i_pPropName ) const
+                             { return getStringValue( OUString::createFromAscii( i_pPropName ) ); }
 
     // helper functions for user to create a single control
     struct UIControlOptions