diff options
author | Armin Le Grand <Armin.Le.Grand@cib.de> | 2018-01-18 17:07:43 +0100 |
---|---|---|
committer | Armin Le Grand <Armin.Le.Grand@cib.de> | 2018-01-29 10:16:55 +0100 |
commit | 71053a36f3f48904c254a1d277f42d6dcdc29b04 (patch) | |
tree | 7b35b0087f03014dc2f6a1735fb5e29f8551db38 /include | |
parent | e3e2f6911d6231c706ce8c77e5cd6733335d6342 (diff) |
BorderlineFix: Need to redesign Borderline paint for Calc
To fix some errors, need to change svx::frame::Array conversion
to Primitives, especially regarding handling of merged cells.
These make problems in the currtent form where the full extended
merged cell tries to be converted. This is bad for cropped stuff
and also wrong for double-line stuff attaching to a merged cell.
The solution is to handle cells single and merge created primitives
which is more expensive but will work. This will involve special
handling for X-Ed (crossed) and 'roated' Cells. Also need to be
very careful since all this is used in the meantime for all
visualizations of Tables in multiple apps/situations.
Change-Id: If0652a3ba97a6f27dd5d782ea22b1514303f3710
Diffstat (limited to 'include')
-rw-r--r-- | include/svx/framelink.hxx | 8 | ||||
-rw-r--r-- | include/svx/framelinkarray.hxx | 6 |
2 files changed, 1 insertions, 13 deletions
diff --git a/include/svx/framelink.hxx b/include/svx/framelink.hxx index ce7f09345a80..2feaab5af8bf 100644 --- a/include/svx/framelink.hxx +++ b/include/svx/framelink.hxx @@ -150,11 +150,6 @@ private: /// call to set maImplStyle on demand void implEnsureImplStyle(); - /// need information which cell this style info comes from due to needed - /// rotation info (which is in the cell). Rotation depends on the cell. - friend class Cell; - void SetUsingCell(const Cell* pCell) { mpUsingCell = pCell; } - public: /** Constructs an invisible frame style. */ explicit Style(); @@ -203,9 +198,6 @@ public: /** Mirrors this style (exchanges primary and secondary), if it is a double frame style. */ Style& MirrorSelf(); - /** return the Cell using this style (if set) */ - const Cell* GetUsingCell() const { return mpUsingCell; } - bool operator==( const Style& rOther) const; bool operator<( const Style& rOther) const; }; diff --git a/include/svx/framelinkarray.hxx b/include/svx/framelinkarray.hxx index 2b06d29a41b2..e135e371319c 100644 --- a/include/svx/framelinkarray.hxx +++ b/include/svx/framelinkarray.hxx @@ -291,8 +291,7 @@ public: /** Returns the output range of the cell (nCol,nRow). Returns total output range of merged ranges. */ - basegfx::B2DRange GetCellRange( size_t nCol, size_t nRow ) const; - basegfx::B2DRange GetCellRange( size_t nCellIndex ) const; + basegfx::B2DRange GetCellRange( size_t nCol, size_t nRow, bool bExpandMerged ) const; // mirroring -------------------------------------------------------------- @@ -312,9 +311,6 @@ public: /** Draws the part of the array, that is inside the clipping range. */ drawinglayer::primitive2d::Primitive2DContainer CreateB2DPrimitiveArray() const; - // fill the Cell::maCellIndex entries to allow referencing back from Cell to Array Col/Row coordinates - void AddCellIndices() const; - private: std::unique_ptr<ArrayImpl> mxImpl; }; |