diff options
author | Noel Grandin <noel@peralex.com> | 2016-04-11 09:23:29 +0200 |
---|---|---|
committer | Noel Grandin <noel@peralex.com> | 2016-04-11 11:38:57 +0200 |
commit | 9f877f677346968774d4366f105114fe7f36dd69 (patch) | |
tree | d8fb1f3924b5956c8f693acb8df33ba9757f9dc1 /include | |
parent | b9d091e7d4eb3014aa6198f64f414702105b5aab (diff) |
clang-tidy performance-unnecessary-value-param in oox
Change-Id: I1ac86906ea21c00f8d77834c94583be7d9e9974e
Diffstat (limited to 'include')
-rw-r--r-- | include/oox/core/xmlfilterbase.hxx | 4 | ||||
-rw-r--r-- | include/oox/crypto/DocumentDecryption.hxx | 2 | ||||
-rw-r--r-- | include/oox/export/chartexport.hxx | 67 | ||||
-rw-r--r-- | include/oox/export/drawingml.hxx | 62 | ||||
-rw-r--r-- | include/oox/export/shapes.hxx | 58 | ||||
-rw-r--r-- | include/oox/export/vmlexport.hxx | 2 | ||||
-rw-r--r-- | include/oox/helper/grabbagstack.hxx | 2 | ||||
-rw-r--r-- | include/oox/helper/propertymap.hxx | 6 | ||||
-rw-r--r-- | include/oox/ppt/pptshapegroupcontext.hxx | 2 | ||||
-rw-r--r-- | include/oox/vml/vmlformatting.hxx | 2 | ||||
-rw-r--r-- | include/oox/vml/vmltextbox.hxx | 2 |
11 files changed, 104 insertions, 105 deletions
diff --git a/include/oox/core/xmlfilterbase.hxx b/include/oox/core/xmlfilterbase.hxx index b55a4217190c..841843980d81 100644 --- a/include/oox/core/xmlfilterbase.hxx +++ b/include/oox/core/xmlfilterbase.hxx @@ -217,7 +217,7 @@ public: @return *this */ - XmlFilterBase& exportDocumentProperties( css::uno::Reference< css::document::XDocumentProperties > xProperties ); + XmlFilterBase& exportDocumentProperties( const css::uno::Reference< css::document::XDocumentProperties >& xProperties ); void importDocumentProperties(); @@ -226,7 +226,7 @@ public: bool isMSO2007Document() const; void checkDocumentProperties( - css::uno::Reference<css::document::XDocumentProperties> xDocProps); + const css::uno::Reference<css::document::XDocumentProperties>& xDocProps); protected: virtual css::uno::Reference< css::io::XInputStream > diff --git a/include/oox/crypto/DocumentDecryption.hxx b/include/oox/crypto/DocumentDecryption.hxx index b494ea2900fa..d6b867b47b29 100644 --- a/include/oox/crypto/DocumentDecryption.hxx +++ b/include/oox/crypto/DocumentDecryption.hxx @@ -55,7 +55,7 @@ public: oox::ole::OleStorage& rOleStorage, css::uno::Reference< css::uno::XComponentContext > xContext); - bool decrypt(css::uno::Reference< css::io::XStream > xDocumentStream); + bool decrypt(const css::uno::Reference< css::io::XStream >& xDocumentStream); bool readEncryptionInfo(); bool generateEncryptionKey(const OUString& rPassword); diff --git a/include/oox/export/chartexport.hxx b/include/oox/export/chartexport.hxx index 93842e4aafc6..7fa4664ab6ed 100644 --- a/include/oox/export/chartexport.hxx +++ b/include/oox/export/chartexport.hxx @@ -121,39 +121,39 @@ private: void InitPlotArea(); void _ExportContent(); - void exportChartSpace( css::uno::Reference< - css::chart::XChartDocument > rChartDoc, + void exportChartSpace( const css::uno::Reference< + css::chart::XChartDocument >& rChartDoc, bool bIncludeTable ); - void exportChart( css::uno::Reference< - css::chart::XChartDocument > rChartDoc ); - void exportExternalData( css::uno::Reference< - css::chart::XChartDocument > rChartDoc ); - void exportLegend( css::uno::Reference< - css::chart::XChartDocument > rChartDoc ); - void exportTitle( css::uno::Reference< - css::drawing::XShape > xShape ); + void exportChart( const css::uno::Reference< + css::chart::XChartDocument >& rChartDoc ); + void exportExternalData( const css::uno::Reference< + css::chart::XChartDocument >& rChartDoc ); + void exportLegend( const css::uno::Reference< + css::chart::XChartDocument >& rChartDoc ); + void exportTitle( const css::uno::Reference< + css::drawing::XShape >& xShape ); void exportPlotArea( ); - void exportPlotAreaShapeProps( css::uno::Reference< css::beans::XPropertySet > xPropSet ); - void exportFill( css::uno::Reference< css::beans::XPropertySet > xPropSet ); - void exportGradientFill( css::uno::Reference< css::beans::XPropertySet > xPropSet ); - void exportBitmapFill( css::uno::Reference< css::beans::XPropertySet > xPropSet ); + void exportPlotAreaShapeProps( const css::uno::Reference< css::beans::XPropertySet >& xPropSet ); + void exportFill( const css::uno::Reference< css::beans::XPropertySet >& xPropSet ); + void exportGradientFill( const css::uno::Reference< css::beans::XPropertySet >& xPropSet ); + void exportBitmapFill( const css::uno::Reference< css::beans::XPropertySet >& xPropSet ); void exportDataTable( ); - void exportAreaChart( css::uno::Reference< css::chart2::XChartType > xChartType ); - void exportBarChart( css::uno::Reference< css::chart2::XChartType > xChartType ); - void exportBubbleChart( css::uno::Reference< css::chart2::XChartType > xChartType ); - void exportDoughnutChart( css::uno::Reference< css::chart2::XChartType > xChartType ); - void exportLineChart( css::uno::Reference< css::chart2::XChartType > xChartType ); - void exportPieChart( css::uno::Reference< css::chart2::XChartType > xChartType ); - void exportRadarChart( css::uno::Reference< css::chart2::XChartType > xChartType ); - void exportScatterChart( css::uno::Reference< css::chart2::XChartType > xChartType ); - void exportStockChart( css::uno::Reference< css::chart2::XChartType > xChartType ); - void exportSurfaceChart( css::uno::Reference< css::chart2::XChartType > xChartType ); + void exportAreaChart( const css::uno::Reference< css::chart2::XChartType >& xChartType ); + void exportBarChart( const css::uno::Reference< css::chart2::XChartType >& xChartType ); + void exportBubbleChart( const css::uno::Reference< css::chart2::XChartType >& xChartType ); + void exportDoughnutChart( const css::uno::Reference< css::chart2::XChartType >& xChartType ); + void exportLineChart( const css::uno::Reference< css::chart2::XChartType >& xChartType ); + void exportPieChart( const css::uno::Reference< css::chart2::XChartType >& xChartType ); + void exportRadarChart( const css::uno::Reference< css::chart2::XChartType >& xChartType ); + void exportScatterChart( const css::uno::Reference< css::chart2::XChartType >& xChartType ); + void exportStockChart( const css::uno::Reference< css::chart2::XChartType >& xChartType ); + void exportSurfaceChart( const css::uno::Reference< css::chart2::XChartType >& xChartType ); void exportHiLowLines(); - void exportUpDownBars(css::uno::Reference< css::chart2::XChartType > xChartType ); + void exportUpDownBars(const css::uno::Reference< css::chart2::XChartType >& xChartType ); - void exportAllSeries(css::uno::Reference<css::chart2::XChartType> xChartType, bool& rPrimaryAxes); - void exportSeries(css::uno::Reference< css::chart2::XChartType > xChartType, + void exportAllSeries(const css::uno::Reference<css::chart2::XChartType>& xChartType, bool& rPrimaryAxes); + void exportSeries(const css::uno::Reference< css::chart2::XChartType >& xChartType, css::uno::Sequence<css::uno::Reference<css::chart2::XDataSeries> >& rSeriesSeq, bool& rPrimaryAxes); void exportCandleStickSeries( const css::uno::Sequence< @@ -166,19 +166,19 @@ private: const css::uno::Reference< css::chart2::data::XDataSequence >& xValueSeq ); void exportSeriesValues( const css::uno::Reference< css::chart2::data::XDataSequence >& xValueSeq, sal_Int32 nValueType = XML_val ); - void exportShapeProps( css::uno::Reference< css::beans::XPropertySet > xPropSet ); - void exportTextProps(css::uno::Reference< css::beans::XPropertySet > xPropSet); + void exportShapeProps( const css::uno::Reference< css::beans::XPropertySet >& xPropSet ); + void exportTextProps(const css::uno::Reference< css::beans::XPropertySet >& xPropSet); void exportDataPoints( const css::uno::Reference< css::beans::XPropertySet >& xSeriesProperties, sal_Int32 nSeriesLength ); void exportDataLabels( const css::uno::Reference<css::chart2::XDataSeries>& xSeries, sal_Int32 nSeriesLength, sal_Int32 eChartType ); void exportGrouping( bool isBar = false ); - void exportTrendlines( css::uno::Reference< css::chart2::XDataSeries > xSeries ); - void exportMarker( css::uno::Reference< css::chart2::XDataSeries > xSeries ); + void exportTrendlines( const css::uno::Reference< css::chart2::XDataSeries >& xSeries ); + void exportMarker( const css::uno::Reference< css::chart2::XDataSeries >& xSeries ); void exportSmooth(); void exportFirstSliceAng(); - void exportErrorBar(css::uno::Reference< css::beans::XPropertySet > xErrorBarProps, + void exportErrorBar(const css::uno::Reference< css::beans::XPropertySet >& xErrorBarProps, bool bYError); void exportManualLayout(const css::chart2::RelativePosition& rPos, const css::chart2::RelativeSize& rSize); @@ -197,8 +197,7 @@ private: void exportView3D(); bool isDeep3dChart(); - void exportMissingValueTreatment(css::uno::Reference< - css::beans::XPropertySet> xPropSet); + void exportMissingValueTreatment(const css::uno::Reference<css::beans::XPropertySet>& xPropSet); OUString getNumberFormatCode(sal_Int32 nKey) const; diff --git a/include/oox/export/drawingml.hxx b/include/oox/export/drawingml.hxx index 9305c0108da2..fe2a8c78bbe7 100644 --- a/include/oox/export/drawingml.hxx +++ b/include/oox/export/drawingml.hxx @@ -109,11 +109,11 @@ protected: css::uno::Reference<css::drawing::XShape> m_xParent; bool mbIsBackgroundDark; - bool GetProperty( css::uno::Reference< css::beans::XPropertySet > rXPropSet, const OUString& aName ); - bool GetPropertyAndState( css::uno::Reference< css::beans::XPropertySet > rXPropSet, - css::uno::Reference< css::beans::XPropertyState > rXPropState, + bool GetProperty( const css::uno::Reference< css::beans::XPropertySet >& rXPropSet, const OUString& aName ); + bool GetPropertyAndState( const css::uno::Reference< css::beans::XPropertySet >& rXPropSet, + const css::uno::Reference< css::beans::XPropertyState >& rXPropState, const OUString& aName, css::beans::PropertyState& eState ); - OUString GetFieldValue( css::uno::Reference< css::text::XTextRange > rRun, bool& bIsURLField ); + OUString GetFieldValue( const css::uno::Reference< css::text::XTextRange >& rRun, bool& bIsURLField ); /// If bRelPathToMedia is true add "../" to image folder path while adding the image relationship @@ -143,60 +143,60 @@ public: void WriteColor( const OUString& sColorSchemeName, const css::uno::Sequence< css::beans::PropertyValue >& aTransformations ); void WriteColorTransformations( const css::uno::Sequence< css::beans::PropertyValue >& aTransformations ); void WriteGradientStop( sal_uInt16 nStop, sal_uInt32 nColor ); - void WriteLineArrow( css::uno::Reference< css::beans::XPropertySet > rXPropSet, bool bLineStart ); + void WriteLineArrow( const css::uno::Reference< css::beans::XPropertySet >& rXPropSet, bool bLineStart ); void WriteConnectorConnections( EscherConnectorListEntry& rConnectorEntry, sal_Int32 nStartID, sal_Int32 nEndID ); void WriteSolidFill( sal_uInt32 nColor, sal_Int32 nAlpha = MAX_PERCENT ); void WriteSolidFill( const OUString& sSchemeName, const css::uno::Sequence< css::beans::PropertyValue >& aTransformations ); - void WriteSolidFill( css::uno::Reference< css::beans::XPropertySet > rXPropSet ); - void WriteGradientFill( css::uno::Reference< css::beans::XPropertySet > rXPropSet ); + void WriteSolidFill( const css::uno::Reference< css::beans::XPropertySet >& rXPropSet ); + void WriteGradientFill( const css::uno::Reference< css::beans::XPropertySet >& rXPropSet ); void WriteGradientFill( css::awt::Gradient rGradient ); void WriteGrabBagGradientFill( const css::uno::Sequence< css::beans::PropertyValue >& aGradientStops, css::awt::Gradient rGradient); - void WriteBlipOrNormalFill( css::uno::Reference< css::beans::XPropertySet > rXPropSet, + void WriteBlipOrNormalFill( const css::uno::Reference< css::beans::XPropertySet >& rXPropSet, const OUString& rURLPropName ); - void WriteBlipFill( css::uno::Reference< css::beans::XPropertySet > rXPropSet, + void WriteBlipFill( const css::uno::Reference< css::beans::XPropertySet >& rXPropSet, const OUString& sBitmapURL, sal_Int32 nXmlNamespace, bool bWriteMode, bool bRelPathToMedia = false ); - void WriteBlipFill( css::uno::Reference< css::beans::XPropertySet > rXPropSet, + void WriteBlipFill( const css::uno::Reference< css::beans::XPropertySet >& rXPropSet, const OUString& sURLPropName ); - void WriteBlipFill( css::uno::Reference< css::beans::XPropertySet > rXPropSet, + void WriteBlipFill( const css::uno::Reference< css::beans::XPropertySet >& rXPropSet, const OUString& sURLPropName, sal_Int32 nXmlNamespace ); - void WritePattFill( css::uno::Reference< css::beans::XPropertySet > rXPropSet ); - void WriteSrcRect( css::uno::Reference< css::beans::XPropertySet >, const OUString& ); - void WriteOutline( css::uno::Reference< css::beans::XPropertySet > rXPropSet ); - void WriteStretch( css::uno::Reference< css::beans::XPropertySet > rXPropSet, const OUString& rURL ); + void WritePattFill( const css::uno::Reference< css::beans::XPropertySet >& rXPropSet ); + void WriteSrcRect( const css::uno::Reference< css::beans::XPropertySet >&, const OUString& ); + void WriteOutline( const css::uno::Reference< css::beans::XPropertySet >& rXPropSet ); + void WriteStretch( const css::uno::Reference< css::beans::XPropertySet >& rXPropSet, const OUString& rURL ); void WriteLinespacing( css::style::LineSpacing& rLineSpacing ); - OUString WriteBlip( css::uno::Reference< css::beans::XPropertySet > rXPropSet, + OUString WriteBlip( const css::uno::Reference< css::beans::XPropertySet >& rXPropSet, const OUString& rURL, bool bRelPathToMedia = false , const Graphic *pGraphic=nullptr ); - void WriteBlipMode( css::uno::Reference< css::beans::XPropertySet > rXPropSet, const OUString& rURL ); + void WriteBlipMode( const css::uno::Reference< css::beans::XPropertySet >& rXPropSet, const OUString& rURL ); - void WriteShapeTransformation( css::uno::Reference< css::drawing::XShape > rXShape, + void WriteShapeTransformation( const css::uno::Reference< css::drawing::XShape >& rXShape, sal_Int32 nXmlNamespace, bool bFlipH = false, bool bFlipV = false, bool bSuppressRotation = false ); void WriteTransformation( const Rectangle& rRectangle, sal_Int32 nXmlNamespace, bool bFlipH = false, bool bFlipV = false, sal_Int32 nRotation = 0 ); - void WriteText( css::uno::Reference< css::uno::XInterface > rXIface, const OUString& presetWarp, bool bBodyPr = true, bool bText = true, sal_Int32 nXmlNamespace = 0); - void WriteParagraph( css::uno::Reference< css::text::XTextContent > rParagraph ); - void WriteParagraphProperties( css::uno::Reference< css::text::XTextContent > rParagraph ); - void WriteParagraphNumbering( css::uno::Reference< css::beans::XPropertySet > rXPropSet, + void WriteText( const css::uno::Reference< css::uno::XInterface >& rXIface, const OUString& presetWarp, bool bBodyPr = true, bool bText = true, sal_Int32 nXmlNamespace = 0); + void WriteParagraph( const css::uno::Reference< css::text::XTextContent >& rParagraph ); + void WriteParagraphProperties( const css::uno::Reference< css::text::XTextContent >& rParagraph ); + void WriteParagraphNumbering( const css::uno::Reference< css::beans::XPropertySet >& rXPropSet, sal_Int16 nLevel ); - void WriteRun( css::uno::Reference< css::text::XTextRange > rRun ); - void WriteRunProperties( css::uno::Reference< css::beans::XPropertySet > rRun, bool bIsField, sal_Int32 nElement = XML_rPr ,bool bCheckDirect = true); + void WriteRun( const css::uno::Reference< css::text::XTextRange >& rRun ); + void WriteRunProperties( const css::uno::Reference< css::beans::XPropertySet >& rRun, bool bIsField, sal_Int32 nElement = XML_rPr ,bool bCheckDirect = true); void WritePresetShape( const char* pShape ); void WritePresetShape( const char* pShape, MSO_SPT eShapeType, bool bPredefinedHandlesUsed, sal_Int32 nAdjustmentsWhichNeedsToBeConverted, const css::beans::PropertyValue& rProp ); - void WriteCustomGeometry( css::uno::Reference<css::drawing::XShape> rXShape ); + void WriteCustomGeometry( const css::uno::Reference<css::drawing::XShape>& rXShape ); void WritePolyPolygon( const tools::PolyPolygon& rPolyPolygon ); - void WriteFill( css::uno::Reference< css::beans::XPropertySet > xPropSet ); - void WriteShapeStyle( css::uno::Reference< css::beans::XPropertySet > rXPropSet ); - void WriteShapeEffects( css::uno::Reference< css::beans::XPropertySet > rXPropSet ); + void WriteFill( const css::uno::Reference< css::beans::XPropertySet >& xPropSet ); + void WriteShapeStyle( const css::uno::Reference< css::beans::XPropertySet >& rXPropSet ); + void WriteShapeEffects( const css::uno::Reference< css::beans::XPropertySet >& rXPropSet ); void WriteShapeEffect( const OUString& sName, const css::uno::Sequence< css::beans::PropertyValue >& aEffectProps ); - void WriteShape3DEffects( css::uno::Reference< css::beans::XPropertySet > rXPropSet ); - void WriteArtisticEffect( css::uno::Reference< css::beans::XPropertySet > rXPropSet ); + void WriteShape3DEffects( const css::uno::Reference< css::beans::XPropertySet >& rXPropSet ); + void WriteArtisticEffect( const css::uno::Reference< css::beans::XPropertySet >& rXPropSet ); OString WriteWdpPicture( const OUString& rFileId, const css::uno::Sequence< sal_Int8 >& rPictureData ); - sal_Int32 getBulletMarginIndentation (css::uno::Reference< css::beans::XPropertySet > rXPropSet,sal_Int16 nLevel, const OUString& propName); + sal_Int32 getBulletMarginIndentation (const css::uno::Reference< css::beans::XPropertySet >& rXPropSet,sal_Int16 nLevel, const OUString& propName); static void ResetCounters(); diff --git a/include/oox/export/shapes.hxx b/include/oox/export/shapes.hxx index ab67def8d5e1..b2cb828a8dd3 100644 --- a/include/oox/export/shapes.hxx +++ b/include/oox/export/shapes.hxx @@ -80,7 +80,7 @@ private: struct ShapeHash { - size_t operator()( const css::uno::Reference < css::drawing::XShape > ) const; + size_t operator()( const css::uno::Reference < css::drawing::XShape >& ) const; }; public: @@ -89,7 +89,7 @@ public: protected: sal_Int32 mnShapeIdMax, mnPictureIdMax; - void WriteGraphicObjectShapePart( css::uno::Reference< css::drawing::XShape > xShape, const Graphic *pGraphic=nullptr ); + void WriteGraphicObjectShapePart( const css::uno::Reference< css::drawing::XShape >& xShape, const Graphic *pGraphic=nullptr ); private: sal_Int32 mnXmlNamespace; @@ -108,34 +108,34 @@ public: ShapeExport( sal_Int32 nXmlNamespace, ::sax_fastparser::FSHelperPtr pFS, ShapeHashMap* pShapeMap = nullptr, ::oox::core::XmlFilterBase* pFB = nullptr, DocumentType eDocumentType = DOCUMENT_PPTX, DMLTextExport* pTextExport = nullptr ); virtual ~ShapeExport() {} - void SetURLTranslator(std::shared_ptr<URLTransformer> pTransformer); + void SetURLTranslator(const std::shared_ptr<URLTransformer>& pTransformer); - static bool NonEmptyText( css::uno::Reference< css::uno::XInterface > xIface ); + static bool NonEmptyText( const css::uno::Reference< css::uno::XInterface >& xIface ); ShapeExport& - WriteBezierShape( css::uno::Reference< css::drawing::XShape > xShape, bool bClosed ); + WriteBezierShape( const css::uno::Reference< css::drawing::XShape >& xShape, bool bClosed ); ShapeExport& - WriteClosedBezierShape( css::uno::Reference< css::drawing::XShape > xShape ); + WriteClosedBezierShape( const css::uno::Reference< css::drawing::XShape >& xShape ); ShapeExport& - WriteConnectorShape( css::uno::Reference< css::drawing::XShape > xShape ); + WriteConnectorShape( const css::uno::Reference< css::drawing::XShape >& xShape ); ShapeExport& - WriteCustomShape( css::uno::Reference< css::drawing::XShape > xShape ); + WriteCustomShape( const css::uno::Reference< css::drawing::XShape >& xShape ); ShapeExport& - WriteEllipseShape( css::uno::Reference< css::drawing::XShape > xShape ); + WriteEllipseShape( const css::uno::Reference< css::drawing::XShape >& xShape ); ShapeExport& - WriteGraphicObjectShape( css::uno::Reference< css::drawing::XShape > xShape ); + WriteGraphicObjectShape( const css::uno::Reference< css::drawing::XShape >& xShape ); ShapeExport& - WriteGroupShape( css::uno::Reference< css::drawing::XShape > xShape ); + WriteGroupShape( const css::uno::Reference< css::drawing::XShape >& xShape ); ShapeExport& - WriteLineShape( css::uno::Reference< css::drawing::XShape > xShape ); + WriteLineShape( const css::uno::Reference< css::drawing::XShape >& xShape ); ShapeExport& - WriteNonVisualDrawingProperties( css::uno::Reference< css::drawing::XShape > xShape, const char* sName ); + WriteNonVisualDrawingProperties( const css::uno::Reference< css::drawing::XShape >& xShape, const char* sName ); virtual ShapeExport& - WriteNonVisualProperties( css::uno::Reference< css::drawing::XShape > xShape ); + WriteNonVisualProperties( const css::uno::Reference< css::drawing::XShape >& xShape ); ShapeExport& - WriteOpenBezierShape( css::uno::Reference< css::drawing::XShape > xShape ); + WriteOpenBezierShape( const css::uno::Reference< css::drawing::XShape >& xShape ); ShapeExport& - WriteRectangleShape( css::uno::Reference< css::drawing::XShape > xShape ); + WriteRectangleShape( const css::uno::Reference< css::drawing::XShape >& xShape ); /** * Write the DrawingML for a particular shape. @@ -174,28 +174,28 @@ public: * @param xShape The shape to export as DrawingML. * @return <tt>*this</tt> */ - ShapeExport& WriteShape( css::uno::Reference< css::drawing::XShape > xShape ); - ShapeExport& WriteTextBox( css::uno::Reference< css::uno::XInterface > xIface, sal_Int32 nXmlNamespace ); + ShapeExport& WriteShape( const css::uno::Reference< css::drawing::XShape >& xShape ); + ShapeExport& WriteTextBox( const css::uno::Reference< css::uno::XInterface >& xIface, sal_Int32 nXmlNamespace ); virtual ShapeExport& - WriteTextShape( css::uno::Reference< css::drawing::XShape > xShape ); + WriteTextShape( const css::uno::Reference< css::drawing::XShape >& xShape ); ShapeExport& - WriteTableShape( css::uno::Reference< css::drawing::XShape > xShape ); + WriteTableShape( const css::uno::Reference< css::drawing::XShape >& xShape ); void WriteMathShape(css::uno::Reference<css::drawing::XShape> const& xShape); ShapeExport& - WriteOLE2Shape( css::uno::Reference< css::drawing::XShape > xShape ); + WriteOLE2Shape( const css::uno::Reference< css::drawing::XShape >& xShape ); virtual ShapeExport& - WriteUnknownShape( css::uno::Reference< css::drawing::XShape > xShape ); + WriteUnknownShape( const css::uno::Reference< css::drawing::XShape >& xShape ); - void WriteTable( css::uno::Reference< css::drawing::XShape > rXShape ); + void WriteTable( const css::uno::Reference< css::drawing::XShape >& rXShape ); - void WriteTableCellProperties(css::uno::Reference< css::beans::XPropertySet > rXPropSet); + void WriteTableCellProperties(const css::uno::Reference< css::beans::XPropertySet >& rXPropSet); - void WriteTableCellBorders(css::uno::Reference< css::beans::XPropertySet > rXPropSet); + void WriteTableCellBorders(const css::uno::Reference< css::beans::XPropertySet >& rXPropSet); - sal_Int32 GetNewShapeID( const css::uno::Reference< css::drawing::XShape > rShape ); - sal_Int32 GetNewShapeID( const css::uno::Reference< css::drawing::XShape > rShape, ::oox::core::XmlFilterBase* pFB ); - sal_Int32 GetShapeID( const css::uno::Reference< css::drawing::XShape > rShape ); - static sal_Int32 GetShapeID( const css::uno::Reference< css::drawing::XShape > rShape, ShapeHashMap* pShapeMap ); + sal_Int32 GetNewShapeID( const css::uno::Reference< css::drawing::XShape >& rShape ); + sal_Int32 GetNewShapeID( const css::uno::Reference< css::drawing::XShape >& rShape, ::oox::core::XmlFilterBase* pFB ); + sal_Int32 GetShapeID( const css::uno::Reference< css::drawing::XShape >& rShape ); + static sal_Int32 GetShapeID( const css::uno::Reference< css::drawing::XShape >& rShape, ShapeHashMap* pShapeMap ); }; }} diff --git a/include/oox/export/vmlexport.hxx b/include/oox/export/vmlexport.hxx index 7b4cb27cc587..4855f518da25 100644 --- a/include/oox/export/vmlexport.hxx +++ b/include/oox/export/vmlexport.hxx @@ -87,7 +87,7 @@ public: ::sax_fastparser::FSHelperPtr GetFS() { return m_pSerializer; } - void SetFS(::sax_fastparser::FSHelperPtr pSerializer); + void SetFS(const ::sax_fastparser::FSHelperPtr& pSerializer); /// Export the sdr object as VML. /// diff --git a/include/oox/helper/grabbagstack.hxx b/include/oox/helper/grabbagstack.hxx index c7ba1b106800..aba5af28dfcc 100644 --- a/include/oox/helper/grabbagstack.hxx +++ b/include/oox/helper/grabbagstack.hxx @@ -42,7 +42,7 @@ public: css::beans::PropertyValue getRootProperty(); - void appendElement(const OUString& aName, css::uno::Any aAny); + void appendElement(const OUString& aName, const css::uno::Any& aAny); void push(const OUString& aKey); void pop(); void addInt32(const OUString& aElementName, sal_Int32 aIntValue); diff --git a/include/oox/helper/propertymap.hxx b/include/oox/helper/propertymap.hxx index aa6696b0248e..8aa7f3d14a06 100644 --- a/include/oox/helper/propertymap.hxx +++ b/include/oox/helper/propertymap.hxx @@ -104,10 +104,10 @@ public: #if OSL_DEBUG_LEVEL > 0 #ifdef DBG_UTIL - static void dump( css::uno::Reference< css::beans::XPropertySet > rXPropSet); + static void dump( const css::uno::Reference< css::beans::XPropertySet >& rXPropSet); #endif - static void dumpCode( css::uno::Reference< css::beans::XPropertySet > rXPropSet); - static void dumpData(css::uno::Reference<css::beans::XPropertySet> rXPropSet); + static void dumpCode( const css::uno::Reference< css::beans::XPropertySet >& rXPropSet); + static void dumpData( const css::uno::Reference<css::beans::XPropertySet>& rXPropSet); #endif private: const PropertyNameVector* mpPropNames; diff --git a/include/oox/ppt/pptshapegroupcontext.hxx b/include/oox/ppt/pptshapegroupcontext.hxx index a93c3ac6d9f3..20b2d7c29015 100644 --- a/include/oox/ppt/pptshapegroupcontext.hxx +++ b/include/oox/ppt/pptshapegroupcontext.hxx @@ -32,7 +32,7 @@ class PPTShapeGroupContext : public ::oox::drawingml::ShapeGroupContext ShapeLocation meShapeLocation; oox::drawingml::ShapePtr pGraphicShape; - void applyFontRefColor(oox::drawingml::ShapePtr pShape, const oox::drawingml::Color& rFontRefColor); + void applyFontRefColor(const oox::drawingml::ShapePtr& pShape, const oox::drawingml::Color& rFontRefColor); public: PPTShapeGroupContext( diff --git a/include/oox/vml/vmlformatting.hxx b/include/oox/vml/vmlformatting.hxx index 2e212a52eb6f..05988f643755 100644 --- a/include/oox/vml/vmlformatting.hxx +++ b/include/oox/vml/vmlformatting.hxx @@ -238,7 +238,7 @@ struct OOX_DLLPUBLIC TextpathModel TextpathModel(); /** Writes the properties to the passed property map. */ - void pushToPropMap(oox::drawingml::ShapePropertyMap& rPropMap, css::uno::Reference<css::drawing::XShape> xShape) const; + void pushToPropMap(oox::drawingml::ShapePropertyMap& rPropMap, const css::uno::Reference<css::drawing::XShape>& xShape) const; }; } // namespace vml diff --git a/include/oox/vml/vmltextbox.hxx b/include/oox/vml/vmltextbox.hxx index 1c7ff8e2db3c..d4f6ef2b8e09 100644 --- a/include/oox/vml/vmltextbox.hxx +++ b/include/oox/vml/vmltextbox.hxx @@ -85,7 +85,7 @@ public: const TextFontModel* getFirstFont() const; /** Returns the entire text of all text portions. */ OUString getText() const; - void convert(css::uno::Reference<css::drawing::XShape> xShape) const; + void convert(const css::uno::Reference<css::drawing::XShape>& xShape) const; ShapeTypeModel& mrTypeModel; /// Text distance from the border (inset attribute of v:textbox), valid only if set. |