loplugin: unused return values

Change-Id: I4eb1f0c9245c04058fd5e47046f043f8840a79c7
Reviewed-on: https://gerrit.libreoffice.org/21628
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

8 files changed, 10 insertions, 89 deletions

diff --git a/include/basegfx/color/bcolor.hxx b/include/basegfx/color/bcolor.hxx
index ae6fdf2b322d..a2f067ac1b2b 100644
--- a/include/basegfx/color/bcolor.hxx
+++ b/include/basegfx/color/bcolor.hxx
@@ -174,12 +174,11 @@ namespace basegfx
             return *this;
         }
 
-        BColor& invert()
+        void invert()
         {
             mfX = 1.0 - mfX;
             mfY = 1.0 - mfY;
             mfZ = 1.0 - mfZ;
-            return *this;
         }
 
         static const BColor& getEmptyBColor()
diff --git a/include/basegfx/polygon/b2dpolypolygontools.hxx b/include/basegfx/polygon/b2dpolypolygontools.hxx
index 6c4067085963..f069bc8aa17b 100644
--- a/include/basegfx/polygon/b2dpolypolygontools.hxx
+++ b/include/basegfx/polygon/b2dpolypolygontools.hxx
@@ -60,10 +60,6 @@ namespace basegfx
         // is created.
         BASEGFX_DLLPUBLIC B2DPolyPolygon adaptiveSubdivideByAngle(const B2DPolyPolygon& rCandidate, double fAngleBound = 0.0);
 
-        // Subdivide all contained curves. Use nCount divisions if given. Else, a convenient one
-        // is created.
-        BASEGFX_DLLPUBLIC B2DPolyPolygon adaptiveSubdivideByCount(const B2DPolyPolygon& rCandidate, sal_uInt32 nCount = 0L);
-
         // isInside test for B2dPoint. On border is not inside as long as not true is given
         // in bWithBorder flag. It is assumed that the orientations of the given polygon are correct.
         BASEGFX_DLLPUBLIC bool isInside(const B2DPolyPolygon& rCandidate, const B2DPoint& rPoint, bool bWithBorder = false);
diff --git a/include/basegfx/range/b2ibox.hxx b/include/basegfx/range/b2ibox.hxx
index b5c4d33bfb63..ab80e9c186e5 100644
--- a/include/basegfx/range/b2ibox.hxx
+++ b/include/basegfx/range/b2ibox.hxx
@@ -152,24 +152,6 @@ namespace basegfx
             return maRangeY.getRange();
         }
 
-        /// get lower bound of the set. returns arbitrary values for empty sets.
-        B2IPoint getMinimum() const
-        {
-            return B2IPoint(
-                maRangeX.getMinimum(),
-                maRangeY.getMinimum()
-                );
-        }
-
-        /// get upper bound of the set. returns arbitrary values for empty sets.
-        B2IPoint getMaximum() const
-        {
-            return B2IPoint(
-                maRangeX.getMaximum(),
-                maRangeY.getMaximum()
-                );
-        }
-
         /// yields true if point is contained in set
         bool isInside(const B2ITuple& rTuple) const
         {
diff --git a/include/basegfx/tools/canvastools.hxx b/include/basegfx/tools/canvastools.hxx
index 79b72f2bf674..9537b649f4d5 100644
--- a/include/basegfx/tools/canvastools.hxx
+++ b/include/basegfx/tools/canvastools.hxx
@@ -156,19 +156,6 @@ namespace basegfx
          */
         BASEGFX_DLLPUBLIC ::basegfx::B2IRange   b2ISurroundingRangeFromB2DRange( const ::basegfx::B2DRange& rRange );
 
-        /** Return smalltest integer box, which completely contains
-            given floating point range.
-
-            @param rRange
-            Input range. Values must be within the representable
-            bounds of sal_Int32
-
-            @return the closest integer box, which completely contains
-            rRange. Note that this box will contain all pixel affected
-            by a polygon fill operation over the input range.
-         */
-        BASEGFX_DLLPUBLIC ::basegfx::B2IBox     b2ISurroundingBoxFromB2DRange( const ::basegfx::B2DRange& rRange );
-
         /** Return smalltest B2DRange with integer values, which
             completely contains given floating point range.
 
diff --git a/include/basegfx/tools/rectcliptools.hxx b/include/basegfx/tools/rectcliptools.hxx
index 2d45ad1d26ce..81416a489060 100644
--- a/include/basegfx/tools/rectcliptools.hxx
+++ b/include/basegfx/tools/rectcliptools.hxx
@@ -70,24 +70,6 @@ namespace basegfx
             return clip;
         }
 
-        /** Determine number of clip planes hit by given clip mask
-
-            This method returns the number of one bits in the four
-            least significant bits of the argument, which amounts to
-            the number of clip planes hit within the
-            getCohenSutherlandClipFlags() method.
-         */
-        inline sal_uInt32 getNumberOfClipPlanes( sal_uInt32 nFlags )
-        {
-            // classic bit count algo, see e.g. Reingold, Nievergelt,
-            // Deo: Combinatorial Algorithms, Theory and Practice,
-            // Prentice-Hall 1977
-            nFlags = (nFlags & 0x05) + ((nFlags >> 1) & 0x05);
-            nFlags = (nFlags & 0x03) + (nFlags >> 2); // no need for &
-                                                      // 0x03, can't
-                                                      // overflow
-            return nFlags;
-        }
     }
 }
 
diff --git a/include/vcl/pdfwriter.hxx b/include/vcl/pdfwriter.hxx
index 9d7304dc6be5..697ae91a4c3c 100644
--- a/include/vcl/pdfwriter.hxx
+++ b/include/vcl/pdfwriter.hxx
@@ -683,11 +683,8 @@ The following structure describes the permissions used in PDF security
         resets the graphics state: MapMode, Font
         Colors and other state information MUST
         be set again or are undefined.
-
-        @returns
-        returns the page id of the new page
     */
-    sal_Int32 NewPage( sal_Int32 nPageWidth = 0, sal_Int32 nPageHeight = 0, Orientation eOrientation = Inherit );
+    void NewPage( sal_Int32 nPageWidth = 0, sal_Int32 nPageHeight = 0, Orientation eOrientation = Inherit );
     /** Play a metafile like an outputdevice would do
     */
     struct PlayMetafileContext
@@ -959,12 +956,8 @@ The following structure describes the permissions used in PDF security
 
         @param nDestId
         the dest the link shall point to
-        @returns
-        0 for success
-        -1 in case the link id does not exist
-        -2 in case the dest id does not exist
     */
-    sal_Int32           SetLinkDest( sal_Int32 nLinkId, sal_Int32 nDestId );
+    void           SetLinkDest( sal_Int32 nLinkId, sal_Int32 nDestId );
     /** Set the URL for a link
         will change a dest type link to an URL type link if necessary
         @param nLinkId
@@ -974,12 +967,8 @@ The following structure describes the permissions used in PDF security
         the URL the link shall point to.
         The URL will be parsed (and corrected) by the com.sun.star.util.URLTransformer
         service; the result will then appear literally in the PDF file produced
-
-        @returns
-        0 for success
-        -1 in case the link id does not exist
     */
-    sal_Int32           SetLinkURL( sal_Int32 nLinkId, const OUString& rURL );
+    void           SetLinkURL( sal_Int32 nLinkId, const OUString& rURL );
     /** Resolve link in logical structure
 
         If a link is created after the corresponding visual appearance was drawn
@@ -1033,12 +1022,8 @@ The following structure describes the permissions used in PDF security
     @param nNewParent
     specifies which outline item will be the item's new parent.
     Use 0 for reparenting to top level.
-
-    @returns
-    -1 if the item does not exist
-    -2 if the new parent does not exist, item will be reparented to top level.
     */
-    sal_Int32 SetOutlineItemParent( sal_Int32 nItem, sal_Int32 nNewParent );
+    void SetOutlineItemParent( sal_Int32 nItem, sal_Int32 nNewParent );
 
     /** Set an outline item's title text
 
@@ -1047,12 +1032,8 @@ The following structure describes the permissions used in PDF security
 
     @param rText
     sets the title text of the item
-
-    @returns
-    0 if the item exists and the text was changed
-    -1 if the item does not exist
     */
-    sal_Int32 SetOutlineItemText( sal_Int32 nItem, const OUString& rText );
+    void SetOutlineItemText( sal_Int32 nItem, const OUString& rText );
 
     /** Set an outline item's destination
 
@@ -1061,12 +1042,8 @@ The following structure describes the permissions used in PDF security
 
     @param nDestID
     specifies the item's new destination
-
-    @returns
-    -1 if the item does not exist
-    -2 if the new dest does not exist, dest will remain unchanged
     */
-    sal_Int32 SetOutlineItemDest( sal_Int32 nItem, sal_Int32 nDestID );
+    void SetOutlineItemDest( sal_Int32 nItem, sal_Int32 nDestID );
 
     /** Create a new note on a page
 
diff --git a/include/vcl/slider.hxx b/include/vcl/slider.hxx
index e418357de6d4..cb0d226542b9 100644
--- a/include/vcl/slider.hxx
+++ b/include/vcl/slider.hxx
@@ -75,8 +75,8 @@ private:
     SAL_DLLPRIVATE long ImplSlide( long nNewPos, bool bCallEndSlide );
     SAL_DLLPRIVATE long ImplDoAction( bool bCallEndSlide );
     SAL_DLLPRIVATE void ImplDoMouseAction( const Point& rPos, bool bCallAction = true );
-    SAL_DLLPRIVATE long ImplDoSlide( long nNewPos );
-    SAL_DLLPRIVATE long ImplDoSlideAction( ScrollType eScrollType );
+    SAL_DLLPRIVATE void ImplDoSlide( long nNewPos );
+    SAL_DLLPRIVATE void ImplDoSlideAction( ScrollType eScrollType );
     SAL_DLLPRIVATE void ImplUpdateLinkedField();
 
 public:
diff --git a/include/vcl/svapp.hxx b/include/vcl/svapp.hxx
index 5e4db812ab65..2b7fe62e0bb7 100644
--- a/include/vcl/svapp.hxx
+++ b/include/vcl/svapp.hxx
@@ -429,11 +429,9 @@ public:
 
      @param nError      The error code identifier
 
-     @returns sal_uInt16 value - if it is 0, then the error wasn't handled.
-
      @see Abort
     */
-    virtual sal_uInt16          Exception( sal_uInt16 nError );
+    virtual void          Exception( sal_uInt16 nError );
 
     /** Ends the program prematurely with an error message.