revert part of "loplugin:unusedmethods"

<sberg> noelgrandin, just happen to look at b14224fe again; looks a bit scary to remove == or != from cases where both where declared
<noelgrandin> sberg, ok, I can revert that part
<sberg> noelgrandin, I guess that would be safer (there could be cases where now a different overload could kick in)

Change-Id: I5dc41c05dc4439d5adee0e5b3e0a9e1dfb9de3af
Reviewed-on: https://gerrit.libreoffice.org/22211
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

18 files changed, 28 insertions, 0 deletions

diff --git a/include/drawinglayer/geometry/viewinformation2d.hxx b/include/drawinglayer/geometry/viewinformation2d.hxx
index 53fd5f47eb81..72e857c407a3 100644
--- a/include/drawinglayer/geometry/viewinformation2d.hxx
+++ b/include/drawinglayer/geometry/viewinformation2d.hxx
@@ -123,6 +123,7 @@ namespace drawinglayer
 
             /// compare operators
             bool operator==(const ViewInformation2D& rCandidate) const;
+            bool operator!=(const ViewInformation2D& rCandidate) const { return !operator==(rCandidate); }
 
             /// data access
             const basegfx::B2DHomMatrix& getObjectTransformation() const;
diff --git a/include/drawinglayer/primitive2d/baseprimitive2d.hxx b/include/drawinglayer/primitive2d/baseprimitive2d.hxx
index 79c2b13d6ecf..80ddeedf6507 100644
--- a/include/drawinglayer/primitive2d/baseprimitive2d.hxx
+++ b/include/drawinglayer/primitive2d/baseprimitive2d.hxx
@@ -173,6 +173,7 @@ namespace drawinglayer
                 Overridden implementations are then based on this implementation
              */
             virtual bool operator==( const BasePrimitive2D& rPrimitive ) const;
+            bool operator!=( const BasePrimitive2D& rPrimitive ) const { return !operator==(rPrimitive); }
 
             /// The default implementation will use getDecomposition results to create the range
             virtual basegfx::B2DRange getB2DRange(const geometry::ViewInformation2D& rViewInformation) const;
diff --git a/include/drawinglayer/primitive3d/baseprimitive3d.hxx b/include/drawinglayer/primitive3d/baseprimitive3d.hxx
index 0f21afd91617..26b100ea2bf4 100644
--- a/include/drawinglayer/primitive3d/baseprimitive3d.hxx
+++ b/include/drawinglayer/primitive3d/baseprimitive3d.hxx
@@ -110,6 +110,7 @@ namespace drawinglayer
                 Overridden implementation are then based on this implementation.
              */
             virtual bool operator==( const BasePrimitive3D& rPrimitive ) const;
+            bool operator!=( const BasePrimitive3D& rPrimitive ) const { return !operator==(rPrimitive); }
 
             /** This method is for places where using the C++ implementation directly is possible. The subprocessing
                 and range merging is more efficient when working directly on basegfx::B3DRange. The default implementation
diff --git a/include/drawinglayer/texture/texture.hxx b/include/drawinglayer/texture/texture.hxx
index ce9e34b23ab5..3f1d6d07adc0 100644
--- a/include/drawinglayer/texture/texture.hxx
+++ b/include/drawinglayer/texture/texture.hxx
@@ -41,6 +41,7 @@ namespace drawinglayer
 
             // compare operator
             virtual bool operator==(const GeoTexSvx& rGeoTexSvx) const;
+            bool operator!=(const GeoTexSvx& rGeoTexSvx) const { return !operator==(rGeoTexSvx); }
 
             // virtual base methods
             virtual void modifyBColor(const basegfx::B2DPoint& rUV, basegfx::BColor& rBColor, double& rfOpacity) const;
diff --git a/include/oox/helper/containerhelper.hxx b/include/oox/helper/containerhelper.hxx
index 626214674a27..1c73eb7ec98d 100644
--- a/include/oox/helper/containerhelper.hxx
+++ b/include/oox/helper/containerhelper.hxx
@@ -49,6 +49,7 @@ struct ValueRange
     explicit     ValueRange( sal_Int32 nFirst, sal_Int32 nLast ) : mnFirst( nFirst ), mnLast( nLast ) {}
 
     bool         operator==( const ValueRange& rRange ) const { return (mnFirst == rRange.mnFirst) && (mnLast == rRange.mnLast); }
+    bool         operator!=( const ValueRange& rRange ) const { return !(*this == rRange); }
     bool         contains( const ValueRange& rRange ) const { return (mnFirst <= rRange.mnFirst) && (rRange.mnLast <= mnLast); }
     bool         intersects( const ValueRange& rRange ) const { return (mnFirst <= rRange.mnLast) && (rRange.mnFirst <= mnLast); }
 };
diff --git a/include/sfx2/sidebar/Context.hxx b/include/sfx2/sidebar/Context.hxx
index 945cf09cc1f1..b9430baedfb3 100644
--- a/include/sfx2/sidebar/Context.hxx
+++ b/include/sfx2/sidebar/Context.hxx
@@ -52,6 +52,7 @@ public:
     */
     sal_Int32 EvaluateMatch (const Context& rOther) const;
 
+    bool operator== (const Context& rOther) const;
     bool operator!= (const Context& rOther) const;
 };
 
diff --git a/include/sfx2/sidebar/EnumContext.hxx b/include/sfx2/sidebar/EnumContext.hxx
index dc29753aed92..080a81836013 100644
--- a/include/sfx2/sidebar/EnumContext.hxx
+++ b/include/sfx2/sidebar/EnumContext.hxx
@@ -130,6 +130,7 @@ public:
     Application GetApplication_DI() const;
 
     bool operator == (const EnumContext& rOther);
+    bool operator != (const EnumContext& rOther);
 
     /** When two contexts are matched against each other then
         application or context name may have the wildcard value 'any'.
diff --git a/include/tools/poly.hxx b/include/tools/poly.hxx
index e4a842107b08..a956b200651a 100644
--- a/include/tools/poly.hxx
+++ b/include/tools/poly.hxx
@@ -161,6 +161,8 @@ public:
 
     tools::Polygon&     operator=( const tools::Polygon& rPoly );
     bool                operator==( const tools::Polygon& rPoly ) const;
+    bool                operator!=( const tools::Polygon& rPoly ) const
+                            { return !(Polygon::operator==( rPoly )); }
     bool                IsEqual( const tools::Polygon& rPoly ) const;
 
     // streaming a Polygon does ignore PolyFlags, so use the Write Or Read
@@ -251,6 +253,8 @@ public:
 
     tools::PolyPolygon& operator=( const tools::PolyPolygon& rPolyPoly );
     bool                operator==( const tools::PolyPolygon& rPolyPoly ) const;
+    bool                operator!=( const tools::PolyPolygon& rPolyPoly ) const
+                            { return !(PolyPolygon::operator==( rPolyPoly )); }
 
     TOOLS_DLLPUBLIC friend SvStream&    ReadPolyPolygon( SvStream& rIStream, tools::PolyPolygon& rPolyPoly );
     TOOLS_DLLPUBLIC friend SvStream&    WritePolyPolygon( SvStream& rOStream, const tools::PolyPolygon& rPolyPoly );
diff --git a/include/vcl/alpha.hxx b/include/vcl/alpha.hxx
index 1bc67b2c415a..9b7e6b44a6a3 100644
--- a/include/vcl/alpha.hxx
+++ b/include/vcl/alpha.hxx
@@ -40,6 +40,8 @@ public:
     AlphaMask&  operator=( const Bitmap& rBitmap );
     AlphaMask&  operator=( const AlphaMask& rAlphaMask ) { return static_cast<AlphaMask&>( Bitmap::operator=( rAlphaMask ) ); }
     bool        operator!() const { return Bitmap::operator!(); }
+    bool        operator==( const AlphaMask& rAlphaMask ) const { return Bitmap::operator==( rAlphaMask ); }
+    bool        operator!=( const AlphaMask& rAlphaMask ) const { return Bitmap::operator!=( rAlphaMask ); }
 
     void        SetPrefMapMode( const MapMode& rMapMode ) { Bitmap::SetPrefMapMode( rMapMode ); }
 
diff --git a/include/vcl/animate.hxx b/include/vcl/animate.hxx
index 74d57088bcc4..9b3856aec6e8 100644
--- a/include/vcl/animate.hxx
+++ b/include/vcl/animate.hxx
@@ -102,6 +102,8 @@ public:
 
     Animation&      operator=( const Animation& rAnimation );
     bool            operator==( const Animation& rAnimation ) const;
+    bool            operator!=( const Animation& rAnimation ) const
+                        { return !(*this==rAnimation); }
 
     void            Clear();
 
diff --git a/include/vcl/cursor.hxx b/include/vcl/cursor.hxx
index 927f60cf5fc1..038e18f5b2c7 100644
--- a/include/vcl/cursor.hxx
+++ b/include/vcl/cursor.hxx
@@ -91,6 +91,8 @@ public:
 
     Cursor&         operator=( const Cursor& rCursor );
     bool            operator==( const Cursor& rCursor ) const;
+    bool            operator!=( const Cursor& rCursor ) const
+                        { return !(Cursor::operator==( rCursor )); }
 
 private:
     void ImplRestore();
diff --git a/include/vcl/gdimtf.hxx b/include/vcl/gdimtf.hxx
index 88bc38df2d83..6875a5074ca4 100644
--- a/include/vcl/gdimtf.hxx
+++ b/include/vcl/gdimtf.hxx
@@ -117,6 +117,7 @@ public:
 
     GDIMetaFile&    operator=( const GDIMetaFile& rMtf );
     bool            operator==( const GDIMetaFile& rMtf ) const;
+    bool            operator!=( const GDIMetaFile& rMtf ) const { return !( *this == rMtf ); }
 
     void            Clear();
     bool            Mirror( BmpMirrorFlags nMirrorFlags );
diff --git a/include/vcl/hatch.hxx b/include/vcl/hatch.hxx
index 9a81006085ae..935ea9ac6e06 100644
--- a/include/vcl/hatch.hxx
+++ b/include/vcl/hatch.hxx
@@ -66,6 +66,7 @@ public:
 
     Hatch&          operator=( const Hatch& rHatch );
     bool            operator==( const Hatch& rHatch ) const;
+    bool            operator!=( const Hatch& rHatch ) const { return !(Hatch::operator==( rHatch ) ); }
 
     HatchStyle      GetStyle() const { return mpImplHatch->meStyle; }
 
diff --git a/include/vcl/image.hxx b/include/vcl/image.hxx
index f63634f0086a..e5c045feeccf 100644
--- a/include/vcl/image.hxx
+++ b/include/vcl/image.hxx
@@ -124,6 +124,7 @@ public:
 
     ImageList&      operator=( const ImageList& rImageList );
     bool            operator==( const ImageList& rImageList ) const;
+    bool            operator!=( const ImageList& rImageList ) const { return !(ImageList::operator==( rImageList )); }
 
 private:
 
diff --git a/include/vcl/inputctx.hxx b/include/vcl/inputctx.hxx
index c2e0f172265e..d1f3f9ff3f5b 100644
--- a/include/vcl/inputctx.hxx
+++ b/include/vcl/inputctx.hxx
@@ -68,6 +68,8 @@ public:
 
     InputContext&   operator=( const InputContext& rInputContext );
     bool            operator==( const InputContext& rInputContext ) const;
+    bool            operator!=( const InputContext& rInputContext ) const
+                        { return !(InputContext::operator==( rInputContext )); }
 };
 
 inline InputContext& InputContext::operator=( const InputContext& rInputContext )
diff --git a/include/vcl/settings.hxx b/include/vcl/settings.hxx
index c911c5d93d17..46de94d538f9 100644
--- a/include/vcl/settings.hxx
+++ b/include/vcl/settings.hxx
@@ -671,6 +671,7 @@ public:
     sal_uLong                       GetBalloonDelay() const;
 
     bool                            operator ==( const HelpSettings& rSet ) const;
+    bool                            operator !=( const HelpSettings& rSet ) const;
 };
 
 
@@ -728,6 +729,7 @@ public:
     AllSettingsFlags                        GetChangeFlags( const AllSettings& rSettings ) const;
 
     bool                                    operator ==( const AllSettings& rSet ) const;
+    bool                                    operator !=( const AllSettings& rSet ) const;
     static void                             LocaleSettingsChanged( sal_uInt32 nHint );
     SvtSysLocale&                           GetSysLocale();
 };
diff --git a/include/vcl/textrectinfo.hxx b/include/vcl/textrectinfo.hxx
index b5dcf561f132..8b98e1a37c99 100644
--- a/include/vcl/textrectinfo.hxx
+++ b/include/vcl/textrectinfo.hxx
@@ -41,6 +41,8 @@ public:
                             { return ((mnMaxWidth   == rInfo.mnMaxWidth)    &&
                                       (mnLineCount  == rInfo.mnLineCount)   &&
                                       (mbEllipsis   == rInfo.mbEllipsis)); }
+    bool                operator !=( const TextRectInfo& rInfo ) const
+                            { return !(TextRectInfo::operator==( rInfo )); }
 };
 
 inline TextRectInfo::TextRectInfo()
diff --git a/include/vcl/txtattr.hxx b/include/vcl/txtattr.hxx
index 3dcb28fd4a4a..43a6adc9a65d 100644
--- a/include/vcl/txtattr.hxx
+++ b/include/vcl/txtattr.hxx
@@ -54,6 +54,8 @@ public:
     virtual TextAttrib*     Clone() const = 0;
 
     virtual bool            operator==( const TextAttrib& rAttr ) const = 0;
+    bool                    operator!=( const TextAttrib& rAttr ) const
+                                { return !(*this == rAttr ); }
 };