clang-tidy modernize-pass-by-value in filter

Change-Id: Id55c90665eaa29ee2ece07606429411549e06b8c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135242
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

7 files changed, 15 insertions, 14 deletions

diff --git a/include/filter/msfilter/escherex.hxx b/include/filter/msfilter/escherex.hxx
index dd13b5c72cf1..ac6b4cc004a3 100644
--- a/include/filter/msfilter/escherex.hxx
+++ b/include/filter/msfilter/escherex.hxx
@@ -21,6 +21,7 @@
 #define INCLUDED_FILTER_MSFILTER_ESCHEREX_HXX
 
 #include <memory>
+#include <utility>
 #include <vector>
 
 #include <com/sun/star/awt/Point.hpp>
@@ -461,16 +462,16 @@ struct MSFILTER_DLLPUBLIC EscherConnectorListEntry
 
     sal_uInt32      GetConnectorRule( bool bFirst );
 
-                    EscherConnectorListEntry( const css::uno::Reference< css::drawing::XShape > & rC,
+                    EscherConnectorListEntry( css::uno::Reference< css::drawing::XShape > xC,
                                         const css::awt::Point& rPA,
-                                        css::uno::Reference< css::drawing::XShape > const & rSA ,
+                                        css::uno::Reference< css::drawing::XShape > xSA ,
                                         const css::awt::Point& rPB,
-                                        css::uno::Reference< css::drawing::XShape > const & rSB ) :
-                                            mXConnector ( rC ),
+                                        css::uno::Reference< css::drawing::XShape > xSB ) :
+                                            mXConnector (std::move( xC )),
                                             maPointA    ( rPA ),
-                                            mXConnectToA( rSA ),
+                                            mXConnectToA(std::move( xSA )),
                                             maPointB    ( rPB ),
-                                            mXConnectToB( rSB ) {}
+                                            mXConnectToB(std::move( xSB )) {}
 
                     static sal_uInt32 GetClosestPoint( const tools::Polygon& rPoly, const css::awt::Point& rP );
 };
@@ -1069,7 +1070,7 @@ class MSFILTER_DLLPUBLIC EscherEx : public EscherPersistTable
         bool DoSeek( sal_uInt32 nKey );
 
 public:
-    explicit            EscherEx( const std::shared_ptr<EscherExGlobal>& rxGlobal, SvStream* pOutStrm, bool bOOXML = false );
+    explicit            EscherEx( std::shared_ptr<EscherExGlobal> xGlobal, SvStream* pOutStrm, bool bOOXML = false );
     virtual             ~EscherEx() override;
 
     /** Creates and returns a new shape identifier, updates the internal shape
diff --git a/include/filter/msfilter/mscodec.hxx b/include/filter/msfilter/mscodec.hxx
index f40003efe0d6..90c39a8cc6b5 100644
--- a/include/filter/msfilter/mscodec.hxx
+++ b/include/filter/msfilter/mscodec.hxx
@@ -179,7 +179,7 @@ public:
 class MSFILTER_DLLPUBLIC MSCodec97
 {
 public:
-    MSCodec97(size_t nHashLen, const OUString& rEncKeyName);
+    MSCodec97(size_t nHashLen, OUString aEncKeyName);
     virtual ~MSCodec97();
 
     /** Initializes the algorithm with the encryption data.
diff --git a/include/filter/msfilter/msdffimp.hxx b/include/filter/msfilter/msdffimp.hxx
index f56738e0050a..3dfd170bcb2a 100644
--- a/include/filter/msfilter/msdffimp.hxx
+++ b/include/filter/msfilter/msdffimp.hxx
@@ -600,7 +600,7 @@ public:
         @param bSkipImages         skipping images for text extraction/indexing
     */
     SvxMSDffManager( SvStream& rStCtrl,
-                     const OUString& rBaseURL,
+                     OUString  aBaseURL,
                      sal_uInt32 nOffsDgg,
                      SvStream* pStData,
                      SdrModel* pSdrModel_,
@@ -611,7 +611,7 @@ public:
 
     // in PPT the parameters DGGContainerOffset and PicStream are provided by an
     // init method
-    SvxMSDffManager( SvStream& rStCtrl, const OUString& rBaseURL );
+    SvxMSDffManager( SvStream& rStCtrl, OUString aBaseURL );
     void InitSvxMSDffManager( sal_uInt32 nOffsDgg_,
                               SvStream* pStData_,
                               sal_uInt32 nSvxMSDffOLEConvFlags);
diff --git a/include/filter/msfilter/msocximex.hxx b/include/filter/msfilter/msocximex.hxx
index 89e64de23af4..18bf41569f5b 100644
--- a/include/filter/msfilter/msocximex.hxx
+++ b/include/filter/msfilter/msocximex.hxx
@@ -48,7 +48,7 @@ namespace com::sun::star {
 class MSFILTER_DLLPUBLIC SvxMSConvertOCXControls
 {
 public:
-    SvxMSConvertOCXControls( const  css::uno::Reference< css::frame::XModel >& xModel );
+    SvxMSConvertOCXControls( css::uno::Reference< css::frame::XModel > xModel );
     virtual ~SvxMSConvertOCXControls();
 
     virtual bool InsertControl(
diff --git a/include/filter/msfilter/mstoolbar.hxx b/include/filter/msfilter/mstoolbar.hxx
index 7cceb145897d..46966d6482a2 100644
--- a/include/filter/msfilter/mstoolbar.hxx
+++ b/include/filter/msfilter/mstoolbar.hxx
@@ -285,7 +285,7 @@ class MSFILTER_DLLPUBLIC TBCData final : public TBBase
     TBCData(const TBCData&) = delete;
     TBCData& operator = ( const TBCData&) = delete;
 public:
-    TBCData( const TBCHeader& Header );
+    TBCData( TBCHeader Header );
     bool Read(SvStream &rS) override;
 #ifdef DEBUG_FILTER_MSTOOLBAR
     virtual void Print( FILE* ) override;
diff --git a/include/filter/msfilter/svdfppt.hxx b/include/filter/msfilter/svdfppt.hxx
index 5ae54baedf2c..6fa9ffaf4d59 100644
--- a/include/filter/msfilter/svdfppt.hxx
+++ b/include/filter/msfilter/svdfppt.hxx
@@ -723,7 +723,7 @@ struct PPTBuGraEntry
     sal_uInt32  nInstance;
     Graphic     aBuGra;
 
-                PPTBuGraEntry( Graphic const & rGraphic, sal_uInt32 nInstance );
+                PPTBuGraEntry( Graphic aGraphic, sal_uInt32 nInstance );
 };
 
 class PPTExtParaProv
diff --git a/include/filter/msfilter/util.hxx b/include/filter/msfilter/util.hxx
index 7ad1409cc32d..3dd7c88843d0 100644
--- a/include/filter/msfilter/util.hxx
+++ b/include/filter/msfilter/util.hxx
@@ -94,7 +94,7 @@ private:
     sal_Int32 nNext;
     sal_Int32 nSavPtr;
 public:
-    WW8ReadFieldParams( const OUString& rData );
+    WW8ReadFieldParams( OUString aData );
 
     bool GoToTokenParam();
     sal_Int32 SkipToNextToken();