diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2014-01-09 23:09:12 +0100 |
|---|---|---|
| committer | Andras Timar <andras.timar@collabora.com> | 2014-04-22 09:44:55 +0200 |
| commit | 6b56cf3ec870ecdf7e9a29b10473a6168b1cc94d (patch) | |
| tree | b8fdbd178bd90cc10a631d530c93194c8a036369 /include | |
| parent | c31af75c20c33cbb195ed56723fc3f1219e20962 (diff) | |
every even numbered print job is reported as failed
because of.
bool bSuccess;
...
bSuccess &= ...endSpool(...);
in PspSalPrinter::StartJob
was...
endSpool return value is effectively success flag, not job ID
(cherry picked from commit e6323214830895d1c76ec44ee53990bf577fbda2)
Change-Id: I5b96eeff80ca29f0f8f24ee6da7a2ca76cbb05ce
Reviewed-on: https://gerrit.libreoffice.org/9093
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
Diffstat (limited to 'include')
| -rw-r--r-- | include/vcl/printerinfomanager.hxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/vcl/printerinfomanager.hxx b/include/vcl/printerinfomanager.hxx index 96e784689483..7e3ccd6092de 100644 --- a/include/vcl/printerinfomanager.hxx +++ b/include/vcl/printerinfomanager.hxx @@ -211,8 +211,8 @@ public: // close the FILE* returned by startSpool and does the actual spooling // set bBanner to "false" will attempt to suppress banner printing // set bBanner to "true" will rely on the system default - // returns a numerical job id - virtual int endSpool( const OUString& rPrinterName, const OUString& rJobTitle, FILE* pFile, const JobData& rDocumentJobData, bool bBanner ); + // returns true on success + virtual bool endSpool( const OUString& rPrinterName, const OUString& rJobTitle, FILE* pFile, const JobData& rDocumentJobData, bool bBanner ); // for spadmin: whether adding or removing a printer is possible virtual bool addOrRemovePossible() const; |