clang-tidy modernize-pass-by-value in svx

Change-Id: Iedd87d321f4d161574df87629fdd6c7714ff31c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137248
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

34 files changed, 88 insertions, 83 deletions

diff --git a/include/svx/AccessibilityCheckDialog.hxx b/include/svx/AccessibilityCheckDialog.hxx
index e3e1e201f227..53fcdaf4a031 100644
--- a/include/svx/AccessibilityCheckDialog.hxx
+++ b/include/svx/AccessibilityCheckDialog.hxx
@@ -48,7 +48,7 @@ private:
 
 public:
     AccessibilityCheckDialog(weld::Window* pParent,
-                             sfx::AccessibilityIssueCollection const& rIssueCollection);
+                             sfx::AccessibilityIssueCollection rIssueCollection);
     virtual ~AccessibilityCheckDialog() override;
 };
 
diff --git a/include/svx/AccessibleShapeInfo.hxx b/include/svx/AccessibleShapeInfo.hxx
index 5cb9bfb0db04..1860c5259169 100644
--- a/include/svx/AccessibleShapeInfo.hxx
+++ b/include/svx/AccessibleShapeInfo.hxx
@@ -68,20 +68,20 @@ public:
     /** Copy the given values into the members described above.
     */
     AccessibleShapeInfo (
-        const css::uno::Reference<
-            css::drawing::XShape>& rxShape,
-        const css::uno::Reference<
-            css::accessibility::XAccessible>& rxParent,
+        css::uno::Reference<
+            css::drawing::XShape> xShape,
+        css::uno::Reference<
+            css::accessibility::XAccessible> xParent,
         IAccessibleParent* pChildrenManager);
 
     /** Copy the given values into the members described above.
         The accessible parent implementation object is set to NULL.
     */
     AccessibleShapeInfo (
-        const css::uno::Reference<
-            css::drawing::XShape>& rxShape,
-        const css::uno::Reference<
-            css::accessibility::XAccessible>& rxParent);
+        css::uno::Reference<
+            css::drawing::XShape> xShape,
+        css::uno::Reference<
+            css::accessibility::XAccessible> xParent);
 
     ~AccessibleShapeInfo();
 
diff --git a/include/svx/ClassificationDialog.hxx b/include/svx/ClassificationDialog.hxx
index d7c838200835..24bffe2ea41f 100644
--- a/include/svx/ClassificationDialog.hxx
+++ b/include/svx/ClassificationDialog.hxx
@@ -83,7 +83,7 @@ private:
 
 public:
     ClassificationDialog(weld::Window* pParent, bool bPerParagraph,
-                         const std::function<void()>& rParagraphSignHandler = []() {});
+                         std::function<void()> aParagraphSignHandler = []() {});
     ~ClassificationDialog() override;
 
     std::vector<ClassificationResult> getResult();
diff --git a/include/svx/ClassificationField.hxx b/include/svx/ClassificationField.hxx
index 8588a3e024b8..e2b5a71ab775 100644
--- a/include/svx/ClassificationField.hxx
+++ b/include/svx/ClassificationField.hxx
@@ -14,6 +14,7 @@
 #include <sal/config.h>
 #include <svx/svxdllapi.h>
 #include <editeng/flditem.hxx>
+#include <utility>
 
 namespace svx {
 
@@ -34,12 +35,12 @@ public:
     OUString msAbbreviatedName; //< Abbreviated name, displayed instead of Name.
     OUString msIdentifier;      //< The identifier of this entry (from example.xml).
 
-    ClassificationResult(ClassificationType eType, const OUString& sName,
-                         const OUString& sAbbreviatedName, const OUString& sIdentifier = "")
+    ClassificationResult(ClassificationType eType, OUString sName,
+                         OUString sAbbreviatedName, OUString sIdentifier = "")
         : meType(eType)
-        , msName(sName)
-        , msAbbreviatedName(sAbbreviatedName)
-        , msIdentifier(sIdentifier)
+        , msName(std::move(sName))
+        , msAbbreviatedName(std::move(sAbbreviatedName))
+        , msIdentifier(std::move(sIdentifier))
     {
     }
 
@@ -66,11 +67,11 @@ public:
     OUString msFullClassName;
     OUString msIdentifier;
 
-    ClassificationField(ClassificationType eType, OUString const & sDescription, OUString const & sFullClassName, OUString const & sIdentifier)
+    ClassificationField(ClassificationType eType, OUString sDescription, OUString sFullClassName, OUString sIdentifier)
         : meType(eType)
-        , msDescription(sDescription)
-        , msFullClassName(sFullClassName)
-        , msIdentifier(sIdentifier)
+        , msDescription(std::move(sDescription))
+        , msFullClassName(std::move(sFullClassName))
+        , msIdentifier(std::move(sIdentifier))
     {}
 
     std::unique_ptr<SvxFieldData> Clone() const override
diff --git a/include/svx/ColorSets.hxx b/include/svx/ColorSets.hxx
index eace8ca2663c..91ac4e1651c7 100644
--- a/include/svx/ColorSets.hxx
+++ b/include/svx/ColorSets.hxx
@@ -29,7 +29,7 @@ class ColorSet
     OUString maColorSetName;
     std::vector<Color> maColors;
 public:
-    ColorSet(OUString const & aName);
+    ColorSet(OUString aName);
 
     void add(sal_uInt32 nIndex, ::Color aColorData)
     {
@@ -93,7 +93,7 @@ class SVXCORE_DLLPUBLIC Theme
     std::unique_ptr<ColorSet> mpColorSet;
 
 public:
-    Theme(OUString const& rName);
+    Theme(OUString sName);
     ~Theme();
 
     void SetColorSet(std::unique_ptr<ColorSet> pColorSet);
diff --git a/include/svx/ShapeTypeHandler.hxx b/include/svx/ShapeTypeHandler.hxx
index 26d4aafd35f6..065e96bee5f0 100644
--- a/include/svx/ShapeTypeHandler.hxx
+++ b/include/svx/ShapeTypeHandler.hxx
@@ -26,6 +26,7 @@
 #include <rtl/ustring.hxx>
 #include <tools/long.hxx>
 #include <unordered_map>
+#include <utility>
 #include <vector>
 
 namespace accessibility { class AccessibleShape; }
@@ -59,9 +60,9 @@ struct ShapeTypeDescriptor
     OUString       msServiceName;
     tCreateFunction     maCreateFunction;
     ShapeTypeDescriptor (
-        ShapeTypeId nId, const OUString& sName, tCreateFunction aFunction)
+        ShapeTypeId nId, OUString sName, tCreateFunction aFunction)
     :   mnShapeTypeId (nId),
-        msServiceName (sName),
+        msServiceName (std::move(sName)),
            maCreateFunction (aFunction)
     {}
     ShapeTypeDescriptor()
diff --git a/include/svx/SmartTagItem.hxx b/include/svx/SmartTagItem.hxx
index caf0c4551567..d5bef53ebc7d 100644
--- a/include/svx/SmartTagItem.hxx
+++ b/include/svx/SmartTagItem.hxx
@@ -54,11 +54,11 @@ public:
                      const css::uno::Sequence < css::uno::Sequence< css::uno::Reference< css::smarttags::XSmartTagAction > > >& rActionComponentsSequence,
                      const css::uno::Sequence < css::uno::Sequence< sal_Int32 > >& rActionIndicesSequence,
                      const css::uno::Sequence< css::uno::Reference< css::container::XStringKeyMap > >& rStringKeyMaps,
-                     const css::uno::Reference<css::text::XTextRange>& rRange,
-                     const css::uno::Reference<css::frame::XController>& rController,
-                     const css::lang::Locale& rLocale,
-                     const OUString& rApplicationName,
-                     const OUString& rRangeText );
+                     css::uno::Reference<css::text::XTextRange> xRange,
+                     css::uno::Reference<css::frame::XController> xController,
+                     css::lang::Locale aLocale,
+                     OUString aApplicationName,
+                     OUString aRangeText );
 
     // "purely virtual methods" from the SfxPoolItem
     virtual bool             operator==( const SfxPoolItem& ) const override;
diff --git a/include/svx/SmartTagMgr.hxx b/include/svx/SmartTagMgr.hxx
index 510f5d53ae9e..dc8f8f474831 100644
--- a/include/svx/SmartTagMgr.hxx
+++ b/include/svx/SmartTagMgr.hxx
@@ -27,6 +27,7 @@
 #include <com/sun/star/util/XChangesListener.hpp>
 #include <svx/svxdllapi.h>
 
+#include <utility>
 #include <vector>
 #include <map>
 #include <set>
@@ -73,8 +74,8 @@ struct ActionReference
 {
     css::uno::Reference< css::smarttags::XSmartTagAction > mxSmartTagAction;
     sal_Int32 mnSmartTagIndex;
-    ActionReference( css::uno::Reference< css::smarttags::XSmartTagAction > const & xSmartTagAction, sal_Int32 nSmartTagIndex )
-        : mxSmartTagAction( xSmartTagAction), mnSmartTagIndex( nSmartTagIndex ) {}
+    ActionReference( css::uno::Reference< css::smarttags::XSmartTagAction > xSmartTagAction, sal_Int32 nSmartTagIndex )
+        : mxSmartTagAction(std::move( xSmartTagAction)), mnSmartTagIndex( nSmartTagIndex ) {}
 };
 
 /** The smart tag manager maintains all installed action and recognizer services
@@ -120,7 +121,7 @@ private:
 
 public:
 
-    SmartTagMgr( const OUString& rApplicationName );
+    SmartTagMgr( OUString aApplicationName );
     virtual ~SmartTagMgr() override;
 
     /** Triggers configuration reading, library loading and listener registration
diff --git a/include/svx/XPropertyEntry.hxx b/include/svx/XPropertyEntry.hxx
index c697ee915d0c..bfb0aa25c702 100644
--- a/include/svx/XPropertyEntry.hxx
+++ b/include/svx/XPropertyEntry.hxx
@@ -30,7 +30,7 @@ private:
     BitmapEx maUiBitmap;
 
 protected:
-    XPropertyEntry(const OUString& rPropEntryName);
+    XPropertyEntry(OUString aPropEntryName);
 
     XPropertyEntry(XPropertyEntry const&) = default;
     XPropertyEntry(XPropertyEntry&&) = default;
diff --git a/include/svx/colorbox.hxx b/include/svx/colorbox.hxx
index 3775fc187fd2..ff635c908565 100644
--- a/include/svx/colorbox.hxx
+++ b/include/svx/colorbox.hxx
@@ -53,7 +53,7 @@ private:
 public:
     // rTopLevelParentFunction will be used to get parent for any color picker dialog created
     ColorListBox(std::unique_ptr<weld::MenuButton> pControl,
-                 TopLevelParentFunction const& rTopLevelParentFunction);
+                 TopLevelParentFunction aTopLevelParentFunction);
     ~ColorListBox();
 
     void SetSelectHdl(const Link<ColorListBox&, void>& rLink) { m_aSelectedLink = rLink; }
diff --git a/include/svx/colorwindow.hxx b/include/svx/colorwindow.hxx
index 823c819f0e2c..4a0e951322ab 100644
--- a/include/svx/colorwindow.hxx
+++ b/include/svx/colorwindow.hxx
@@ -63,7 +63,7 @@ private:
     ToolBoxItemId m_nId;
 public:
     MenuOrToolMenuButton(weld::MenuButton* pMenuButton);
-    MenuOrToolMenuButton(weld::Toolbar* pToolbar, const OString& rIdent);
+    MenuOrToolMenuButton(weld::Toolbar* pToolbar, OString sIdent);
     MenuOrToolMenuButton(SvxColorToolBoxControl* pControl, ToolBox* pToolbar, ToolBoxItemId nId);
     ~MenuOrToolMenuButton();
 
@@ -110,14 +110,14 @@ private:
     NamedColor GetAutoColor() const;
 
 public:
-    ColorWindow(const OUString& rCommand,
-                std::shared_ptr<PaletteManager> const & rPaletteManager,
+    ColorWindow(OUString  rCommand,
+                std::shared_ptr<PaletteManager> xPaletteManager,
                 ColorStatus& rColorStatus,
                 sal_uInt16 nSlotId,
                 const css::uno::Reference<css::frame::XFrame>& rFrame,
                 const MenuOrToolMenuButton &rMenuButton,
-                TopLevelParentFunction const& rTopLevelParentFunction,
-                ColorSelectFunction const& rColorSelectFunction);
+                TopLevelParentFunction aTopLevelParentFunction,
+                ColorSelectFunction aColorSelectFunction);
     virtual ~ColorWindow() override;
     void                ShowNoneButton();
     void                SetNoSelection();
diff --git a/include/svx/compressgraphicdialog.hxx b/include/svx/compressgraphicdialog.hxx
index 87556ecbce1d..073b330cda2d 100644
--- a/include/svx/compressgraphicdialog.hxx
+++ b/include/svx/compressgraphicdialog.hxx
@@ -92,7 +92,7 @@ private:
 
 public:
     CompressGraphicsDialog( weld::Window* pParent, SdrGrafObj* pGraphicObj, SfxBindings& rBindings );
-    CompressGraphicsDialog( weld::Window* pParent, Graphic const & rGraphic, Size rViewSize100mm, tools::Rectangle const & rCropRectangle, SfxBindings& rBindings );
+    CompressGraphicsDialog( weld::Window* pParent, Graphic aGraphic, Size aViewSize100mm, tools::Rectangle const & rCropRectangle, SfxBindings& rBindings );
     virtual ~CompressGraphicsDialog() override;
 
     SdrGrafObj* GetCompressedSdrGrafObj();
diff --git a/include/svx/diagram/datamodel.hxx b/include/svx/diagram/datamodel.hxx
index 850cd8f78271..42b04fb216f2 100644
--- a/include/svx/diagram/datamodel.hxx
+++ b/include/svx/diagram/datamodel.hxx
@@ -162,7 +162,7 @@ class SVXCORE_DLLPUBLIC DiagramDataState
     Points maPoints;
 
 public:
-    DiagramDataState(const Connections& rConnections, const Points& rPoints);
+    DiagramDataState(Connections aConnections, Points aPoints);
 
     Connections& getConnections() { return maConnections; }
     Points& getPoints() { return maPoints; }
diff --git a/include/svx/drawitem.hxx b/include/svx/drawitem.hxx
index d40848c53c36..4cfffd47c7c1 100644
--- a/include/svx/drawitem.hxx
+++ b/include/svx/drawitem.hxx
@@ -31,7 +31,7 @@ public:
                             static SfxPoolItem* CreateDefault();
 
                             SvxColorListItem();
-                            SvxColorListItem( XColorListRef const & pTable,
+                            SvxColorListItem( XColorListRef pTable,
                                     TypedWhichId<SvxColorListItem> nWhich  );
                             SvxColorListItem( const SvxColorListItem& );
 
@@ -56,7 +56,7 @@ public:
                             static SfxPoolItem* CreateDefault();
 
                             SvxGradientListItem();
-                            SvxGradientListItem( XGradientListRef const & pList,
+                            SvxGradientListItem( XGradientListRef pList,
                                     TypedWhichId<SvxGradientListItem> nWhich  );
                             SvxGradientListItem( const SvxGradientListItem& );
 
@@ -80,7 +80,7 @@ class SAL_WARN_UNUSED SVXCORE_DLLPUBLIC SvxHatchListItem final : public SfxPoolI
 public:
                             static SfxPoolItem* CreateDefault();
                             SvxHatchListItem();
-                            SvxHatchListItem( XHatchListRef const & pList,
+                            SvxHatchListItem( XHatchListRef pList,
                                     TypedWhichId<SvxHatchListItem> nWhich  );
                             SvxHatchListItem( const SvxHatchListItem& );
 
@@ -105,7 +105,7 @@ public:
                             static SfxPoolItem* CreateDefault();
 
                             SvxBitmapListItem();
-                            SvxBitmapListItem( XBitmapListRef const & pBL,
+                            SvxBitmapListItem( XBitmapListRef pBL,
                                     TypedWhichId<SvxBitmapListItem> nWhich  );
                             SvxBitmapListItem( const SvxBitmapListItem& );
 
@@ -130,7 +130,7 @@ public:
                             static SfxPoolItem* CreateDefault();
 
                             SvxPatternListItem();
-                            SvxPatternListItem( XPatternListRef const & pBL,
+                            SvxPatternListItem( XPatternListRef pBL,
                                    TypedWhichId<SvxPatternListItem> nWhich   );
                             SvxPatternListItem( const SvxPatternListItem& );
 
@@ -154,7 +154,7 @@ public:
                             static SfxPoolItem* CreateDefault();
 
                             SvxDashListItem();
-                            SvxDashListItem( XDashListRef const & pList,
+                            SvxDashListItem( XDashListRef pList,
                                     TypedWhichId<SvxDashListItem> nWhich  );
                             SvxDashListItem( const SvxDashListItem& );
 
@@ -179,7 +179,7 @@ public:
                             static SfxPoolItem* CreateDefault();
 
                             SvxLineEndListItem();
-                            SvxLineEndListItem( XLineEndListRef const & pList,
+                            SvxLineEndListItem( XLineEndListRef pList,
                                     TypedWhichId<SvxLineEndListItem> nWhich  );
                             SvxLineEndListItem( const SvxLineEndListItem& );
 
diff --git a/include/svx/e3dundo.hxx b/include/svx/e3dundo.hxx
index 9c0515b86243..f1b14ac5f18b 100644
--- a/include/svx/e3dundo.hxx
+++ b/include/svx/e3dundo.hxx
@@ -23,6 +23,7 @@
 #include <svl/itemset.hxx>
 #include <svx/svdundo.hxx>
 #include <svx/obj3d.hxx>
+#include <utility>
 #include <svx/svxdllapi.h>
 
 /************************************************************************\
@@ -61,11 +62,11 @@ private:
 public:
     E3dRotateUndoAction(
         E3dObject& r3DObj,
-        const basegfx::B3DHomMatrix &aOldRotation,
-        const basegfx::B3DHomMatrix &aNewRotation)
+        basegfx::B3DHomMatrix aOldRotation,
+        basegfx::B3DHomMatrix aNewRotation)
     :   E3dUndoAction(r3DObj),
-        maMyOldRotation(aOldRotation),
-        maMyNewRotation(aNewRotation)
+        maMyOldRotation(std::move(aOldRotation)),
+        maMyNewRotation(std::move(aNewRotation))
     {
     }
 
@@ -92,8 +93,8 @@ private:
  public:
         E3dAttributesUndoAction(
             E3dObject& rInObject,
-            const SfxItemSet& rNewSet,
-            const SfxItemSet& rOldSet);
+            SfxItemSet aNewSet,
+            SfxItemSet aOldSet);
 
         virtual ~E3dAttributesUndoAction() override;
 
diff --git a/include/svx/galmisc.hxx b/include/svx/galmisc.hxx
index 6c45f7de65b3..60dfb3cc993e 100644
--- a/include/svx/galmisc.hxx
+++ b/include/svx/galmisc.hxx
@@ -20,6 +20,7 @@
 #ifndef INCLUDED_SVX_GALMISC_HXX
 #define INCLUDED_SVX_GALMISC_HXX
 
+#include <utility>
 #include <vcl/imap.hxx>
 #include <svl/hint.hxx>
 #include <vcl/transfer.hxx>
@@ -182,11 +183,11 @@ private:
 
 public:
 
-                     GalleryHint( GalleryHintType nType, const OUString& rThemeName, void* nData1 = nullptr ) :
-                        mnType( nType ), maThemeName( rThemeName ), mnData1( nData1 ) {}
+                     GalleryHint( GalleryHintType nType, OUString aThemeName, void* nData1 = nullptr ) :
+                        mnType( nType ), maThemeName(std::move( aThemeName )), mnData1( nData1 ) {}
 
-                     GalleryHint( GalleryHintType nType, const OUString& rThemeName, const OUString& rStringData ) :
-                        mnType( nType ), maThemeName( rThemeName ), maStringData( rStringData ), mnData1( nullptr ) {}
+                     GalleryHint( GalleryHintType nType, OUString aThemeName, OUString aStringData ) :
+                        mnType( nType ), maThemeName(std::move( aThemeName )), maStringData(std::move( aStringData )), mnData1( nullptr ) {}
 
     GalleryHintType  GetType() const { return mnType; }
     const OUString&  GetThemeName() const { return maThemeName; }
diff --git a/include/svx/hlnkitem.hxx b/include/svx/hlnkitem.hxx
index a129cc720ed1..9222cfff1baf 100644
--- a/include/svx/hlnkitem.hxx
+++ b/include/svx/hlnkitem.hxx
@@ -63,8 +63,8 @@ public:
     SvxHyperlinkItem( TypedWhichId<SvxHyperlinkItem> _nWhich = SID_HYPERLINK_GETLINK ):
                 SfxPoolItem(_nWhich) { eType = HLINK_DEFAULT; nMacroEvents=HyperDialogEvent::NONE; };
     SvxHyperlinkItem( const SvxHyperlinkItem& rHyperlinkItem );
-    SvxHyperlinkItem( TypedWhichId<SvxHyperlinkItem> nWhich, const OUString& rName, const OUString& rURL,
-                                    const OUString& rTarget, const OUString& rIntName,
+    SvxHyperlinkItem( TypedWhichId<SvxHyperlinkItem> nWhich, OUString aName, OUString aURL,
+                                    OUString aTarget, OUString aIntName,
                                     SvxLinkInsertMode eTyp,
                                     HyperDialogEvent nEvents,
                                     SvxMacroTableDtor const *pMacroTbl );
diff --git a/include/svx/lathe3d.hxx b/include/svx/lathe3d.hxx
index 4bd2fea31da6..7b1396a68ac4 100644
--- a/include/svx/lathe3d.hxx
+++ b/include/svx/lathe3d.hxx
@@ -55,7 +55,7 @@ public:
     E3dLatheObj(
         SdrModel& rSdrModel,
         const E3dDefaultAttributes& rDefault,
-        const basegfx::B2DPolyPolygon& rPoly2D);
+        basegfx::B2DPolyPolygon aPoly2D);
     E3dLatheObj(SdrModel& rSdrModel, E3dLatheObj const & rSource);
     E3dLatheObj(SdrModel& rSdrModel);
 
diff --git a/include/svx/numinf.hxx b/include/svx/numinf.hxx
index 4d4b07478a41..cd36a681a0b8 100644
--- a/include/svx/numinf.hxx
+++ b/include/svx/numinf.hxx
@@ -33,13 +33,13 @@ public:
     SvxNumberInfoItem( const TypedWhichId<SvxNumberInfoItem> nId  );
     SvxNumberInfoItem( SvNumberFormatter* pNumFormatter,
                        const TypedWhichId<SvxNumberInfoItem> nId  );
-    SvxNumberInfoItem( SvNumberFormatter* pNumFormatter, const OUString& rVal,
+    SvxNumberInfoItem( SvNumberFormatter* pNumFormatter, OUString aVal,
                        const TypedWhichId<SvxNumberInfoItem> nId  );
     SvxNumberInfoItem( SvNumberFormatter* pNumFormatter, const double& rVal,
                        const TypedWhichId<SvxNumberInfoItem> nId  );
     // if both double and String are supplied, String is used for text formats
     SvxNumberInfoItem( SvNumberFormatter* pNumFormatter, const double& rVal,
-                       const OUString& rValueStr, const TypedWhichId<SvxNumberInfoItem> nId );
+                       OUString aValueStr, const TypedWhichId<SvxNumberInfoItem> nId );
     SvxNumberInfoItem( const SvxNumberInfoItem& );
     virtual ~SvxNumberInfoItem() override;
 
diff --git a/include/svx/ofaitem.hxx b/include/svx/ofaitem.hxx
index 5e9e52b92e38..5ccc030b3b2b 100644
--- a/include/svx/ofaitem.hxx
+++ b/include/svx/ofaitem.hxx
@@ -43,7 +43,7 @@ class SVX_DLLPUBLIC OfaXColorListItem final : public SfxPoolItem
  private:
     rtl::Reference<XColorList> mxRef;
 public:
-    OfaXColorListItem( sal_uInt16 _nWhich, const rtl::Reference<XColorList> &xRef );
+    OfaXColorListItem( sal_uInt16 _nWhich, rtl::Reference<XColorList> xRef );
 
     virtual bool operator==( const SfxPoolItem& rItem ) const override;
 
diff --git a/include/svx/polypolygoneditor.hxx b/include/svx/polypolygoneditor.hxx
index 57110b414ee7..f997f669bcfd 100644
--- a/include/svx/polypolygoneditor.hxx
+++ b/include/svx/polypolygoneditor.hxx
@@ -34,7 +34,7 @@ namespace sdr
 class SVXCORE_DLLPUBLIC PolyPolygonEditor
 {
 public:
-    PolyPolygonEditor( const basegfx::B2DPolyPolygon& rPolyPolygon);
+    PolyPolygonEditor( basegfx::B2DPolyPolygon aPolyPolygon);
 
     const basegfx::B2DPolyPolygon& GetPolyPolygon() const { return maPolyPolygon; }
 
diff --git a/include/svx/sdr/overlay/overlaypolypolygon.hxx b/include/svx/sdr/overlay/overlaypolypolygon.hxx
index d3aa2074d48f..0cc31b38c742 100644
--- a/include/svx/sdr/overlay/overlaypolypolygon.hxx
+++ b/include/svx/sdr/overlay/overlaypolypolygon.hxx
@@ -36,7 +36,7 @@ namespace sdr::overlay
             virtual drawinglayer::primitive2d::Primitive2DContainer createOverlayObjectPrimitive2DSequence() override;
 
         public:
-            explicit OverlayPolyPolygon(const basegfx::B2DPolyPolygon& rLinePolyPolygon,
+            explicit OverlayPolyPolygon(basegfx::B2DPolyPolygon aLinePolyPolygon,
                                         Color const & rLineColor,
                                         double mfLineWidth,
                                         Color const & rFillColor);
@@ -53,7 +53,7 @@ namespace sdr::overlay
 
         public:
             explicit OverlayPolyPolygonStripedAndFilled(
-                const basegfx::B2DPolyPolygon& rLinePolyPolygon);
+                basegfx::B2DPolyPolygon aLinePolyPolygon);
             virtual ~OverlayPolyPolygonStripedAndFilled() override;
 
             // change geometry
diff --git a/include/svx/sidebar/SelectionChangeHandler.hxx b/include/svx/sidebar/SelectionChangeHandler.hxx
index a4d5dbc32f96..0a714debb833 100644
--- a/include/svx/sidebar/SelectionChangeHandler.hxx
+++ b/include/svx/sidebar/SelectionChangeHandler.hxx
@@ -42,7 +42,7 @@ class SVX_DLLPUBLIC SelectionChangeHandler final
 {
 public:
     SelectionChangeHandler (
-        const std::function<OUString ()>& rSelectionChangeCallback,
+        std::function<OUString ()> aSelectionChangeCallback,
         const css::uno::Reference<css::frame::XController>& rxController,
         const vcl::EnumContext::Context eDefaultContext);
     virtual ~SelectionChangeHandler() override;
diff --git a/include/svx/svddrgmt.hxx b/include/svx/svddrgmt.hxx
index fe71ad5d60cd..d871663ae0a0 100644
--- a/include/svx/svddrgmt.hxx
+++ b/include/svx/svddrgmt.hxx
@@ -54,7 +54,7 @@ private:
     basegfx::B2DPolyPolygon             maOriginalPolyPolygon;
 
 public:
-    SdrDragEntryPolyPolygon(const basegfx::B2DPolyPolygon& rOriginalPolyPolygon);
+    SdrDragEntryPolyPolygon(basegfx::B2DPolyPolygon aOriginalPolyPolygon);
     virtual ~SdrDragEntryPolyPolygon() override;
 
     virtual drawinglayer::primitive2d::Primitive2DContainer createPrimitive2DSequenceInCurrentState(SdrDragMethod& rDragMethod) override;
diff --git a/include/svx/svdhdl.hxx b/include/svx/svdhdl.hxx
index 461937c05969..606dd8d5afa7 100644
--- a/include/svx/svdhdl.hxx
+++ b/include/svx/svdhdl.hxx
@@ -517,8 +517,8 @@ private:
 
 public:
     SdrCropViewHdl(
-        const basegfx::B2DHomMatrix& rObjectTransform,
-        const Graphic& rGraphic,
+        basegfx::B2DHomMatrix aObjectTransform,
+        Graphic aGraphic,
         double fCropLeft,
         double fCropTop,
         double fCropRight,
diff --git a/include/svx/svdlayer.hxx b/include/svx/svdlayer.hxx
index 40cac55d9e1b..de453a6bf8c2 100644
--- a/include/svx/svdlayer.hxx
+++ b/include/svx/svdlayer.hxx
@@ -68,7 +68,7 @@ class SVXCORE_DLLPUBLIC SdrLayer
     bool mbLockedODF; // corresponds to ODF draw:protected
     SdrLayerID nID;
 
-    SdrLayer(SdrLayerID nNewID, const OUString& rNewName);
+    SdrLayer(SdrLayerID nNewID, OUString aNewName);
 
 public:
     bool operator==(const SdrLayer& rCmpLayer) const;
diff --git a/include/svx/svdopath.hxx b/include/svx/svdopath.hxx
index dd854468bb3f..5eb25ec7b0d1 100644
--- a/include/svx/svdopath.hxx
+++ b/include/svx/svdopath.hxx
@@ -72,7 +72,7 @@ public:
     SdrPathObj(
         SdrModel& rSdrModel,
         SdrObjKind eNewKind,
-        const basegfx::B2DPolyPolygon& rPathPoly);
+        basegfx::B2DPolyPolygon aPathPoly);
 
     virtual void TakeObjInfo(SdrObjTransformInfoRec& rInfo) const override;
     virtual SdrObjKind GetObjIdentifier() const override;
diff --git a/include/svx/svdundo.hxx b/include/svx/svdundo.hxx
index 01b4f6749770..c3b8bef914e8 100644
--- a/include/svx/svdundo.hxx
+++ b/include/svx/svdundo.hxx
@@ -476,8 +476,8 @@ public:
 
     SdrUndoObjStrAttr( SdrObject& rNewObj,
                        const ObjStrAttrType eObjStrAttr,
-                       const OUString& sOldStr,
-                       const OUString& sNewStr);
+                       OUString sOldStr,
+                       OUString sNewStr);
 
     virtual void Undo() override;
     virtual void Redo() override;
diff --git a/include/svx/svxgraphicitem.hxx b/include/svx/svxgraphicitem.hxx
index 78592f382445..6d78b0980baa 100644
--- a/include/svx/svxgraphicitem.hxx
+++ b/include/svx/svxgraphicitem.hxx
@@ -29,7 +29,7 @@ class SVX_DLLPUBLIC SvxGraphicItem final : public SfxPoolItem
     Graphic         aGraphic;
 
 public:
-                            SvxGraphicItem( const Graphic& rGraphic);
+                            SvxGraphicItem( Graphic aGraphic);
 
     virtual bool            operator==( const SfxPoolItem& ) const override;
     virtual SvxGraphicItem* Clone( SfxItemPool *pPool = nullptr ) const override;
diff --git a/include/svx/ucsubset.hxx b/include/svx/ucsubset.hxx
index 21251c4b5451..78f96d68563b 100644
--- a/include/svx/ucsubset.hxx
+++ b/include/svx/ucsubset.hxx
@@ -35,7 +35,7 @@ class FontCharMap;
 class Subset
 {
 public:
-    Subset(sal_UCS4 nMin, sal_UCS4 nMax, const OUString& rName);
+    Subset(sal_UCS4 nMin, sal_UCS4 nMax, OUString aName);
 
     sal_UCS4        GetRangeMin() const { return mnRangeMin;}
     sal_UCS4        GetRangeMax() const { return mnRangeMax;}
diff --git a/include/svx/unoshape.hxx b/include/svx/unoshape.hxx
index 61f33f46f9a1..5b2b0940ad8f 100644
--- a/include/svx/unoshape.hxx
+++ b/include/svx/unoshape.hxx
@@ -851,7 +851,7 @@ public:
 class SvxMediaShape final : public SvxShape
 {
 public:
-    SvxMediaShape(SdrObject* pObj, OUString const & referer);
+    SvxMediaShape(SdrObject* pObj, OUString referer);
     virtual     ~SvxMediaShape() noexcept override;
 
 private:
diff --git a/include/svx/xlnedit.hxx b/include/svx/xlnedit.hxx
index 9a43e14f3506..81fd12e3726f 100644
--- a/include/svx/xlnedit.hxx
+++ b/include/svx/xlnedit.hxx
@@ -35,8 +35,8 @@ class SVXCORE_DLLPUBLIC XLineEndItem final : public NameOrIndex
 public:
             static SfxPoolItem* CreateDefault();
             XLineEndItem(sal_Int32 nIndex = -1);
-            XLineEndItem(const OUString& rName, const basegfx::B2DPolyPolygon& rPolyPolygon);
-            XLineEndItem(const basegfx::B2DPolyPolygon& rPolyPolygon);
+            XLineEndItem(const OUString& rName, basegfx::B2DPolyPolygon aPolyPolygon);
+            XLineEndItem(basegfx::B2DPolyPolygon aPolyPolygon);
             XLineEndItem(const XLineEndItem& rItem);
 
     virtual bool            operator==(const SfxPoolItem& rItem) const override;
diff --git a/include/svx/xlnstit.hxx b/include/svx/xlnstit.hxx
index 859fdcbe75f9..c2729492200a 100644
--- a/include/svx/xlnstit.hxx
+++ b/include/svx/xlnstit.hxx
@@ -35,8 +35,8 @@ class SVXCORE_DLLPUBLIC XLineStartItem final : public NameOrIndex
 public:
             static SfxPoolItem* CreateDefault();
             XLineStartItem(sal_Int32 nIndex = -1);
-            XLineStartItem(const OUString& rName, const basegfx::B2DPolyPolygon& rPolyPolygon);
-            XLineStartItem(const basegfx::B2DPolyPolygon& rPolyPolygon);
+            XLineStartItem(const OUString& rName, basegfx::B2DPolyPolygon aPolyPolygon);
+            XLineStartItem(basegfx::B2DPolyPolygon aPolyPolygon);
             XLineStartItem(const XLineStartItem& rItem);
 
     virtual bool            operator==(const SfxPoolItem& rItem) const override;
diff --git a/include/svx/xtable.hxx b/include/svx/xtable.hxx
index cb3a4cca496d..96ad6edda79a 100644
--- a/include/svx/xtable.hxx
+++ b/include/svx/xtable.hxx
@@ -59,7 +59,7 @@ private:
     basegfx::B2DPolyPolygon aB2DPolyPolygon;
 
 public:
-    XLineEndEntry(const basegfx::B2DPolyPolygon& rB2DPolyPolygon, const OUString& rName);
+    XLineEndEntry(basegfx::B2DPolyPolygon aB2DPolyPolygon, const OUString& rName);
     XLineEndEntry(const XLineEndEntry& rOther);
 
     const basegfx::B2DPolyPolygon& GetLineEnd() const
@@ -163,7 +163,7 @@ protected:
     bool                mbListDirty;
     bool                mbEmbedInDocument;
 
-    XPropertyList(XPropertyListType t, const OUString& rPath, const OUString& rReferer);
+    XPropertyList(XPropertyListType t, OUString aPath, OUString aReferer);
     bool isValidIdx(tools::Long nIndex) const;
     virtual BitmapEx CreateBitmapForUI(tools::Long nIndex) = 0;