diff options
| author | Chris Sherlock <chris.sherlock79@gmail.com> | 2014-02-07 22:32:58 +1100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2014-02-10 20:38:22 +0000 |
| commit | 19c5867f922e9acf0564b6213fa15cc899a77c16 (patch) | |
| tree | 03e42a8535a955cec57f0e054f23878d2170ade3 /include | |
| parent | 32210fc19324c659603e1dfed1ed006072ccf22f (diff) | |
fdo#74424 HasMirroredGraphics changes
HasMirroredGraphics should be called upon by the object using the
OutputDevice. As I'm focussing on Window, which will be shortly decoupled
from OutputDevice, I have changed HasMirroredGraphics into a virtual
function, and introduced a wrapper function of the same name into Window
that calls upon Window's OutputDevice object.
Due to a bug that never appears to have been fully fixed, mirroring in
printing was broken and a workaround ("hotfix" in the code!) was
implemented but never fully fixed. Therefore, I have overridden
HasMirroredGraphics in Printer and just return false.
Change-Id: I9029e2c50cdb339c1e936bed6b92e8b2aac1dcf9
Reviewed-on: https://gerrit.libreoffice.org/7912
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'include')
| -rw-r--r-- | include/vcl/outdev.hxx | 2 | ||||
| -rw-r--r-- | include/vcl/print.hxx | 2 | ||||
| -rw-r--r-- | include/vcl/window.hxx | 4 |
3 files changed, 7 insertions, 1 deletions
diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx index 7458475a428b..546331be8ea1 100644 --- a/include/vcl/outdev.hxx +++ b/include/vcl/outdev.hxx @@ -755,7 +755,7 @@ public: */ ///@{ SAL_DLLPRIVATE sal_Bool ImplIsRecordLayout() const; - SAL_DLLPRIVATE bool HasMirroredGraphics() const; + virtual bool HasMirroredGraphics() const; SAL_DLLPRIVATE void ReMirror( Point &rPoint ) const; SAL_DLLPRIVATE void ReMirror( Rectangle &rRect ) const; SAL_DLLPRIVATE void ReMirror( Region &rRegion ) const; diff --git a/include/vcl/print.hxx b/include/vcl/print.hxx index 93595fcfbc2c..672b1fd62ae2 100644 --- a/include/vcl/print.hxx +++ b/include/vcl/print.hxx @@ -373,6 +373,8 @@ public: const JobSetup& i_rInitSetup ); + virtual bool HasMirroredGraphics() const; + // implementation detail of PrintJob being asynchronous // not exported, not usable outside vcl static void SAL_DLLPRIVATE ImplPrintJob( const boost::shared_ptr<vcl::PrinterController>& i_pController, diff --git a/include/vcl/window.hxx b/include/vcl/window.hxx index bf6bf2467e59..51cd179760ef 100644 --- a/include/vcl/window.hxx +++ b/include/vcl/window.hxx @@ -575,6 +575,10 @@ protected: virtual Window* getAccessibleRelationLabelFor() const; virtual sal_uInt16 getDefaultAccessibleRole() const; virtual OUString getDefaultAccessibleName() const; + +public: + bool HasMirroredGraphics() const; + public: // Single argument ctors shall be explicit. explicit Window( Window* pParent, WinBits nStyle = 0 ); |