diff options
author | Noel Grandin <noel@peralex.com> | 2016-03-02 16:39:41 +0200 |
---|---|---|
committer | Noel Grandin <noel@peralex.com> | 2016-03-03 08:11:02 +0200 |
commit | 2b7215e6fa12cd947bdbbe195909642a850cfd69 (patch) | |
tree | dadafac588440a970fe5de3106388f6f8276b775 /include | |
parent | fecfd9c4987229c7fb335c6c6ba847e2ec30d40d (diff) |
loplugin:unuseddefaultparams in oox
Change-Id: If05662102e161d3dd56bbb6ed3964e63ba853cf9
Diffstat (limited to 'include')
-rw-r--r-- | include/oox/core/fastparser.hxx | 2 | ||||
-rw-r--r-- | include/oox/core/xmlfilterbase.hxx | 2 | ||||
-rw-r--r-- | include/oox/helper/binaryinputstream.hxx | 2 | ||||
-rw-r--r-- | include/oox/helper/binaryoutputstream.hxx | 2 | ||||
-rw-r--r-- | include/oox/helper/containerhelper.hxx | 19 | ||||
-rw-r--r-- | include/oox/ole/axbinarywriter.hxx | 8 | ||||
-rw-r--r-- | include/oox/ole/vbaproject.hxx | 3 | ||||
-rw-r--r-- | include/oox/vml/vmlshape.hxx | 3 |
8 files changed, 16 insertions, 25 deletions
diff --git a/include/oox/core/fastparser.hxx b/include/oox/core/fastparser.hxx index e19bdeb87026..946e6541dbb6 100644 --- a/include/oox/core/fastparser.hxx +++ b/include/oox/core/fastparser.hxx @@ -71,7 +71,7 @@ public: /** Parses a stream from the passed storage with the specified name. @param bCloseStream True = closes the stream after parsing. */ - void parseStream( StorageBase& rStorage, const OUString& rStreamName, bool bCloseStream = false ) + void parseStream( StorageBase& rStorage, const OUString& rStreamName ) throw( css::xml::sax::SAXException, css::io::IOException, css::uno::RuntimeException ); css::uno::Reference< css::xml::sax::XFastTokenHandler > diff --git a/include/oox/core/xmlfilterbase.hxx b/include/oox/core/xmlfilterbase.hxx index e2415b3f64ca..b55a4217190c 100644 --- a/include/oox/core/xmlfilterbase.hxx +++ b/include/oox/core/xmlfilterbase.hxx @@ -146,7 +146,7 @@ public: @return Added relation Id. */ - OUString addRelation( const OUString& rType, const OUString& rTarget, bool bExternal = false ); + OUString addRelation( const OUString& rType, const OUString& rTarget ); /** Adds new relation to part's relations. diff --git a/include/oox/helper/binaryinputstream.hxx b/include/oox/helper/binaryinputstream.hxx index fba55a0127c7..101f1f0ad580 100644 --- a/include/oox/helper/binaryinputstream.hxx +++ b/include/oox/helper/binaryinputstream.hxx @@ -188,7 +188,7 @@ public: /** Copies nBytes bytes from the current position to the passed output stream. */ - void copyToStream( BinaryOutputStream& rOutStrm, sal_Int64 nBytes = SAL_MAX_INT64, sal_Int32 nAtomSize = 1 ); + void copyToStream( BinaryOutputStream& rOutStrm, sal_Int64 nBytes = SAL_MAX_INT64 ); protected: /** This dummy default c'tor will never call the c'tor of the virtual base diff --git a/include/oox/helper/binaryoutputstream.hxx b/include/oox/helper/binaryoutputstream.hxx index 486b4efa9d43..8e315fadaa30 100644 --- a/include/oox/helper/binaryoutputstream.hxx +++ b/include/oox/helper/binaryoutputstream.hxx @@ -73,7 +73,7 @@ public: BinaryOutputStream& WriteUInt32(sal_uInt32 x) { writeValue(x); return *this; } BinaryOutputStream& WriteInt64(sal_Int64 x) { writeValue(x); return *this; } - void writeCompressedUnicodeArray( const OUString& rString, bool bCompressed, bool bAllowNulChars = false ); + void writeCompressedUnicodeArray( const OUString& rString, bool bCompressed ); void writeCharArrayUC( const OUString& rString, rtl_TextEncoding eTextEnc, bool bAllowNulChars = false ); diff --git a/include/oox/helper/containerhelper.hxx b/include/oox/helper/containerhelper.hxx index 66d098f869ce..6fc6bd7eb6af 100644 --- a/include/oox/helper/containerhelper.hxx +++ b/include/oox/helper/containerhelper.hxx @@ -150,8 +150,7 @@ public: static OUString getUnusedName( const css::uno::Reference< css::container::XNameAccess >& rxNameAccess, const OUString& rSuggestedName, - sal_Unicode cSeparator, - sal_Int32 nFirstIndexToAppend = 1 ); + sal_Unicode cSeparator ); /** Inserts an object into a name container. @@ -167,8 +166,7 @@ public: static bool insertByName( const css::uno::Reference< css::container::XNameContainer >& rxNameContainer, const OUString& rName, - const css::uno::Any& rObject, - bool bReplaceOldExisting = true ); + const css::uno::Any& rObject ); /** Inserts an object into a name container. @@ -184,13 +182,9 @@ public: @param rObject The object to be inserted. - @param bRenameOldExisting Specifies behaviour if an object with the - suggested name already exists. If false (default), the new object - will be inserted with a name not yet extant in the container (this - is done by appending a numerical index to the suggested name). If - true, the existing object will be removed and inserted with an - unused name, and the new object will be inserted with the suggested - name. + The new object + will be inserted with a name not yet extant in the container (this + is done by appending a numerical index to the suggested name). @return The final name the object is inserted with. Will always be equal to the suggested name, if parameter bRenameOldExisting is @@ -200,8 +194,7 @@ public: const css::uno::Reference< css::container::XNameContainer >& rxNameContainer, const OUString& rSuggestedName, sal_Unicode cSeparator, - const css::uno::Any& rObject, - bool bRenameOldExisting = false ); + const css::uno::Any& rObject ); // std::vector and std::map element access -------------------------------- diff --git a/include/oox/ole/axbinarywriter.hxx b/include/oox/ole/axbinarywriter.hxx index 02fa348c513e..66dc5000dca1 100644 --- a/include/oox/ole/axbinarywriter.hxx +++ b/include/oox/ole/axbinarywriter.hxx @@ -54,7 +54,7 @@ public: position of the wrapped stream at construction time). */ void align( size_t nSize ); - void pad( sal_Int32 nBytes, size_t nAtomSize = 1); + void pad( sal_Int32 nBytes ); /** Aligns the stream according to the passed type and reads a value. */ template< typename Type > @@ -84,13 +84,13 @@ public: { if( startNextProperty() ) maOutStrm.writeAligned< StreamType >( ornValue ); } /** Write a boolean property value to the stream, the respective flag in the property mask is set. */ - void writeBoolProperty( bool orbValue, bool bReverse = false ); + void writeBoolProperty( bool orbValue ); /** Write a pair property the stream, the respective flag in the property mask is set. */ void writePairProperty( AxPairData& orPairData ); /** Write a string property to the stream, the respective flag in the property mask is set. */ - void writeStringProperty( OUString& orValue, bool bCompressed = true ); + void writeStringProperty( OUString& orValue ); /** Skips the next property clears the respective flag in the property mask. */ @@ -100,7 +100,7 @@ public: void finalizeExport(); private: - bool ensureValid( bool bCondition = true ); + bool ensureValid(); bool startNextProperty( bool bSkip = false ); private: diff --git a/include/oox/ole/vbaproject.hxx b/include/oox/ole/vbaproject.hxx index e4ed68255bdb..d5230988e211 100644 --- a/include/oox/ole/vbaproject.hxx +++ b/include/oox/ole/vbaproject.hxx @@ -118,8 +118,7 @@ public: */ void importVbaProject( StorageBase& rVbaPrjStrg, - const GraphicHelper& rGraphicHelper, - bool bDefaultColorBgr = true ); + const GraphicHelper& rGraphicHelper ); bool importVbaProject( StorageBase& rVbaPrjStrg ); diff --git a/include/oox/vml/vmlshape.hxx b/include/oox/vml/vmlshape.hxx index 631359103952..2d3cf21abeb6 100644 --- a/include/oox/vml/vmlshape.hxx +++ b/include/oox/vml/vmlshape.hxx @@ -246,8 +246,7 @@ public: /** Converts position and formatting into the passed existing XShape. */ void convertFormatting( - const css::uno::Reference< css::drawing::XShape >& rxShape, - const ShapeParentAnchor* pParentAnchor = nullptr ) const; + const css::uno::Reference< css::drawing::XShape >& rxShape ) const; protected: explicit ShapeBase( Drawing& rDrawing ); |