loplugin:unuseddefaultparms in include/vcl (part2)

including a fix for a rather glaring bug in BitmapTools.cxx

Change-Id: Id9db990b993cfeea9039c5fbaaa91996adeae22a
Reviewed-on: https://gerrit.libreoffice.org/22713
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

12 files changed, 22 insertions, 34 deletions

diff --git a/include/vcl/BitmapTools.hxx b/include/vcl/BitmapTools.hxx
index b15642408856..d12e9e13b2cd 100644
--- a/include/vcl/BitmapTools.hxx
+++ b/include/vcl/BitmapTools.hxx
@@ -20,7 +20,7 @@ class VCL_DLLPUBLIC BitmapTools
 {
 public:
     static void loadFromSvg(SvStream& rStream, const OUString& sPath, BitmapEx& rBitmapEx,
-                            double fScaleFactor = 1.0, const Size& aSize = Size());
+                            double fScaleFactor = 1.0);
 };
 
 }
diff --git a/include/vcl/alpha.hxx b/include/vcl/alpha.hxx
index 9b7e6b44a6a3..950e82d9c0c1 100644
--- a/include/vcl/alpha.hxx
+++ b/include/vcl/alpha.hxx
@@ -55,7 +55,7 @@ public:
 
     bool        Erase( sal_uInt8 cTransparency );
     bool        Replace( const Bitmap& rMask, sal_uInt8 rReplaceTransparency );
-    bool        Replace( sal_uInt8 cSearchTransparency, sal_uInt8 cReplaceTransparency, sal_uLong nTol = 0UL );
+    bool        Replace( sal_uInt8 cSearchTransparency, sal_uInt8 cReplaceTransparency );
 
     BitmapReadAccess*  AcquireReadAccess() { return Bitmap::AcquireReadAccess(); }
     BitmapWriteAccess* AcquireWriteAccess() { return Bitmap::AcquireWriteAccess(); }
diff --git a/include/vcl/bitmapex.hxx b/include/vcl/bitmapex.hxx
index a4dea75da7ae..cdf1414f7e18 100644
--- a/include/vcl/bitmapex.hxx
+++ b/include/vcl/bitmapex.hxx
@@ -123,11 +123,8 @@ public:
         This method dithers the bitmap inplace, i.e. a true color
         bitmap is converted to a paletted bitmap, reducing the color
         deviation by error diffusion.
-
-        @param nDitherFlags
-        The algorithm to be used for dithering
      */
-    bool                Dither( BmpDitherFlags nDitherFlags = BmpDitherFlags::Matrix );
+    bool                Dither();
 
     /** Crop the bitmap
 
@@ -277,17 +274,11 @@ public:
         @param rReplaceColor
         Color to be placed in all changed pixel
 
-        @param nTol
-        Tolerance value. Specifies the maximal difference between
-        rSearchColor and the individual pixel values, such that the
-        corresponding pixel is still regarded a match.
-
         @return true, if the operation was completed successfully.
      */
     bool                Replace(
                             const Color& rSearchColor,
-                            const Color& rReplaceColor,
-                            sal_uLong nTol = 0 );
+                            const Color& rReplaceColor );
 
     /** Replace all pixel having one the search colors with the corresponding replace color
 
diff --git a/include/vcl/button.hxx b/include/vcl/button.hxx
index 2cea4564235c..91ba1e3c7916 100644
--- a/include/vcl/button.hxx
+++ b/include/vcl/button.hxx
@@ -91,7 +91,7 @@ public:
 
     void                SetFocusRect( const Rectangle& rFocusRect );
     bool                IsSmallSymbol() const;
-    void                SetSmallSymbol(bool bSmall = true);
+    void                SetSmallSymbol();
     virtual bool        set_property(const OString &rKey, const OString &rValue) override;
 
     /// Sets the button state according to the FeatureStateEvent emitted by an Uno state change.
@@ -127,7 +127,7 @@ protected:
     SAL_DLLPRIVATE void            ImplInitSettings( bool bFont, bool bForeground, bool bBackground );
     SAL_DLLPRIVATE void            ImplDrawPushButtonContent(OutputDevice* pDev, DrawFlags nDrawFlags,
                                                              const Rectangle& rRect, bool bLayout, bool bMenuBtnSep);
-    SAL_DLLPRIVATE void            ImplDrawPushButton(vcl::RenderContext& rRenderContext, bool bLayout = false);
+    SAL_DLLPRIVATE void            ImplDrawPushButton(vcl::RenderContext& rRenderContext);
     using Button::ImplGetTextStyle;
     SAL_DLLPRIVATE DrawTextFlags   ImplGetTextStyle( DrawFlags nDrawFlags ) const;
     SAL_DLLPRIVATE bool            IsSymbol() const { return ( (meSymbol != SymbolType::DONTKNOW) && (meSymbol != SymbolType::IMAGE) ); }
@@ -195,7 +195,7 @@ public:
     void            SaveValue() { meSaveValue = GetState(); }
     bool            IsValueChangedFromSaved() const { return meSaveValue != GetState(); }
 
-    Size            CalcMinimumSize( long nMaxWidth = 0 ) const;
+    Size            CalcMinimumSize() const;
     virtual Size    GetOptimalSize() const override;
 
     virtual bool    set_property(const OString &rKey, const OString &rValue) override;
@@ -298,7 +298,7 @@ private:
                               const Point& rPos, const Size& rSize,
                               const Size& rImageSize, Rectangle& rStateRect,
                               Rectangle& rMouseRect, bool bLayout = false );
-    SAL_DLLPRIVATE void     ImplDrawRadioButton(vcl::RenderContext& rRenderContext, bool bLayout = false );
+    SAL_DLLPRIVATE void     ImplDrawRadioButton(vcl::RenderContext& rRenderContext );
     SAL_DLLPRIVATE void     ImplUncheckAllOther();
     SAL_DLLPRIVATE Size     ImplGetRadioImageSize() const;
     SAL_DLLPRIVATE long     ImplGetImageToTextDistance() const;
@@ -369,7 +369,7 @@ public:
 
     static Image    GetRadioImage( const AllSettings& rSettings, DrawButtonFlags nFlags );
 
-    Size            CalcMinimumSize( long nMaxWidth = 0 ) const;
+    Size            CalcMinimumSize() const;
     virtual Size    GetOptimalSize() const override;
 
     void            SetToggleHdl( const Link<RadioButton&,void>& rLink ) { maToggleHdl = rLink; }
@@ -420,7 +420,7 @@ private:
                                     const Point& rPos, const Size& rSize,
                                     const Size& rImageSize, Rectangle& rStateRect,
                                     Rectangle& rMouseRect, bool bLayout );
-    SAL_DLLPRIVATE void         ImplDrawCheckBox(vcl::RenderContext& rRenderContext, bool bLayout = false );
+    SAL_DLLPRIVATE void         ImplDrawCheckBox(vcl::RenderContext& rRenderContext );
     SAL_DLLPRIVATE long         ImplGetImageToTextDistance() const;
     SAL_DLLPRIVATE Size         ImplGetCheckImageSize() const;
 
diff --git a/include/vcl/commandinfoprovider.hxx b/include/vcl/commandinfoprovider.hxx
index 8871de69862b..d6aa358e7192 100644
--- a/include/vcl/commandinfoprovider.hxx
+++ b/include/vcl/commandinfoprovider.hxx
@@ -72,16 +72,13 @@ public:
             The command name is expected to start with .uno:
         @param rxFrame
             The frame is used to identify the module and document.
-        @param bIncludeShortcut
-            Whether the shortcut should be appended in brackets
         @return
             The returned label contains the keyboard accelerator, if
             one is defined and bIncludeShortcut is true.
     */
     OUString GetTooltipForCommand (
         const OUString& rsCommandName,
-        const css::uno::Reference<css::frame::XFrame>& rxFrame,
-        bool bIncludeShortcut = true);
+        const css::uno::Reference<css::frame::XFrame>& rxFrame);
 
     /** Returns the shortcut for a command in human-readable form */
     OUString GetCommandShortcut (const OUString& rCommandName,
diff --git a/include/vcl/cursor.hxx b/include/vcl/cursor.hxx
index 038e18f5b2c7..d71d387e8953 100644
--- a/include/vcl/cursor.hxx
+++ b/include/vcl/cursor.hxx
@@ -56,7 +56,7 @@ private:
 public:
     SAL_DLLPRIVATE void         ImplDraw();
     DECL_DLLPRIVATE_LINK_TYPED( ImplTimerHdl, Timer*, void );
-    SAL_DLLPRIVATE void         ImplShow( bool bDrawDirect = true );
+    SAL_DLLPRIVATE void         ImplShow();
     SAL_DLLPRIVATE void         ImplHide( bool bStopTimer );
     SAL_DLLPRIVATE void         ImplResume( bool bRestore = false );
     SAL_DLLPRIVATE bool         ImplSuspend();
diff --git a/include/vcl/decoview.hxx b/include/vcl/decoview.hxx
index 4a5bd17d7933..1b11d91f753f 100644
--- a/include/vcl/decoview.hxx
+++ b/include/vcl/decoview.hxx
@@ -115,7 +115,7 @@ public:
     Rectangle           DrawFrame( const Rectangle& rRect, DrawFrameStyle nStyle = DrawFrameStyle::Out, DrawFrameFlags nFlags = DrawFrameFlags::NONE );
     Rectangle           DrawButton( const Rectangle& rRect, DrawButtonFlags nStyle );
     void                DrawSeparator( const Point& rStart, const Point& rStop, bool bVertical = true );
-    void                DrawHandle(const Rectangle& rRectangle, bool bVertical = true);
+    void                DrawHandle(const Rectangle& rRectangle);
 };
 
 #endif // INCLUDED_VCL_DECOVIEW_HXX
diff --git a/include/vcl/dockwin.hxx b/include/vcl/dockwin.hxx
index 7da7263ef868..23a5220abfa3 100644
--- a/include/vcl/dockwin.hxx
+++ b/include/vcl/dockwin.hxx
@@ -117,8 +117,8 @@ private:
                     mbLocked:1;
 
                     DECL_LINK_TYPED( PopupModeEnd, FloatingWindow*, void );
-    void            ImplEnableStartDocking( bool bEnable = true )  { mbStartDockingEnabled = bEnable; }
-    bool            ImplStartDockingEnabled()               { return mbStartDockingEnabled; }
+    void            ImplEnableStartDocking()  { mbStartDockingEnabled = true; }
+    bool            ImplStartDockingEnabled() { return mbStartDockingEnabled; }
 
 public:
     ImplDockingWindowWrapper( const vcl::Window *pWindow );
diff --git a/include/vcl/edit.hxx b/include/vcl/edit.hxx
index 628ada5870b4..57a8e07cafab 100644
--- a/include/vcl/edit.hxx
+++ b/include/vcl/edit.hxx
@@ -106,7 +106,7 @@ private:
     SAL_DLLPRIVATE void        ImplInitEditData();
     SAL_DLLPRIVATE void        ImplModified();
     SAL_DLLPRIVATE OUString    ImplGetText() const;
-    SAL_DLLPRIVATE void        ImplRepaint(vcl::RenderContext& rRenderContext, const Rectangle& rRectangle, bool bLayout = false);
+    SAL_DLLPRIVATE void        ImplRepaint(vcl::RenderContext& rRenderContext, const Rectangle& rRectangle);
     SAL_DLLPRIVATE void        ImplInvalidateOrRepaint();
     SAL_DLLPRIVATE void        ImplDelete( const Selection& rSelection, sal_uInt8 nDirection, sal_uInt8 nMode );
     SAL_DLLPRIVATE void        ImplSetText( const OUString& rStr, const Selection* pNewSelection = nullptr );
diff --git a/include/vcl/field.hxx b/include/vcl/field.hxx
index 641a3abeabe2..62db9fb204ac 100644
--- a/include/vcl/field.hxx
+++ b/include/vcl/field.hxx
@@ -238,7 +238,7 @@ public:
     using NumericFormatter::GetMin;
     sal_Int64               GetMin( FieldUnit eOutUnit ) const;
     void                    SetBaseValue( sal_Int64 nNewBase, FieldUnit eInUnit = FUNIT_NONE );
-    sal_Int64               GetBaseValue( FieldUnit eOutUnit = FUNIT_NONE ) const;
+    sal_Int64               GetBaseValue() const;
 
     virtual void            SetValue( sal_Int64 nNewValue, FieldUnit eInUnit );
     virtual void            SetValue( sal_Int64 nValue ) override;
@@ -679,7 +679,7 @@ public:
 
     void                    InsertValue( sal_Int64 nValue, FieldUnit eInUnit = FUNIT_NONE,
                                          sal_Int32  nPos = COMBOBOX_APPEND );
-    sal_Int64               GetValue( sal_Int32  nPos, FieldUnit eOutUnit = FUNIT_NONE ) const;
+    sal_Int64               GetValue( sal_Int32  nPos ) const;
     sal_Int32               GetValuePos( sal_Int64 nValue,
                                          FieldUnit eInUnit = FUNIT_NONE ) const;
 
diff --git a/include/vcl/fixed.hxx b/include/vcl/fixed.hxx
index cfbddb5fbad2..ccedac4832b9 100644
--- a/include/vcl/fixed.hxx
+++ b/include/vcl/fixed.hxx
@@ -96,7 +96,7 @@ private:
     using Window::ImplInit;
     SAL_DLLPRIVATE void    ImplInit( vcl::Window* pParent, WinBits nStyle );
     SAL_DLLPRIVATE WinBits ImplInitStyle( WinBits nStyle );
-    SAL_DLLPRIVATE void    ImplDraw(vcl::RenderContext& rRenderContext, bool bLayout = false);
+    SAL_DLLPRIVATE void    ImplDraw(vcl::RenderContext& rRenderContext);
 
 protected:
     virtual void    FillLayoutData() const override;
diff --git a/include/vcl/gdimtf.hxx b/include/vcl/gdimtf.hxx
index 5c4b8acd1df4..47d78a467008 100644
--- a/include/vcl/gdimtf.hxx
+++ b/include/vcl/gdimtf.hxx
@@ -138,17 +138,17 @@ public:
 
     void            Convert( MtfConversion eConversion );
     void            ReplaceColors( const Color* pSearchColors, const Color* rReplaceColors,
-                                   sal_uLong nColorCount, sal_uLong* pTols = nullptr );
+                                   sal_uLong nColorCount );
 
     GDIMetaFile     GetMonochromeMtf( const Color& rCol ) const;
 
     void            Record( OutputDevice* pOutDev );
     bool            IsRecord() const { return bRecord; }
 
-    void            Play( GDIMetaFile& rMtf, size_t nPos = GDI_METAFILE_END );
+    void            Play( GDIMetaFile& rMtf );
     void            Play( OutputDevice* pOutDev, size_t nPos = GDI_METAFILE_END );
     void            Play( OutputDevice* pOutDev, const Point& rPos,
-                          const Size& rSize, size_t nPos = GDI_METAFILE_END );
+                          const Size& rSize );
 
     void            Pause( bool bPause );
     bool            IsPause() const { return bPause; }