diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-09-23 08:48:06 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-09-27 11:48:46 +0200 |
commit | 1534025a0386584a7b8f3f929b10ce5eb33257cf (patch) | |
tree | 7f12dd6763148089cd4fb5495c8fffe84f415e12 /include | |
parent | 0f2e01677cd0e8857faec99c61d71e88eee78b27 (diff) |
loplugin:methodcycles more graph theory for the win
implemeent a reduction approach, which is good at finding virtual
methods that only themselves or their virtual partners.
The accessibility GetVisArea stuff is dead since
commit 891e41fac81fbd8d5cdb277b26639abfd25a7143
Date: Wed Apr 4 11:23:22 2018 +0200
dead code in AccessibleTextHelper_Impl::UpdateVisibleChildren
Change-Id: I78d9d8bca585ecec8394f2c3fe2baa93db0e58f5
Reviewed-on: https://gerrit.libreoffice.org/60912
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'include')
-rw-r--r-- | include/editeng/unoedprx.hxx | 3 | ||||
-rw-r--r-- | include/editeng/unoedsrc.hxx | 12 | ||||
-rw-r--r-- | include/editeng/unoviwou.hxx | 1 | ||||
-rw-r--r-- | include/sfx2/objsh.hxx | 2 | ||||
-rw-r--r-- | include/svl/style.hxx | 1 | ||||
-rw-r--r-- | include/svx/sdr/contact/objectcontact.hxx | 12 | ||||
-rw-r--r-- | include/svx/sdr/contact/objectcontactofobjlistpainter.hxx | 3 | ||||
-rw-r--r-- | include/svx/sdr/overlay/overlaymanager.hxx | 3 | ||||
-rw-r--r-- | include/svx/svdmrkv.hxx | 1 | ||||
-rw-r--r-- | include/svx/svdobj.hxx | 2 | ||||
-rw-r--r-- | include/svx/svdogrp.hxx | 1 | ||||
-rw-r--r-- | include/svx/svdotable.hxx | 1 | ||||
-rw-r--r-- | include/svx/svdotext.hxx | 1 | ||||
-rw-r--r-- | include/svx/svdovirt.hxx | 2 | ||||
-rw-r--r-- | include/svx/svdpage.hxx | 1 | ||||
-rw-r--r-- | include/svx/svdundo.hxx | 2 | ||||
-rw-r--r-- | include/svx/unoshtxt.hxx | 1 | ||||
-rw-r--r-- | include/vcl/field.hxx | 4 |
18 files changed, 0 insertions, 53 deletions
diff --git a/include/editeng/unoedprx.hxx b/include/editeng/unoedprx.hxx index dd296af6375f..b0abe19ad0fd 100644 --- a/include/editeng/unoedprx.hxx +++ b/include/editeng/unoedprx.hxx @@ -72,8 +72,6 @@ public: virtual bool GetAttributeRun( sal_Int32& nStartIndex, sal_Int32& nEndIndex, sal_Int32 nPara, sal_Int32 nIndex, bool bInCell = false ) const override; virtual sal_Int32 GetLineCount( sal_Int32 nPara ) const override; virtual sal_Int32 GetLineLen( sal_Int32 nPara, sal_Int32 nLine ) const override; - virtual void SetUpdateModeForAcc( bool bUp) override; - virtual bool GetUpdateModeForAcc() const override; virtual void GetLineBoundaries( /*out*/sal_Int32 &rStart, /*out*/sal_Int32 &rEnd, sal_Int32 nParagraph, sal_Int32 nLine ) const override; virtual sal_Int32 GetLineNumberAtIndex( sal_Int32 nPara, sal_Int32 nIndex ) const override; @@ -118,7 +116,6 @@ public: // SvxViewForwarder interface virtual bool IsValid() const override; - virtual tools::Rectangle GetVisArea() const override; virtual Point LogicToPixel( const Point& rPoint, const MapMode& rMapMode ) const override; virtual Point PixelToLogic( const Point& rPoint, const MapMode& rMapMode ) const override; diff --git a/include/editeng/unoedsrc.hxx b/include/editeng/unoedsrc.hxx index 3c7952bad1cc..c3e22c9767a3 100644 --- a/include/editeng/unoedsrc.hxx +++ b/include/editeng/unoedsrc.hxx @@ -215,9 +215,6 @@ public: */ virtual EBulletInfo GetBulletInfo( sal_Int32 nPara ) const = 0; - virtual void SetUpdateModeForAcc(bool) {} - virtual bool GetUpdateModeForAcc() const { return true; } - /** Query the bounding rectangle of the given character @param nPara[0 .. n] @@ -460,15 +457,6 @@ public: */ virtual bool IsValid() const = 0; - /** Query visible area of the view containing the text - - @return the visible rectangle of the text, i.e. the part of - the EditEngine or Outliner that is currently on screen. The - values are already in screen coordinates (pixel), and have to - be relative to the EditEngine/Outliner's upper left corner. - */ - virtual tools::Rectangle GetVisArea() const = 0; - /** Convert from logical, EditEngine-relative coordinates to screen coordinates @param rPoint diff --git a/include/editeng/unoviwou.hxx b/include/editeng/unoviwou.hxx index 7a4dc1c2b3ca..39ed56ff7561 100644 --- a/include/editeng/unoviwou.hxx +++ b/include/editeng/unoviwou.hxx @@ -41,7 +41,6 @@ public: virtual bool IsValid() const override; - virtual tools::Rectangle GetVisArea() const override; virtual Point LogicToPixel( const Point& rPoint, const MapMode& rMapMode ) const override; virtual Point PixelToLogic( const Point& rPoint, const MapMode& rMapMode ) const override; diff --git a/include/sfx2/objsh.hxx b/include/sfx2/objsh.hxx index 1c31ed32d9c6..54d97faf3162 100644 --- a/include/sfx2/objsh.hxx +++ b/include/sfx2/objsh.hxx @@ -437,7 +437,6 @@ public: Size GetFirstPageSize(); bool DoClose(); - virtual void PrepareReload(); std::shared_ptr<GDIMetaFile> GetPreviewMetaFile( bool bFullContent = false ) const; virtual void CancelTransfers(); @@ -580,7 +579,6 @@ public: static OUString GetServiceNameFromFactory( const OUString& rFact ); bool IsInPlaceActive(); bool IsUIActive(); - virtual void InPlaceActivate( bool ); static bool CopyStoragesOfUnknownMediaType( const css::uno::Reference< css::embed::XStorage >& xSource, diff --git a/include/svl/style.hxx b/include/svl/style.hxx index 4bf91c357765..c60d85fb833e 100644 --- a/include/svl/style.hxx +++ b/include/svl/style.hxx @@ -132,7 +132,6 @@ protected: SfxStyleSheetBase( const OUString&, SfxStyleSheetBasePool*, SfxStyleFamily eFam, SfxStyleSearchBits mask ); SfxStyleSheetBase( const SfxStyleSheetBase& ); virtual ~SfxStyleSheetBase() override; - virtual void Load( SvStream&, sal_uInt16 ); public: diff --git a/include/svx/sdr/contact/objectcontact.hxx b/include/svx/sdr/contact/objectcontact.hxx index 9af38ca77d62..d305d61b007d 100644 --- a/include/svx/sdr/contact/objectcontact.hxx +++ b/include/svx/sdr/contact/objectcontact.hxx @@ -112,9 +112,6 @@ public: // this ObjectContact. Default does nothing. virtual void InvalidatePartOfView(const basegfx::B2DRange& rRange) const; - // Get info if given Rectangle is visible in this view - virtual bool IsAreaVisible(const basegfx::B2DRange& rRange) const; - // Get info about the need to visualize GluePoints. The default // is that it is not necessary. virtual bool AreGluePointsVisible() const; @@ -135,12 +132,6 @@ public: // print? Default is false virtual bool isOutputToPrinter() const; - // window? Default is true - virtual bool isOutputToWindow() const; - - // VirtualDevice? Default is false - virtual bool isOutputToVirtualDevice() const; - // recording MetaFile? Default is false virtual bool isOutputToRecordingMetaFile() const; @@ -150,9 +141,6 @@ public: // gray display mode virtual bool isDrawModeGray() const; - // gray display mode - virtual bool isDrawModeBlackWhite() const; - // high contrast display mode virtual bool isDrawModeHighContrast() const; diff --git a/include/svx/sdr/contact/objectcontactofobjlistpainter.hxx b/include/svx/sdr/contact/objectcontactofobjlistpainter.hxx index 7390f30b08a7..d9d0ffbf795b 100644 --- a/include/svx/sdr/contact/objectcontactofobjlistpainter.hxx +++ b/include/svx/sdr/contact/objectcontactofobjlistpainter.hxx @@ -71,9 +71,6 @@ public: // Process the whole displaying virtual void ProcessDisplay(DisplayInfo& rDisplayInfo) override; - // VirtualDevice? Default is false - virtual bool isOutputToVirtualDevice() const override; - // recording MetaFile? Default is false virtual bool isOutputToRecordingMetaFile() const override; diff --git a/include/svx/sdr/overlay/overlaymanager.hxx b/include/svx/sdr/overlay/overlaymanager.hxx index 25cae11e9dbc..7028f46b4a69 100644 --- a/include/svx/sdr/overlay/overlaymanager.hxx +++ b/include/svx/sdr/overlay/overlaymanager.hxx @@ -103,9 +103,6 @@ namespace sdr // flush. Do buffered updates. virtual void flush(); - // restore part of background. Implemented form buffered versions only. - virtual void restoreBackground(const vcl::Region& rRegion) const; - // get the OutputDevice OutputDevice& getOutputDevice() const { return mrOutputDevice; } diff --git a/include/svx/svdmrkv.hxx b/include/svx/svdmrkv.hxx index ff3c5bff5d1d..08e0d10d5e62 100644 --- a/include/svx/svdmrkv.hxx +++ b/include/svx/svdmrkv.hxx @@ -311,7 +311,6 @@ public: virtual bool HasMarkablePoints() const; virtual sal_Int32 GetMarkablePointCount() const; virtual bool HasMarkedPoints() const; - virtual sal_Int32 GetMarkedPointCount() const; // There might be points which can't be marked: virtual bool IsPointMarkable(const SdrHdl& rHdl) const; diff --git a/include/svx/svdobj.hxx b/include/svx/svdobj.hxx index 91225c243545..76fc5e04f850 100644 --- a/include/svx/svdobj.hxx +++ b/include/svx/svdobj.hxx @@ -682,7 +682,6 @@ public: virtual void NbcSetOutlinerParaObject(std::unique_ptr<OutlinerParaObject> pTextObject); virtual OutlinerParaObject* GetOutlinerParaObject() const; virtual void NbcReformatText(); - virtual void ReformatText(); void BurnInStyleSheetAttributes(); @@ -692,7 +691,6 @@ public: virtual Pointer GetMacroPointer (const SdrObjMacroHitRec& rRec) const; virtual void PaintMacro (OutputDevice& rOut, const tools::Rectangle& rDirtyRect, const SdrObjMacroHitRec& rRec) const; virtual bool DoMacro (const SdrObjMacroHitRec& rRec); - virtual OUString GetMacroPopupComment(const SdrObjMacroHitRec& rRec) const; bool IsMacroHit(const SdrObjMacroHitRec& rRec) const; // Connectors diff --git a/include/svx/svdogrp.hxx b/include/svx/svdogrp.hxx index 24f2159e7bf8..bd1287c19449 100644 --- a/include/svx/svdogrp.hxx +++ b/include/svx/svdogrp.hxx @@ -103,7 +103,6 @@ public: virtual void NbcSetLogicRect(const tools::Rectangle& rRect) override; virtual void NbcReformatText() override; - virtual void ReformatText() override; virtual SdrObject* DoConvertToPolyObj(bool bBezier, bool bAddText) const override; diff --git a/include/svx/svdotable.hxx b/include/svx/svdotable.hxx index b6cf526970a7..ff0f9e77c334 100644 --- a/include/svx/svdotable.hxx +++ b/include/svx/svdotable.hxx @@ -241,7 +241,6 @@ public: virtual OutlinerParaObject* GetOutlinerParaObject() const override; virtual void NbcReformatText() override; - virtual void ReformatText() override; virtual bool IsVerticalWriting() const override; virtual void SetVerticalWriting(bool bVertical) override; diff --git a/include/svx/svdotext.hxx b/include/svx/svdotext.hxx index 9bca148fd443..82d7d9b0657d 100644 --- a/include/svx/svdotext.hxx +++ b/include/svx/svdotext.hxx @@ -493,7 +493,6 @@ public: std::unique_ptr<OutlinerParaObject> GetEditOutlinerParaObject() const; virtual void NbcReformatText() override; - virtual void ReformatText() override; virtual bool CalcFieldValue(const SvxFieldItem& rField, sal_Int32 nPara, sal_uInt16 nPos, bool bEdit, boost::optional<Color>& rpTxtColor, boost::optional<Color>& rpFldColor, OUString& rRet) const; diff --git a/include/svx/svdovirt.hxx b/include/svx/svdovirt.hxx index 47ed2f4b1d03..8ab92bd69e8d 100644 --- a/include/svx/svdovirt.hxx +++ b/include/svx/svdovirt.hxx @@ -134,14 +134,12 @@ public: virtual void SetGeoData(const SdrObjGeoData& rGeo) override; virtual void NbcReformatText() override; - virtual void ReformatText() override; virtual bool HasMacro() const override; virtual SdrObject* CheckMacroHit (const SdrObjMacroHitRec& rRec) const override; virtual Pointer GetMacroPointer (const SdrObjMacroHitRec& rRec) const override; virtual void PaintMacro (OutputDevice& rOut, const tools::Rectangle& rDirtyRect, const SdrObjMacroHitRec& rRec) const override; virtual bool DoMacro (const SdrObjMacroHitRec& rRec) override; - virtual OUString GetMacroPopupComment(const SdrObjMacroHitRec& rRec) const override; // #i73248# for default SdrVirtObj, offset is aAnchor, not (0,0) virtual const Point GetOffset() const; diff --git a/include/svx/svdpage.hxx b/include/svx/svdpage.hxx index 6041593c9f50..0d76d7e6dbab 100644 --- a/include/svx/svdpage.hxx +++ b/include/svx/svdpage.hxx @@ -123,7 +123,6 @@ public: /// Replace existing object by different one. /// Same as Remove(old)+Insert(new) but faster because the order numbers /// do not have to be set dirty. - virtual SdrObject* NbcReplaceObject(SdrObject* pNewObj, size_t nObjNum); virtual SdrObject* ReplaceObject(SdrObject* pNewObj, size_t nObjNum); /// Modify ZOrder of an SdrObject diff --git a/include/svx/svdundo.hxx b/include/svx/svdundo.hxx index 6d8896916bcd..9e969ebbbb4f 100644 --- a/include/svx/svdundo.hxx +++ b/include/svx/svdundo.hxx @@ -730,7 +730,6 @@ class SVX_DLLPUBLIC SdrUndoFactory public: // Shapes virtual ~SdrUndoFactory(); - virtual SdrUndoAction* CreateUndoMoveObject( SdrObject& rObject ); virtual SdrUndoAction* CreateUndoMoveObject( SdrObject& rObject, const Size& rDist ); virtual SdrUndoAction* CreateUndoGeoObject( SdrObject& rObject ); virtual SdrUndoAction* CreateUndoAttrObject( SdrObject& rObject, bool bStyleSheet1 = false, bool bSaveText = false ); @@ -755,7 +754,6 @@ public: // Layer virtual SdrUndoAction* CreateUndoNewLayer(sal_uInt16 nLayerNum, SdrLayerAdmin& rNewLayerAdmin, SdrModel& rNewModel); virtual SdrUndoAction* CreateUndoDeleteLayer(sal_uInt16 nLayerNum, SdrLayerAdmin& rNewLayerAdmin, SdrModel& rNewModel); - virtual SdrUndoAction* CreateUndoMoveLayer(sal_uInt16 nLayerNum, SdrLayerAdmin& rNewLayerAdmin, SdrModel& rNewModel, sal_uInt16 nNewPos1); // Page virtual SdrUndoAction* CreateUndoDeletePage(SdrPage& rPage); diff --git a/include/svx/unoshtxt.hxx b/include/svx/unoshtxt.hxx index 55afd0f40207..9acd57f6172c 100644 --- a/include/svx/unoshtxt.hxx +++ b/include/svx/unoshtxt.hxx @@ -73,7 +73,6 @@ public: // the SvxViewForwarder interface virtual bool IsValid() const override; - virtual tools::Rectangle GetVisArea() const override; virtual Point LogicToPixel( const Point&, const MapMode& ) const override; virtual Point PixelToLogic( const Point&, const MapMode& ) const override; diff --git a/include/vcl/field.hxx b/include/vcl/field.hxx index c57e511d7767..e9407fa66f32 100644 --- a/include/vcl/field.hxx +++ b/include/vcl/field.hxx @@ -75,7 +75,6 @@ public: virtual void Reformat(); virtual void ReformatAll(); - virtual void SetLocale( const css::lang::Locale& rLocale ); const css::lang::Locale& GetLocale() const; const LanguageTag& GetLanguageTag() const; @@ -313,9 +312,6 @@ public: virtual void Reformat() override; virtual void ReformatAll() override; - virtual void SetLocale( const css::lang::Locale& rLocale ) override; - - void SetExtDateFormat( ExtDateFieldFormat eFormat ); ExtDateFieldFormat GetExtDateFormat( bool bResolveSystemFormat = false ) const; |