diff options
| author | Noel Grandin <noel@peralex.com> | 2016-07-18 09:22:27 +0200 |
|---|---|---|
| committer | Noel Grandin <noelgrandin@gmail.com> | 2016-07-27 06:48:25 +0000 |
| commit | 508c95f1b655d9cfa6be37a5a9de9aff6fd383bf (patch) | |
| tree | d1c8626818cbf26a699875ae2d82f751a1657e92 /include | |
| parent | 9f4af777a832d8a0b9a21d793d421fa6228131e0 (diff) | |
improve passstuffbyref return analysis
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c
Reviewed-on: https://gerrit.libreoffice.org/27317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'include')
45 files changed, 78 insertions, 78 deletions
diff --git a/include/basic/sbmod.hxx b/include/basic/sbmod.hxx index 3727d1dcfbb6..03d6fb2151a9 100644 --- a/include/basic/sbmod.hxx +++ b/include/basic/sbmod.hxx @@ -128,7 +128,7 @@ public: bool isProxyModule() { return bIsProxyModule; } void AddVarName( const OUString& aName ); void RemoveVars(); - css::uno::Reference< css::script::XInvocation > GetUnoModule(); + css::uno::Reference< css::script::XInvocation > const & GetUnoModule(); bool createCOMWrapperForIface( css::uno::Any& o_rRetAny, SbClassModuleObject* pProxyClassModuleObject ); void GetCodeCompleteDataFromParse(CodeCompleteDataCache& aCache); const SbxArrayRef& GetMethods() { return pMethods;} diff --git a/include/basic/sbstar.hxx b/include/basic/sbstar.hxx index 1fda1b5310a3..47f21bc3aec0 100644 --- a/include/basic/sbstar.hxx +++ b/include/basic/sbstar.hxx @@ -144,7 +144,7 @@ public: static void SetGlobalBreakHdl( const Link<StarBASIC*,sal_uInt16>& rNewHdl ); - SbxArrayRef getUnoListeners(); + SbxArrayRef const & getUnoListeners(); static SbxBase* FindSBXInCurrentScope( const OUString& rName ); static SbMethod* GetActiveMethod( sal_uInt16 nLevel = 0 ); diff --git a/include/codemaker/options.hxx b/include/codemaker/options.hxx index 2d7ddbf1d07e..5a0f0dba3d70 100644 --- a/include/codemaker/options.hxx +++ b/include/codemaker/options.hxx @@ -52,7 +52,7 @@ public: const ::rtl::OString& getProgramName() const { return m_program;} bool isValid(const ::rtl::OString& option) const; - const ::rtl::OString getOption(const ::rtl::OString& option) const + const OString& getOption(const ::rtl::OString& option) const throw( IllegalArgument ); const StringVector& getInputFiles() { return m_inputFiles;} diff --git a/include/comphelper/accessibletexthelper.hxx b/include/comphelper/accessibletexthelper.hxx index 7dd0fc5155ef..368e468a5978 100644 --- a/include/comphelper/accessibletexthelper.hxx +++ b/include/comphelper/accessibletexthelper.hxx @@ -48,8 +48,8 @@ namespace comphelper OCommonAccessibleText(); virtual ~OCommonAccessibleText(); - css::uno::Reference < css::i18n::XBreakIterator > implGetBreakIterator(); - css::uno::Reference < css::i18n::XCharacterClassification > implGetCharacterClassification(); + css::uno::Reference < css::i18n::XBreakIterator > const & implGetBreakIterator(); + css::uno::Reference < css::i18n::XCharacterClassification > const & implGetCharacterClassification(); static bool implIsValidBoundary( css::i18n::Boundary& rBoundary, sal_Int32 nLength ); static bool implIsValidIndex( sal_Int32 nIndex, sal_Int32 nLength ); static bool implIsValidRange( sal_Int32 nStartIndex, sal_Int32 nEndIndex, sal_Int32 nLength ); diff --git a/include/comphelper/container.hxx b/include/comphelper/container.hxx index 12b33ab92c93..03a7e96de77c 100644 --- a/include/comphelper/container.hxx +++ b/include/comphelper/container.hxx @@ -51,7 +51,7 @@ public: virtual ~IndexAccessIterator(); - css::uno::Reference< css::uno::XInterface> Next(); + css::uno::Reference< css::uno::XInterface> const & Next(); virtual void Invalidate() { m_xCurrentObject = nullptr; } diff --git a/include/connectivity/dbconversion.hxx b/include/connectivity/dbconversion.hxx index a79436eb5685..0c604025a653 100644 --- a/include/connectivity/dbconversion.hxx +++ b/include/connectivity/dbconversion.hxx @@ -67,7 +67,7 @@ namespace dbtools { namespace DBTypeConversion { - OOO_DLLPUBLIC_DBTOOLS css::util::Date getStandardDate(); + OOO_DLLPUBLIC_DBTOOLS css::util::Date const & getStandardDate(); OOO_DLLPUBLIC_DBTOOLS void setValue(const css::uno::Reference< css::sdb::XColumnUpdate>& xVariant, const css::uno::Reference< css::util::XNumberFormatter>& xFormatter, const css::util::Date& rNullDate, diff --git a/include/editeng/unoipset.hxx b/include/editeng/unoipset.hxx index fc24cfbcf99e..9eeede104735 100644 --- a/include/editeng/unoipset.hxx +++ b/include/editeng/unoipset.hxx @@ -57,7 +57,7 @@ public: void AddUsrAnyForID(const css::uno::Any& rAny, sal_uInt16 nWID); void ClearAllUsrAny(); - css::uno::Reference< css::beans::XPropertySetInfo > getPropertySetInfo() const; + css::uno::Reference< css::beans::XPropertySetInfo > const & getPropertySetInfo() const; const SfxItemPropertyMap& getPropertyMap() const { return m_aPropertyMap;} const SfxItemPropertySimpleEntry* getPropertyMapEntry(const OUString &rName) const; }; diff --git a/include/i18nlangtag/languagetag.hxx b/include/i18nlangtag/languagetag.hxx index f494d78bfb25..a1b1bb9104f7 100644 --- a/include/i18nlangtag/languagetag.hxx +++ b/include/i18nlangtag/languagetag.hxx @@ -514,7 +514,7 @@ private: mutable bool mbInitializedLangID : 1; bool mbIsFallback : 1; - ImplPtr getImpl() const; + ImplPtr const & getImpl() const; ImplPtr registerImpl() const; void syncFromImpl(); void syncVarsFromRawImpl() const; diff --git a/include/oox/drawingml/shape.hxx b/include/oox/drawingml/shape.hxx index 520bc51bc1f9..1367e2e22d1d 100644 --- a/include/oox/drawingml/shape.hxx +++ b/include/oox/drawingml/shape.hxx @@ -123,7 +123,7 @@ public: Shape3DProperties& get3DProperties() { return *mp3DPropertiesPtr; } const Shape3DProperties& get3DProperties() const { return *mp3DPropertiesPtr; } - table::TablePropertiesPtr getTableProperties(); + table::TablePropertiesPtr const & getTableProperties(); EffectProperties& getEffectProperties() { return *mpEffectPropertiesPtr; } @@ -216,7 +216,7 @@ public: protected: - css::uno::Reference< css::drawing::XShape > + css::uno::Reference< css::drawing::XShape > const & createAndInsert( ::oox::core::XmlFilterBase& rFilterBase, const OUString& rServiceName, diff --git a/include/oox/ole/axcontrol.hxx b/include/oox/ole/axcontrol.hxx index 4d91f975fc1c..71c8118678c2 100644 --- a/include/oox/ole/axcontrol.hxx +++ b/include/oox/ole/axcontrol.hxx @@ -985,7 +985,7 @@ public: private: /** Creates the form that will hold the form controls. */ - css::uno::Reference< css::container::XIndexContainer > + css::uno::Reference< css::container::XIndexContainer > const & createXForm(); private: diff --git a/include/oox/ole/vbaproject.hxx b/include/oox/ole/vbaproject.hxx index ea7ffcccd351..b7bbd4e1e9be 100644 --- a/include/oox/ole/vbaproject.hxx +++ b/include/oox/ole/vbaproject.hxx @@ -166,10 +166,10 @@ private: css::uno::Reference< css::container::XNameContainer > openLibrary( sal_Int32 nPropId, bool bCreateMissing ); /** Creates and returns the Basic library of the document used for import. */ - css::uno::Reference< css::container::XNameContainer > + css::uno::Reference< css::container::XNameContainer > const & createBasicLibrary(); /** Creates and returns the dialog library of the document used for import. */ - css::uno::Reference< css::container::XNameContainer > + css::uno::Reference< css::container::XNameContainer > const & createDialogLibrary(); /** Imports the VBA code modules and forms. */ diff --git a/include/oox/ppt/timenode.hxx b/include/oox/ppt/timenode.hxx index 546f73a45674..40f51bc54964 100644 --- a/include/oox/ppt/timenode.hxx +++ b/include/oox/ppt/timenode.hxx @@ -77,7 +77,7 @@ namespace oox { namespace ppt { const css::uno::Reference< css::animations::XAnimationNode >& xNode, const SlidePersistPtr & pSlide ); - AnimTargetElementPtr getTarget() + AnimTargetElementPtr const & getTarget() { if( !mpTarget ) mpTarget.reset( new AnimTargetElement ); diff --git a/include/sfx2/docfile.hxx b/include/sfx2/docfile.hxx index ee92f8da0800..a08c22b7bdb7 100644 --- a/include/sfx2/docfile.hxx +++ b/include/sfx2/docfile.hxx @@ -118,7 +118,7 @@ public: */ void SetFilter(const std::shared_ptr<const SfxFilter>& pFilter); const std::shared_ptr<const SfxFilter>& GetFilter() const; - std::shared_ptr<const SfxFilter> GetOrigFilter() const; + std::shared_ptr<const SfxFilter> const & GetOrigFilter() const; const OUString& GetOrigURL() const; SfxItemSet * GetItemSet() const; diff --git a/include/sfx2/sfxbasemodel.hxx b/include/sfx2/sfxbasemodel.hxx index 8e678caf59e0..e6c618bdf274 100644 --- a/include/sfx2/sfxbasemodel.hxx +++ b/include/sfx2/sfxbasemodel.hxx @@ -822,7 +822,7 @@ protected: /* returns a unique id for the model that is valid as long as the document is loaded. The id is not saved across document close/reload. */ - OUString getRuntimeUID() const; + OUString const & getRuntimeUID() const; /* returns true if the document signatures are valid, otherwise false */ bool hasValidSignatures() const; diff --git a/include/sfx2/thumbnailviewitem.hxx b/include/sfx2/thumbnailviewitem.hxx index c37d6aac7276..ed3c4231f5e5 100644 --- a/include/sfx2/thumbnailviewitem.hxx +++ b/include/sfx2/thumbnailviewitem.hxx @@ -109,7 +109,7 @@ public: void setTitle (const OUString& rTitle); - css::uno::Reference< css::accessibility::XAccessible > + css::uno::Reference< css::accessibility::XAccessible > const & GetAccessible( bool bIsTransientChildrenDisabled ); void setDrawArea (const Rectangle &area); diff --git a/include/svl/itemprop.hxx b/include/svl/itemprop.hxx index f9f332b816d5..720cfb423ed6 100644 --- a/include/svl/itemprop.hxx +++ b/include/svl/itemprop.hxx @@ -149,7 +149,7 @@ public: getPropertyState(const SfxItemPropertySimpleEntry& rEntry, const SfxItemSet& rSet) const throw(); - css::uno::Reference<css::beans::XPropertySetInfo> + css::uno::Reference<css::beans::XPropertySetInfo> const & getPropertySetInfo() const; const SfxItemPropertyMap& getPropertyMap() const {return m_aMap;} }; diff --git a/include/svl/style.hxx b/include/svl/style.hxx index 197c93850ed9..b0acd32534ea 100644 --- a/include/svl/style.hxx +++ b/include/svl/style.hxx @@ -112,7 +112,7 @@ public: /** returns the display name of this style, it is used at the user interface. If the display name is empty, this method returns the internal name. */ - OUString GetDisplayName() const; + OUString const & GetDisplayName() const; virtual const OUString& GetParent() const; virtual bool SetParent( const OUString& ); diff --git a/include/svtools/fmtfield.hxx b/include/svtools/fmtfield.hxx index 5cc8bd3f4230..185581c26645 100644 --- a/include/svtools/fmtfield.hxx +++ b/include/svtools/fmtfield.hxx @@ -181,7 +181,7 @@ public: //If someone does not care about all the double handling and just wants to print the text formatted. //(((The text will be formatted, using the Formatter, and then set) void SetTextFormatted(const OUString& rText); - OUString GetTextValue() const; + OUString const & GetTextValue() const; void SetDefaultText(const OUString& rDefault) { m_sDefaultText = rDefault; } const OUString& GetDefaultText() const { return m_sDefaultText; } diff --git a/include/svx/sdr/contact/viewcontact.hxx b/include/svx/sdr/contact/viewcontact.hxx index 6f16ff125600..8e1a882b8a7c 100644 --- a/include/svx/sdr/contact/viewcontact.hxx +++ b/include/svx/sdr/contact/viewcontact.hxx @@ -122,7 +122,7 @@ public: // access to the local primitive. This will ensure that the primitive is // current in comparing the local one with a fresh created incarnation - drawinglayer::primitive2d::Primitive2DContainer getViewIndependentPrimitive2DSequence() const; + drawinglayer::primitive2d::Primitive2DContainer const & getViewIndependentPrimitive2DSequence() const; // add Gluepoints (if available) virtual drawinglayer::primitive2d::Primitive2DContainer createGluePointPrimitive2DSequence() const; diff --git a/include/svx/sdr/contact/viewcontactofe3d.hxx b/include/svx/sdr/contact/viewcontactofe3d.hxx index 9c31755a3e09..b475d511da50 100644 --- a/include/svx/sdr/contact/viewcontactofe3d.hxx +++ b/include/svx/sdr/contact/viewcontactofe3d.hxx @@ -81,7 +81,7 @@ protected: public: // access to the local primitive without the object's local 3D transform. This is e.g. needed // to get the not-yet transformed BoundVolume for e.g. interactions - drawinglayer::primitive3d::Primitive3DContainer getVIP3DSWithoutObjectTransform() const; + drawinglayer::primitive3d::Primitive3DContainer const & getVIP3DSWithoutObjectTransform() const; // access to the local primitive. This will ensure that the list is // current in comparing the local list content with a fresh created incarnation. It will diff --git a/include/svx/sdr/contact/viewobjectcontact.hxx b/include/svx/sdr/contact/viewobjectcontact.hxx index 6936760b8feb..e4253c5185fa 100644 --- a/include/svx/sdr/contact/viewobjectcontact.hxx +++ b/include/svx/sdr/contact/viewobjectcontact.hxx @@ -110,7 +110,7 @@ public: // access to the local primitive. This will ensure that the local primitive is // current in comparing the local one with a fresh created incarnation // This method will not handle included hierarchies and not check visibility. - drawinglayer::primitive2d::Primitive2DContainer getPrimitive2DSequence(const DisplayInfo& rDisplayInfo) const; + drawinglayer::primitive2d::Primitive2DContainer const & getPrimitive2DSequence(const DisplayInfo& rDisplayInfo) const; // test this VOC for visibility concerning model-view stuff like e.g. Layer virtual bool isPrimitiveVisible(const DisplayInfo& rDisplayInfo) const; diff --git a/include/svx/sdr/overlay/overlaymanager.hxx b/include/svx/sdr/overlay/overlaymanager.hxx index 64199a2ec550..44cb21978173 100644 --- a/include/svx/sdr/overlay/overlaymanager.hxx +++ b/include/svx/sdr/overlay/overlaymanager.hxx @@ -95,7 +95,7 @@ namespace sdr static rtl::Reference<OverlayManager> create(OutputDevice& rOutputDevice); // access to current ViewInformation2D; this call checks and evtl. updates ViewInformation2D - const drawinglayer::geometry::ViewInformation2D getCurrentViewInformation2D() const; + drawinglayer::geometry::ViewInformation2D const & getCurrentViewInformation2D() const; // complete redraw virtual void completeRedraw(const vcl::Region& rRegion, OutputDevice* pPreRenderDevice = nullptr) const; diff --git a/include/svx/sdrpaintwindow.hxx b/include/svx/sdrpaintwindow.hxx index 499bb6530d43..a6ad7a0f9789 100644 --- a/include/svx/sdrpaintwindow.hxx +++ b/include/svx/sdrpaintwindow.hxx @@ -100,7 +100,7 @@ public: vcl::Window* GetWindow() const { return mpWindow; } // OVERLAYMANAGER - rtl::Reference< sdr::overlay::OverlayManager > GetOverlayManager() const; + rtl::Reference< sdr::overlay::OverlayManager > const & GetOverlayManager() const; // #i73602# add flag if buffer shall be used void DrawOverlay(const vcl::Region& rRegion); diff --git a/include/svx/svdmodel.hxx b/include/svx/svdmodel.hxx index e86209aaf930..ade835e6bef7 100644 --- a/include/svx/svdmodel.hxx +++ b/include/svx/svdmodel.hxx @@ -524,7 +524,7 @@ public: bool GetDisableTextEditUsesCommonUndoManager() const { return mbDisableTextEditUsesCommonUndoManager; } void SetDisableTextEditUsesCommonUndoManager(bool bNew) { mbDisableTextEditUsesCommonUndoManager = bNew; } - css::uno::Reference< css::uno::XInterface > getUnoModel(); + css::uno::Reference< css::uno::XInterface > const & getUnoModel(); void setUnoModel( const css::uno::Reference< css::uno::XInterface >& xModel ); // these functions are used by the api to disable repaints during a diff --git a/include/svx/svdoashp.hxx b/include/svx/svdoashp.hxx index 69cd93f7b1ec..8bf0037c3e87 100644 --- a/include/svx/svdoashp.hxx +++ b/include/svx/svdoashp.hxx @@ -107,7 +107,7 @@ public: // #i37011# render geometry shadow SdrObject* mpLastShadowGeometry; - css::uno::Reference< css::drawing::XCustomShapeEngine > GetCustomShapeEngine() const; + css::uno::Reference< css::drawing::XCustomShapeEngine > const & GetCustomShapeEngine() const; // SVX_DLLPRIVATE css::uno::Sequence< css::uno::Reference< css::drawing::XCustomShapeHandle > > // SdrObjCustomShape::GetInteraction( const SdrObjCustomShape* pCustomShape ) const; diff --git a/include/svx/svdpage.hxx b/include/svx/svdpage.hxx index 700aa0fc5216..365817b4e865 100644 --- a/include/svx/svdpage.hxx +++ b/include/svx/svdpage.hxx @@ -508,7 +508,7 @@ public: /// otherwise the visible pages virtual const SdrPageGridFrameList* GetGridFrameList(const SdrPageView* pPV, const Rectangle* pRect) const; - css::uno::Reference< css::uno::XInterface > getUnoPage(); + css::uno::Reference< css::uno::XInterface > const & getUnoPage(); virtual SfxStyleSheet* GetTextStyleSheetForObject( SdrObject* pObj ) const; diff --git a/include/svx/textchain.hxx b/include/svx/textchain.hxx index 5416c90a3ecb..8c0c6a3b59e6 100644 --- a/include/svx/textchain.hxx +++ b/include/svx/textchain.hxx @@ -53,11 +53,11 @@ a##PropName = (PropDefault); #define DECL_CHAIN_PROP_INTERFACE(PropName, PropType) \ - PropType Get##PropName (const SdrTextObj *); \ + PropType const & Get##PropName (const SdrTextObj *); \ void Set##PropName (const SdrTextObj *, PropType); #define IMPL_CHAIN_PROP_INTERFACE(PropName, PropType) \ - PropType TextChain::Get##PropName (const SdrTextObj *pTarget) { \ + PropType const & TextChain::Get##PropName (const SdrTextObj *pTarget) { \ ImpChainLinkProperties *pLinkProperties = GetLinkProperties(pTarget); \ return pLinkProperties->a##PropName; \ } \ diff --git a/include/svx/xmleohlp.hxx b/include/svx/xmleohlp.hxx index 3b4226503d39..bd8cb9bd55d2 100644 --- a/include/svx/xmleohlp.hxx +++ b/include/svx/xmleohlp.hxx @@ -72,7 +72,7 @@ private: bool *pGraphicRepl=nullptr, bool *pOasisFormat=nullptr ) const; - SVX_DLLPRIVATE css::uno::Reference < css::embed::XStorage > ImplGetContainerStorage( + SVX_DLLPRIVATE css::uno::Reference < css::embed::XStorage > const & ImplGetContainerStorage( const OUString& rStorageName ); SVX_DLLPRIVATE void ImplReadObject( diff --git a/include/svx/xtable.hxx b/include/svx/xtable.hxx index a692f39e36ba..c55827e97cb0 100644 --- a/include/svx/xtable.hxx +++ b/include/svx/xtable.hxx @@ -321,12 +321,12 @@ public: // Special call to get a bitmap for the solid line representation. It // creates a bitmap fitting in size and style to the ones you get by // using GetUiBitmap for existing entries. - Bitmap GetBitmapForUISolidLine() const; + Bitmap const & GetBitmapForUISolidLine() const; // Special calls to get the translated strings for the UI entry for no // line style (XLINE_NONE) and solid line style (XLINE_SOLID) for dialogs - OUString GetStringForUiSolidLine() const; - OUString GetStringForUiNoLine() const; + OUString const & GetStringForUiSolidLine() const; + OUString const & GetStringForUiNoLine() const; }; class SVX_DLLPUBLIC XHatchList : public XPropertyList diff --git a/include/toolkit/awt/vclxprinter.hxx b/include/toolkit/awt/vclxprinter.hxx index e89613c0cd61..4fe541f15833 100644 --- a/include/toolkit/awt/vclxprinter.hxx +++ b/include/toolkit/awt/vclxprinter.hxx @@ -67,7 +67,7 @@ public: virtual ~VCLXPrinterPropertySet(); Printer* GetPrinter() const { return mxPrinter.get(); } - css::uno::Reference< css::awt::XDevice > GetDevice(); + css::uno::Reference< css::awt::XDevice > const & GetDevice(); // css::uno::XInterface DECLARE_XINTERFACE(); diff --git a/include/ucbhelper/interactionrequest.hxx b/include/ucbhelper/interactionrequest.hxx index ada7a1cf79dc..8d8f2c9191bf 100644 --- a/include/ucbhelper/interactionrequest.hxx +++ b/include/ucbhelper/interactionrequest.hxx @@ -122,7 +122,7 @@ public: * @return the continuation chosen by an interaction handler or an empty * reference, if the request was not (yet) handled. */ - rtl::Reference< InteractionContinuation > getSelection() const; + rtl::Reference< InteractionContinuation > const & getSelection() const; /** * This method sets a continuation for the request. It also can be used diff --git a/include/unotools/lingucfg.hxx b/include/unotools/lingucfg.hxx index 0f9acb9af6b4..294777955007 100644 --- a/include/unotools/lingucfg.hxx +++ b/include/unotools/lingucfg.hxx @@ -147,7 +147,7 @@ class UNOTOOLS_DLLPUBLIC SvtLinguConfig: public utl::detail::Options // configuration update access for the 'Linguistic' main node mutable css::uno::Reference< css::util::XChangesBatch > m_xMainUpdateAccess; - css::uno::Reference< css::util::XChangesBatch > GetMainUpdateAccess() const; + css::uno::Reference< css::util::XChangesBatch > const & GetMainUpdateAccess() const; OUString GetVendorImageUrl_Impl( const OUString &rServiceImplName, const OUString &rImageName ) const; diff --git a/include/unotools/localedatawrapper.hxx b/include/unotools/localedatawrapper.hxx index 419ac1517508..c63e8fc93553 100644 --- a/include/unotools/localedatawrapper.hxx +++ b/include/unotools/localedatawrapper.hxx @@ -175,7 +175,7 @@ public: MeasurementSystem mapMeasurementStringToEnum( const OUString& rMS ) const; /// Convenience method to obtain the default calendar. - const std::shared_ptr< css::i18n::Calendar2 > getDefaultCalendar() const; + const std::shared_ptr< css::i18n::Calendar2 >& getDefaultCalendar() const; /// Convenience method to obtain the day names of the default calendar. const css::uno::Sequence< css::i18n::CalendarItem2 > getDefaultCalendarDays() const; diff --git a/include/vbahelper/vbahelper.hxx b/include/vbahelper/vbahelper.hxx index d78932e1e583..d39ced5bbdbb 100644 --- a/include/vbahelper/vbahelper.hxx +++ b/include/vbahelper/vbahelper.hxx @@ -81,7 +81,7 @@ namespace ooo VBAHELPER_DLLPUBLIC css::uno::Reference< css::frame::XModel > getCurrentWordDoc( const css::uno::Reference< css::uno::XComponentContext >& xContext ) throw (css::uno::RuntimeException); VBAHELPER_DLLPUBLIC css::uno::Reference< css::beans::XIntrospectionAccess > getIntrospectionAccess( const css::uno::Any& aObject ) throw (css::uno::RuntimeException); - VBAHELPER_DLLPUBLIC css::uno::Reference< css::script::XTypeConverter > getTypeConverter( const css::uno::Reference< css::uno::XComponentContext >& xContext ) throw (css::uno::RuntimeException); + VBAHELPER_DLLPUBLIC css::uno::Reference< css::script::XTypeConverter > const & getTypeConverter( const css::uno::Reference< css::uno::XComponentContext >& xContext ) throw (css::uno::RuntimeException); VBAHELPER_DLLPUBLIC void dispatchRequests( const css::uno::Reference< css::frame::XModel>& xModel, const OUString& aUrl ); VBAHELPER_DLLPUBLIC void dispatchRequests (const css::uno::Reference< css::frame::XModel>& xModel, const OUString & aUrl, const css::uno::Sequence< css::beans::PropertyValue >& sProps ); diff --git a/include/vbahelper/vbashaperange.hxx b/include/vbahelper/vbashaperange.hxx index ee9ec7c646f0..2e6936020b05 100644 --- a/include/vbahelper/vbashaperange.hxx +++ b/include/vbahelper/vbashaperange.hxx @@ -60,7 +60,7 @@ protected: css::uno::Reference< css::frame::XModel > m_xModel; virtual OUString getServiceImplName() override; virtual css::uno::Sequence<OUString> getServiceNames() override; - css::uno::Reference< css::drawing::XShapes > getShapes() throw (css::uno::RuntimeException) ; + css::uno::Reference< css::drawing::XShapes > const & getShapes() throw (css::uno::RuntimeException) ; public: ScVbaShapeRange( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext >& xContext, const css::uno::Reference< css::container::XIndexAccess >& xShapes, const css::uno::Reference< css::drawing::XDrawPage>& xDrawShape, const css::uno::Reference< css::frame::XModel >& xModel ); diff --git a/include/vcl/commandinfoprovider.hxx b/include/vcl/commandinfoprovider.hxx index 2560745c9d58..4f76dbe1af7f 100644 --- a/include/vcl/commandinfoprovider.hxx +++ b/include/vcl/commandinfoprovider.hxx @@ -119,10 +119,10 @@ public: CommandInfoProvider(); ~CommandInfoProvider(); - css::uno::Reference<css::ui::XAcceleratorConfiguration> GetDocumentAcceleratorConfiguration(); - css::uno::Reference<css::ui::XAcceleratorConfiguration> GetModuleAcceleratorConfiguration(); - css::uno::Reference<css::ui::XAcceleratorConfiguration> GetGlobalAcceleratorConfiguration(); - OUString GetModuleIdentifier(); + css::uno::Reference<css::ui::XAcceleratorConfiguration> const & GetDocumentAcceleratorConfiguration(); + css::uno::Reference<css::ui::XAcceleratorConfiguration> const & GetModuleAcceleratorConfiguration(); + css::uno::Reference<css::ui::XAcceleratorConfiguration> const & GetGlobalAcceleratorConfiguration(); + OUString const & GetModuleIdentifier(); css::uno::Sequence<css::beans::PropertyValue> GetCommandProperties ( const OUString& rsCommandName); OUString GetCommandProperty(const OUString& rsProperty, const OUString& rsCommandName); diff --git a/include/vcl/edit.hxx b/include/vcl/edit.hxx index c78ea3ad18c3..28c29af61c9e 100644 --- a/include/vcl/edit.hxx +++ b/include/vcl/edit.hxx @@ -123,7 +123,7 @@ private: SAL_DLLPRIVATE void ImplCopy(css::uno::Reference<css::datatransfer::clipboard::XClipboard>& rxClipboard); SAL_DLLPRIVATE void ImplPaste(css::uno::Reference<css::datatransfer::clipboard::XClipboard>& rxClipboard); SAL_DLLPRIVATE long ImplGetTextYPosition() const; - SAL_DLLPRIVATE css::uno::Reference<css::i18n::XExtendedInputSequenceChecker > ImplGetInputSequenceChecker(); + SAL_DLLPRIVATE css::uno::Reference<css::i18n::XExtendedInputSequenceChecker > const & ImplGetInputSequenceChecker(); SAL_DLLPRIVATE css::uno::Reference<css::i18n::XBreakIterator > ImplGetBreakIterator() const; SAL_DLLPRIVATE void filterText(); diff --git a/include/vcl/helper.hxx b/include/vcl/helper.hxx index dcdcd923ba18..cbefea363676 100644 --- a/include/vcl/helper.hxx +++ b/include/vcl/helper.hxx @@ -40,7 +40,7 @@ void VCL_DLLPUBLIC getPrinterPathList( std::list< OUString >& rPathList, const c // note: gcc 3.4.1 warns about visibility if we retunr a const OUString& here // seems to be a bug in gcc, now we return an object instead of a reference -OUString VCL_DLLPUBLIC getFontPath(); +VCL_DLLPUBLIC OUString const & getFontPath(); bool VCL_DLLPUBLIC convertPfbToPfa( osl::File& rInFile, osl::File& rOutFile ); @@ -54,7 +54,7 @@ void VCL_DLLPUBLIC splitPath( OString& rOrgPath, OString& rDir, OString& rBase ) enum class whichOfficePath { InstallationRootPath, UserPath, ConfigPath }; // note: gcc 3.4.1 warns about visibility if we retunr a const OUString& here // seems to be a bug in gcc, now we return an object instead of a reference -OUString VCL_DLLPUBLIC getOfficePath( whichOfficePath ePath ); +VCL_DLLPUBLIC OUString const & getOfficePath( whichOfficePath ePath ); } // namespace diff --git a/include/vcl/layout.hxx b/include/vcl/layout.hxx index 59d7d6c6ae45..02fcaad564e9 100644 --- a/include/vcl/layout.hxx +++ b/include/vcl/layout.hxx @@ -665,8 +665,8 @@ public: virtual short Execute() override; ///Emitted when an action widget is clicked virtual void response(short nResponseId); - OUString get_primary_text() const; - OUString get_secondary_text() const; + OUString const & get_primary_text() const; + OUString const & get_secondary_text() const; void set_primary_text(const OUString &rPrimaryString); void set_secondary_text(const OUString &rSecondaryString); virtual ~MessageDialog(); diff --git a/include/vcl/longcurr.hxx b/include/vcl/longcurr.hxx index 7c03c0fd190a..011237c6d8ef 100644 --- a/include/vcl/longcurr.hxx +++ b/include/vcl/longcurr.hxx @@ -55,7 +55,7 @@ public: bool IsUseThousandSep() const { return mbThousandSep; } void SetCurrencySymbol( const OUString& rStr ); - OUString GetCurrencySymbol() const; + OUString const & GetCurrencySymbol() const; void SetMin(const BigInt& rNewMin); const BigInt& GetMin() const { return mnMin; } diff --git a/include/vcl/mnemonic.hxx b/include/vcl/mnemonic.hxx index 9822db32b458..9d5fa1944e27 100644 --- a/include/vcl/mnemonic.hxx +++ b/include/vcl/mnemonic.hxx @@ -65,7 +65,7 @@ public: void RegisterMnemonic( const OUString& rKey ); OUString CreateMnemonic( const OUString& rKey ); - css::uno::Reference< css::i18n::XCharacterClassification > GetCharClass(); + css::uno::Reference< css::i18n::XCharacterClassification > const & GetCharClass(); // returns a string where all '~'-characters and CJK mnemonics of the form (~A) are completely removed static OUString EraseAllMnemonicChars( const OUString& rStr ); diff --git a/include/vcl/tabctrl.hxx b/include/vcl/tabctrl.hxx index 5b26c830ecac..e162b19f6681 100644 --- a/include/vcl/tabctrl.hxx +++ b/include/vcl/tabctrl.hxx @@ -141,7 +141,7 @@ public: TabPage* GetTabPage( sal_uInt16 nPageId ) const; void SetPageText( sal_uInt16 nPageId, const OUString& rText ); - OUString GetPageText( sal_uInt16 nPageId ) const; + OUString const & GetPageText( sal_uInt16 nPageId ) const; void SetHelpText( sal_uInt16 nPageId, const OUString& rText ); const OUString& GetHelpText( sal_uInt16 nPageId ) const; diff --git a/include/vcl/texteng.hxx b/include/vcl/texteng.hxx index 5f2fda1a701f..400d08060264 100644 --- a/include/vcl/texteng.hxx +++ b/include/vcl/texteng.hxx @@ -159,7 +159,7 @@ protected: // gets not exported. First and second parameter swapped to have a different signatur. SAL_DLLPRIVATE TextPaM ImpInsertText( sal_Unicode c, const TextSelection& rSel, bool bOverwrite = false, bool bIsUserInput = false ); // some other new functions needed that must not be exported to remain compatible - SAL_DLLPRIVATE css::uno::Reference < css::i18n::XExtendedInputSequenceChecker > GetInputSequenceChecker(); + SAL_DLLPRIVATE css::uno::Reference< css::i18n::XExtendedInputSequenceChecker > const & GetInputSequenceChecker(); SAL_DLLPRIVATE bool IsInputSequenceCheckingRequired( sal_Unicode c, const TextSelection& rCurSel ) const; // broadcast or adjust selections @@ -306,8 +306,8 @@ public: void Draw( OutputDevice* pDev, const Point& rPos ); void SetLocale( const css::lang::Locale& rLocale ); - css::lang::Locale GetLocale(); - css::uno::Reference< css::i18n::XBreakIterator > GetBreakIterator(); + css::lang::Locale const & GetLocale(); + css::uno::Reference< css::i18n::XBreakIterator > const & GetBreakIterator(); static bool DoesKeyChangeText( const KeyEvent& rKeyEvent ); static bool IsSimpleCharInput( const KeyEvent& rKeyEvent ); diff --git a/include/xmloff/xmlexp.hxx b/include/xmloff/xmlexp.hxx index 48aebd413bfc..6ba10d56828e 100644 --- a/include/xmloff/xmlexp.hxx +++ b/include/xmloff/xmlexp.hxx @@ -425,27 +425,27 @@ public: } // get export helper for text - inline rtl::Reference< XMLTextParagraphExport > GetTextParagraphExport(); + inline rtl::Reference< XMLTextParagraphExport > const & GetTextParagraphExport(); // get export helper for shapes - inline rtl::Reference< XMLShapeExport > GetShapeExport(); + inline rtl::Reference< XMLShapeExport > const & GetShapeExport(); // get auto style pool - inline rtl::Reference< SvXMLAutoStylePoolP > GetAutoStylePool(); + inline rtl::Reference< SvXMLAutoStylePoolP > const & GetAutoStylePool(); // get Page Export - inline rtl::Reference< XMLPageExport > GetPageExport(); + inline rtl::Reference< XMLPageExport > const & GetPageExport(); // get chart export helper - inline rtl::Reference< SchXMLExportHelper > GetChartExport(); + inline rtl::Reference< SchXMLExportHelper > const & GetChartExport(); // get font auto style pool - inline rtl::Reference< XMLFontAutoStylePool > GetFontAutoStylePool(); + inline rtl::Reference< XMLFontAutoStylePool > const & GetFontAutoStylePool(); ProgressBarHelper* GetProgressBarHelper(); // get Formlayer Export - inline rtl::Reference< xmloff::OFormLayerXMLExport > GetFormExport(); + inline rtl::Reference< xmloff::OFormLayerXMLExport > const & GetFormExport(); inline bool HasFormExport(); // get XPropertySet with export information @@ -564,7 +564,7 @@ public: bool SetNullDateOnUnitConverter(); }; -inline rtl::Reference< XMLTextParagraphExport > SvXMLExport::GetTextParagraphExport() +inline rtl::Reference< XMLTextParagraphExport > const & SvXMLExport::GetTextParagraphExport() { if( !mxTextParagraphExport.is() ) mxTextParagraphExport = CreateTextParagraphExport(); @@ -572,7 +572,7 @@ inline rtl::Reference< XMLTextParagraphExport > SvXMLExport::GetTextParagraphExp return mxTextParagraphExport; } -inline rtl::Reference< XMLShapeExport > SvXMLExport::GetShapeExport() +inline rtl::Reference< XMLShapeExport > const & SvXMLExport::GetShapeExport() { if( !mxShapeExport.is() ) mxShapeExport = CreateShapeExport(); @@ -580,7 +580,7 @@ inline rtl::Reference< XMLShapeExport > SvXMLExport::GetShapeExport() return mxShapeExport; } -inline rtl::Reference< SvXMLAutoStylePoolP > SvXMLExport::GetAutoStylePool() +inline rtl::Reference< SvXMLAutoStylePoolP > const & SvXMLExport::GetAutoStylePool() { if( !mxAutoStylePool.is() ) mxAutoStylePool = CreateAutoStylePool(); @@ -588,7 +588,7 @@ inline rtl::Reference< SvXMLAutoStylePoolP > SvXMLExport::GetAutoStylePool() return mxAutoStylePool; } -inline rtl::Reference< SchXMLExportHelper > SvXMLExport::GetChartExport() +inline rtl::Reference< SchXMLExportHelper > const & SvXMLExport::GetChartExport() { if( !mxChartExport.is() ) mxChartExport = CreateChartExport(); @@ -596,7 +596,7 @@ inline rtl::Reference< SchXMLExportHelper > SvXMLExport::GetChartExport() return mxChartExport; } -inline rtl::Reference< XMLPageExport > SvXMLExport::GetPageExport() +inline rtl::Reference< XMLPageExport > const & SvXMLExport::GetPageExport() { if( !mxPageExport.is() ) mxPageExport = CreatePageExport(); @@ -604,7 +604,7 @@ inline rtl::Reference< XMLPageExport > SvXMLExport::GetPageExport() return mxPageExport; } -inline rtl::Reference< XMLFontAutoStylePool > SvXMLExport::GetFontAutoStylePool() +inline rtl::Reference< XMLFontAutoStylePool > const & SvXMLExport::GetFontAutoStylePool() { if( !mxFontAutoStylePool.is() ) mxFontAutoStylePool = CreateFontAutoStylePool(); @@ -612,7 +612,7 @@ inline rtl::Reference< XMLFontAutoStylePool > SvXMLExport::GetFontAutoStylePool( return mxFontAutoStylePool; } -inline rtl::Reference< xmloff::OFormLayerXMLExport > SvXMLExport::GetFormExport() +inline rtl::Reference< xmloff::OFormLayerXMLExport > const & SvXMLExport::GetFormExport() { if( !mxFormExport.is() ) mxFormExport = CreateFormExport(); diff --git a/include/xmloff/xmlimp.hxx b/include/xmloff/xmlimp.hxx index 7827177518fc..97bbf6ce8eca 100644 --- a/include/xmloff/xmlimp.hxx +++ b/include/xmloff/xmlimp.hxx @@ -296,18 +296,18 @@ public: virtual void SetStatistics(const css::uno::Sequence< css::beans::NamedValue > & i_rStats); // get import helper for text - inline rtl::Reference< XMLTextImportHelper > GetTextImport(); + inline rtl::Reference< XMLTextImportHelper > const & GetTextImport(); bool HasTextImport() const { return mxTextImport.is(); } inline SvXMLNumFmtHelper* GetDataStylesImport(); // get import helper for shapes - inline rtl::Reference< XMLShapeImportHelper > GetShapeImport(); + inline rtl::Reference< XMLShapeImportHelper > const & GetShapeImport(); // get import helper for charts - inline rtl::Reference< SchXMLImportHelper > GetChartImport(); + inline rtl::Reference< SchXMLImportHelper > const & GetChartImport(); // get import helper for form layer - inline rtl::Reference< ::xmloff::OFormLayerXMLImport > GetFormImport(); + inline rtl::Reference< ::xmloff::OFormLayerXMLImport > const & GetFormImport(); // get XPropertySet with import information const css::uno::Reference< css::beans::XPropertySet >& getImportInfo() const { return mxImportInfo; } @@ -520,7 +520,7 @@ public: bool needFixPositionAfterZ() const; }; -inline rtl::Reference< XMLTextImportHelper > SvXMLImport::GetTextImport() +inline rtl::Reference< XMLTextImportHelper > const & SvXMLImport::GetTextImport() { if( !mxTextImport.is() ) mxTextImport = CreateTextImport(); @@ -528,7 +528,7 @@ inline rtl::Reference< XMLTextImportHelper > SvXMLImport::GetTextImport() return mxTextImport; } -inline rtl::Reference< XMLShapeImportHelper > SvXMLImport::GetShapeImport() +inline rtl::Reference< XMLShapeImportHelper > const & SvXMLImport::GetShapeImport() { if( !mxShapeImport.is() ) mxShapeImport = CreateShapeImport(); @@ -536,7 +536,7 @@ inline rtl::Reference< XMLShapeImportHelper > SvXMLImport::GetShapeImport() return mxShapeImport; } -inline rtl::Reference< SchXMLImportHelper > SvXMLImport::GetChartImport() +inline rtl::Reference< SchXMLImportHelper > const & SvXMLImport::GetChartImport() { if( !mxChartImport.is() ) mxChartImport = CreateChartImport(); @@ -544,7 +544,7 @@ inline rtl::Reference< SchXMLImportHelper > SvXMLImport::GetChartImport() return mxChartImport; } -inline rtl::Reference< ::xmloff::OFormLayerXMLImport > SvXMLImport::GetFormImport() +inline rtl::Reference< ::xmloff::OFormLayerXMLImport > const & SvXMLImport::GetFormImport() { if( !mxFormImport.is() ) mxFormImport = CreateFormImport(); |