loplugin:constantparam in vcl..xmlscript

Change-Id: Icf66c08071b154259c9e551342d30331caf2b15a
Reviewed-on: https://gerrit.libreoffice.org/28685
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

10 files changed, 12 insertions, 19 deletions

diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx
index 9f63f136cbf1..e7d7b1c72b08 100644
--- a/include/vcl/outdev.hxx
+++ b/include/vcl/outdev.hxx
@@ -1951,8 +1951,7 @@ public:
 
     /** Query the native control to determine if it was acted upon
      */
-    bool                        HitTestNativeControl(
-                                    ControlType nType,
+    bool                        HitTestNativeScrollbar(
                                     ControlPart nPart,
                                     const Rectangle& rControlRegion,
                                     const Point& aPos,
diff --git a/include/vcl/popupmenuwindow.hxx b/include/vcl/popupmenuwindow.hxx
index bcff61640767..9184c3875838 100644
--- a/include/vcl/popupmenuwindow.hxx
+++ b/include/vcl/popupmenuwindow.hxx
@@ -28,7 +28,7 @@ private:
     struct ImplData;
     ImplData* mpImplData;
 public:
-    PopupMenuFloatingWindow( vcl::Window* pParent, WinBits nStyle = (WB_SYSTEMFLOATWIN|WB_SYSTEMWINDOW|WB_NOBORDER) );
+    PopupMenuFloatingWindow( vcl::Window* pParent );
     virtual ~PopupMenuFloatingWindow();
     virtual void dispose() override;
 
diff --git a/include/vcl/ppdparser.hxx b/include/vcl/ppdparser.hxx
index dd8afb060361..134bb9bf49fa 100644
--- a/include/vcl/ppdparser.hxx
+++ b/include/vcl/ppdparser.hxx
@@ -253,7 +253,7 @@ class VCL_DLLPUBLIC PPDContext
     bool checkConstraints( const PPDKey*, const PPDValue*, bool bDoReset );
     bool resetValue( const PPDKey*, bool bDefaultable = false );
 public:
-    PPDContext( const PPDParser* pParser = nullptr );
+    PPDContext();
     PPDContext( const PPDContext& rContext ) { operator=( rContext ); }
     PPDContext& operator=( const PPDContext& rContext );
     PPDContext& operator=( PPDContext&& rContext );
diff --git a/include/vcl/salnativewidgets.hxx b/include/vcl/salnativewidgets.hxx
index 54b42093de4e..61609ab4acd1 100644
--- a/include/vcl/salnativewidgets.hxx
+++ b/include/vcl/salnativewidgets.hxx
@@ -150,16 +150,16 @@ enum class ControlPart
 
 /*  #i77549#
     HACK: for scrollbars in case of thumb rect, page up and page down rect we
-    abuse the HitTestNativeControl interface. All theming engines but aqua
+    abuse the HitTestNativeScrollbar interface. All theming engines but aqua
     are actually able to draw the thumb according to our internal representation.
     However aqua draws a little outside. The canonical way would be to enhance the
-    HitTestNativeControl passing a ScrollbarValue additionally so all necessary
+    HitTestNativeScrollbar passing a ScrollbarValue additionally so all necessary
     information is available in the call.
     .
     However since there is only this one small exception we will deviate a little and
     instead pass the respective rect as control region to allow for a small correction.
 
-    So all places using HitTestNativeControl on ControlPart::ThumbHorz, ControlPart::ThumbVert,
+    So all places using HitTestNativeScrollbar on ControlPart::ThumbHorz, ControlPart::ThumbVert,
     ControlPart::TrackHorzLeft, ControlPart::TrackHorzRight, ControlPart::TrackVertUpper, ControlPart::TrackVertLower
     do not use the control rectangle as region but the actuall part rectangle, making
     only small deviations feasible.
diff --git a/include/vcl/scrbar.hxx b/include/vcl/scrbar.hxx
index 126701518d64..dd06512e1359 100644
--- a/include/vcl/scrbar.hxx
+++ b/include/vcl/scrbar.hxx
@@ -75,7 +75,7 @@ private:
     SAL_DLLPRIVATE long         ImplCalcThumbPos( long nPixPos );
     SAL_DLLPRIVATE long         ImplCalcThumbPosPix( long nPos );
     SAL_DLLPRIVATE void         ImplCalc( bool bUpdate = true );
-    SAL_DLLPRIVATE void         ImplDraw(vcl::RenderContext& rRenderContext, sal_uInt16 nDrawFlags);
+    SAL_DLLPRIVATE void         ImplDraw(vcl::RenderContext& rRenderContext);
     using Window::ImplScroll;
     SAL_DLLPRIVATE long         ImplScroll( long nNewPos, bool bCallEndScroll );
     SAL_DLLPRIVATE long         ImplDoAction( bool bCallEndScroll );
diff --git a/include/vcl/seleng.hxx b/include/vcl/seleng.hxx
index 32625a74aaaf..140952b10b0d 100644
--- a/include/vcl/seleng.hxx
+++ b/include/vcl/seleng.hxx
@@ -93,8 +93,7 @@ private:
 public:
 
                         SelectionEngine( vcl::Window* pWindow,
-                                         FunctionSet* pFunctions = nullptr,
-                                         sal_uLong nAutoRepeatInterval = SELENG_AUTOREPEAT_INTERVAL );
+                                         FunctionSet* pFunctions = nullptr );
                         ~SelectionEngine();
 
     // true: Event was processed by Selection Engine
diff --git a/include/vcl/textview.hxx b/include/vcl/textview.hxx
index f757651db086..bf9d229c114d 100644
--- a/include/vcl/textview.hxx
+++ b/include/vcl/textview.hxx
@@ -69,7 +69,7 @@ protected:
     TextPaM             ImpDelete( sal_uInt8 nMode, sal_uInt8 nDelMode );
     bool                IsInSelection( const TextPaM& rPaM );
 
-    void                ImpPaint(vcl::RenderContext& rRenderContext, const Point& rStartPos, Rectangle const* pPaintArea, TextSelection const* pPaintRange, TextSelection const* pSelection = nullptr);
+    void                ImpPaint(vcl::RenderContext& rRenderContext, const Point& rStartPos, Rectangle const* pPaintArea, TextSelection const* pSelection);
     void                ImpPaint(vcl::RenderContext& rRenderContext, const Rectangle& rRect);
     void                ImpShowCursor( bool bGotoCursor, bool bForceVisCursor, bool bEndKey );
     void                ImpHighlight( const TextSelection& rSel );
diff --git a/include/vcl/window.hxx b/include/vcl/window.hxx
index 0be3f77688d9..d69a66ce360c 100644
--- a/include/vcl/window.hxx
+++ b/include/vcl/window.hxx
@@ -1188,8 +1188,6 @@ public:
 
     // transparent background for selected or checked items in toolboxes etc.
     void                                DrawSelectionBackground( const Rectangle& rRect, sal_uInt16 highlight, bool bChecked, bool bDrawBorder );
-    // support rounded edges in the selection rect
-    void                                DrawSelectionBackground( const Rectangle& rRect, sal_uInt16 highlight, bool bChecked, bool bDrawBorder, Color* pSelectionTextColor, Color* pPaintColor );
 
     void                                ShowTracking( const Rectangle& rRect,
                                                       ShowTrackFlags nFlags = ShowTrackFlags::Small );
diff --git a/include/xmloff/XMLEventExport.hxx b/include/xmloff/XMLEventExport.hxx
index ae3bb90befd5..a411e6dfd877 100644
--- a/include/xmloff/XMLEventExport.hxx
+++ b/include/xmloff/XMLEventExport.hxx
@@ -68,8 +68,7 @@ class XMLOFF_DLLPUBLIC XMLEventExport
     bool bExtNamespace;
 
 public:
-    XMLEventExport(SvXMLExport& rExport,
-                   const XMLEventNameTranslation* pTranslationTable = nullptr);
+    XMLEventExport(SvXMLExport& rExport);
     ~XMLEventExport();
 
     /// register an EventExportHandler for a particular script type
diff --git a/include/xmloff/nmspmap.hxx b/include/xmloff/nmspmap.hxx
index 0a2849df7d8c..b2926d9f9293 100644
--- a/include/xmloff/nmspmap.hxx
+++ b/include/xmloff/nmspmap.hxx
@@ -147,11 +147,9 @@ public:
 /* deprecated */ sal_uInt16 GetKeyByAttrName( const OUString& rAttrName,
                              OUString *pPrefix,
                              OUString *pLocalName,
-                             OUString *pNamespace,
-                             sal_uInt16 nIdxGuess = USHRT_MAX ) const;
+                             OUString *pNamespace ) const;
 /* deprecated */ sal_uInt16 GetKeyByAttrName( const OUString& rAttrName,
-                             OUString *pLocalName = nullptr,
-                             sal_uInt16 nIdxGuess = USHRT_MAX ) const;
+                             OUString *pLocalName = nullptr ) const;
 };
 
 #endif // INCLUDED_XMLOFF_NMSPMAP_HXX