loplugin:constantparam in svx

Change-Id: I50fa7e4c7525d2f8107a11d8203957a47680eb80
Reviewed-on: https://gerrit.libreoffice.org/23303
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

22 files changed, 33 insertions, 47 deletions

diff --git a/include/svx/fmmodel.hxx b/include/svx/fmmodel.hxx
index cdc0e7f57b95..ea77ff38486e 100644
--- a/include/svx/fmmodel.hxx
+++ b/include/svx/fmmodel.hxx
@@ -83,7 +83,7 @@ public:
     FmXUndoEnvironment& GetUndoEnv();
 
 private:
-    void        implSetOpenInDesignMode( bool _bOpenDesignMode, bool _bForce );
+    void        implSetOpenInDesignMode( bool _bOpenDesignMode );
 };
 
 #endif          // _FM_FMMODEL_HXX
diff --git a/include/svx/framelinkarray.hxx b/include/svx/framelinkarray.hxx
index 426ad58acb05..68a335d9503d 100644
--- a/include/svx/framelinkarray.hxx
+++ b/include/svx/framelinkarray.hxx
@@ -148,20 +148,16 @@ public:
     const Style&        GetCellStyleBottom( size_t nCol, size_t nRow ) const;
 
     /** Returns the top-left to bottom-right frame style of the cell (nCol,nRow).
-        @param bSimple
-            true = Ignores merged ranges;
-            false = Returns the visible style (i.e. from top-left corner of a merged range).
+        Ignores merged ranges;
         @return
             The top-left to bottom-right frame style or an invisible style for invalid cell addresses. */
-    const Style&        GetCellStyleTLBR( size_t nCol, size_t nRow, bool bSimple = false ) const;
+    const Style&        GetCellStyleTLBR( size_t nCol, size_t nRow ) const;
 
     /** Returns the bottom-left to top-right frame style of the cell (nCol,nRow).
-        @param bSimple
-            true = Ignores merged ranges;
-            false = Returns the visible style (i.e. from top-left corner of a merged range).
+        Ignores merged ranges;
         @return
             The bottom-left to top-right frame style or an invisible style for invalid cell addresses. */
-    const Style&        GetCellStyleBLTR( size_t nCol, size_t nRow, bool bSimple = false ) const;
+    const Style&        GetCellStyleBLTR( size_t nCol, size_t nRow ) const;
 
     /** Returns the top-left to bottom-right frame style of the cell (nCol,nRow).
         @return
diff --git a/include/svx/gridctrl.hxx b/include/svx/gridctrl.hxx
index 0f53cc4fc8d5..13fb9da90c9b 100644
--- a/include/svx/gridctrl.hxx
+++ b/include/svx/gridctrl.hxx
@@ -459,7 +459,7 @@ public:
     bool IsUpdating() const {return m_bUpdating;}
 
     void RowRemoved( long nRow, long nNumRows = 1, bool bDoPaint = true );
-    void RowInserted( long nRow, long nNumRows = 1, bool bDoPaint = true, bool bKeepSelection = false );
+    void RowInserted( long nRow, long nNumRows = 1, bool bDoPaint = true );
     void RowModified( long nRow, sal_uInt16 nColId = USHRT_MAX );
 
     void resetCurrentRow();
diff --git a/include/svx/langbox.hxx b/include/svx/langbox.hxx
index 5366f81f88a8..1f418f735708 100644
--- a/include/svx/langbox.hxx
+++ b/include/svx/langbox.hxx
@@ -122,7 +122,7 @@ protected:
 class SVX_DLLPUBLIC SvxLanguageBox : public ListBox, public SvxLanguageBoxBase
 {
 public:
-    SvxLanguageBox( vcl::Window* pParent, WinBits nBits, bool bCheck = false );
+    SvxLanguageBox( vcl::Window* pParent, WinBits nBits );
 
 private:
     SVX_DLLPRIVATE virtual sal_Int32    ImplInsertImgEntry( const OUString& rEntry, sal_Int32  nPos, bool bChecked ) override;
@@ -147,7 +147,7 @@ private:
 class SVX_DLLPUBLIC SvxLanguageComboBox : public ComboBox, public SvxLanguageBoxBase
 {
 public:
-    SvxLanguageComboBox( vcl::Window* pParent, WinBits nBits, bool bCheck = false );
+    SvxLanguageComboBox( vcl::Window* pParent, WinBits nBits );
 
     enum EditedAndValid
     {
diff --git a/include/svx/paraprev.hxx b/include/svx/paraprev.hxx
index 0353f18b27e0..65af55602416 100644
--- a/include/svx/paraprev.hxx
+++ b/include/svx/paraprev.hxx
@@ -61,7 +61,7 @@ protected:
     virtual void Paint(vcl::RenderContext& rRenderContext, const Rectangle& rRect) override;
     virtual Size GetOptimalSize() const override;
 
-    void DrawParagraph(vcl::RenderContext& rRenderContext, bool bAll);
+    void DrawParagraph(vcl::RenderContext& rRenderContext);
 
 public:
     SvxParaPrevWindow( vcl::Window* pParent, WinBits nBits);
diff --git a/include/svx/polygn3d.hxx b/include/svx/polygn3d.hxx
index e94931389711..388dfdea350d 100644
--- a/include/svx/polygn3d.hxx
+++ b/include/svx/polygn3d.hxx
@@ -46,8 +46,7 @@ public:
 
     E3dPolygonObj(
         E3dDefaultAttributes& rDefault,
-        const basegfx::B3DPolyPolygon& rPolyPoly3D,
-        bool bLinOnly=false);
+        const basegfx::B3DPolyPolygon& rPolyPoly3D);
 
     E3dPolygonObj();
     virtual ~E3dPolygonObj();
diff --git a/include/svx/rulritem.hxx b/include/svx/rulritem.hxx
index 70dade511030..8fbe96cd2ad0 100644
--- a/include/svx/rulritem.hxx
+++ b/include/svx/rulritem.hxx
@@ -239,8 +239,7 @@ private:
 public:
     static SfxPoolItem* CreateDefault();
     SvxObjectItem(long nStartX, long nEndX,
-                  long nStartY, long nEndY,
-                  bool bLimits = false);
+                  long nStartY, long nEndY);
     SvxObjectItem(const SvxObjectItem& rCopy);
 
     bool HasLimits() const { return bLimits;}
diff --git a/include/svx/sdr/animation/scheduler.hxx b/include/svx/sdr/animation/scheduler.hxx
index 1738ca5d1576..243d252a8c24 100644
--- a/include/svx/sdr/animation/scheduler.hxx
+++ b/include/svx/sdr/animation/scheduler.hxx
@@ -41,7 +41,7 @@ namespace sdr
 
         public:
             // constructor/destructor
-            SAL_DLLPRIVATE explicit Event(sal_uInt32 nTime);
+            SAL_DLLPRIVATE explicit Event();
             virtual ~Event();
 
             // access to mpNext
diff --git a/include/svx/svddrgmt.hxx b/include/svx/svddrgmt.hxx
index 6ce00e5f6303..cebb80a38293 100644
--- a/include/svx/svddrgmt.hxx
+++ b/include/svx/svddrgmt.hxx
@@ -90,8 +90,7 @@ private:
 
 public:
     SdrDragEntryPrimitive2DSequence(
-        const drawinglayer::primitive2d::Primitive2DContainer& rSequence,
-        bool bAddToTransparent);
+        const drawinglayer::primitive2d::Primitive2DContainer& rSequence);
     virtual ~SdrDragEntryPrimitive2DSequence();
 
     virtual drawinglayer::primitive2d::Primitive2DContainer createPrimitive2DSequenceInCurrentState(SdrDragMethod& rDragMethod) override;
@@ -129,7 +128,7 @@ protected:
     void clearSdrDragEntries();
     void addSdrDragEntry(SdrDragEntry* pNew);
     virtual void createSdrDragEntries();
-    virtual void createSdrDragEntryForSdrObject(const SdrObject& rOriginal, sdr::contact::ObjectContact& rObjectContact, bool bModify);
+    virtual void createSdrDragEntryForSdrObject(const SdrObject& rOriginal, sdr::contact::ObjectContact& rObjectContact);
 
     // access for derivated classes to maOverlayObjectList
     void clearOverlayObjectList() { maOverlayObjectList.clear(); }
@@ -229,7 +228,7 @@ private:
     void ImpCheckSnap(const Point& rPt);
 
 protected:
-    virtual void createSdrDragEntryForSdrObject(const SdrObject& rOriginal, sdr::contact::ObjectContact& rObjectContact, bool bModify) override;
+    virtual void createSdrDragEntryForSdrObject(const SdrObject& rOriginal, sdr::contact::ObjectContact& rObjectContact) override;
 
 public:
     SdrDragMove(SdrDragView& rNewView);
diff --git a/include/svx/svdglue.hxx b/include/svx/svdglue.hxx
index d73ed7ee9af2..bb91f9bc8cde 100644
--- a/include/svx/svdglue.hxx
+++ b/include/svx/svdglue.hxx
@@ -137,7 +137,7 @@ public:
     SdrGluePoint&       operator[](sal_uInt16 nPos)                             { return *GetObject(nPos); }
     const SdrGluePoint& operator[](sal_uInt16 nPos) const                       { return *GetObject(nPos); }
     sal_uInt16          FindGluePoint(sal_uInt16 nId) const;
-    sal_uInt16          HitTest(const Point& rPnt, const OutputDevice& rOut, const SdrObject* pObj, bool bBack = false, bool bNext = false, sal_uInt16 nId0=0) const;
+    sal_uInt16          HitTest(const Point& rPnt, const OutputDevice& rOut, const SdrObject* pObj) const;
     void                Invalidate(vcl::Window& rWin, const SdrObject* pObj) const;
     // temp for transformations on the reference object
     void                SetReallyAbsolute(bool bOn, const SdrObject& rObj);
diff --git a/include/svx/svditer.hxx b/include/svx/svditer.hxx
index f533ba6675d9..cfbec5fe920b 100644
--- a/include/svx/svditer.hxx
+++ b/include/svx/svditer.hxx
@@ -54,14 +54,14 @@ public:
             Otherwise the navigation position as returned by
             SdrObject::GetNavigationPosition() is used.
     */
-    SdrObjListIter(const SdrObjList& rObjList, bool bUseZOrder, SdrIterMode eMode = IM_DEEPNOGROUPS, bool bReverse = false);
+    SdrObjListIter(const SdrObjList& rObjList, bool bUseZOrder, SdrIterMode eMode = IM_DEEPNOGROUPS);
 
     /* SJ: the following function can now be used with every
        SdrObject and is no longer limited to group objects */
-    explicit SdrObjListIter(const SdrObject& rObj, SdrIterMode eMode = IM_DEEPNOGROUPS, bool bReverse = false);
+    explicit SdrObjListIter(const SdrObject& rObj, SdrIterMode eMode = IM_DEEPNOGROUPS);
 
     /** Iterates over a list of marked objects received from the SdrMarkView. */
-    explicit SdrObjListIter(const SdrMarkList& rMarkList, SdrIterMode eMode = IM_DEEPNOGROUPS, bool bReverse = false);
+    explicit SdrObjListIter(const SdrMarkList& rMarkList, SdrIterMode eMode = IM_DEEPNOGROUPS);
 
     void Reset() { mnIndex = (mbReverse ? maObjList.size() : 0L); }
     bool IsMore() const { return (mbReverse ? mnIndex != 0 : ( mnIndex < maObjList.size())); }
diff --git a/include/svx/svdmodel.hxx b/include/svx/svdmodel.hxx
index 07d7b35933f2..3e58f113c843 100644
--- a/include/svx/svdmodel.hxx
+++ b/include/svx/svdmodel.hxx
@@ -141,11 +141,6 @@ public:
 };
 
 
-// Flag for cleaning up after the loading of the pools, meaning the
-// recalculate the RefCounts and dispose unused items)
-// sal_False == active
-#define LOADREFCOUNTS (false)
-
 struct SdrModelImpl;
 
 class SVX_DLLPUBLIC SdrModel : public SfxBroadcaster, public tools::WeakBase< SdrModel >, public OutlinerSearchable
@@ -288,8 +283,8 @@ public:
     // If, however, you use objects inheriting from SdrObject you are free
     // to chose a pool of your liking.
     explicit SdrModel();
-    explicit SdrModel(SfxItemPool* pPool, ::comphelper::IEmbeddedHelper* pPers, bool bUseExtColorTable, bool bLoadRefCounts);
-    explicit SdrModel(const OUString& rPath, SfxItemPool* pPool, ::comphelper::IEmbeddedHelper* pPers, bool bUseExtColorTable, bool bLoadRefCounts);
+    explicit SdrModel(SfxItemPool* pPool, ::comphelper::IEmbeddedHelper* pPers, bool bUseExtColorTable);
+    explicit SdrModel(const OUString& rPath, SfxItemPool* pPool, ::comphelper::IEmbeddedHelper* pPers, bool bUseExtColorTable);
     virtual ~SdrModel();
     void ClearModel(bool bCalledFromDestructor);
 
diff --git a/include/svx/svdobj.hxx b/include/svx/svdobj.hxx
index 68a3d8553886..a73485a9b881 100644
--- a/include/svx/svdobj.hxx
+++ b/include/svx/svdobj.hxx
@@ -708,7 +708,7 @@ public:
     void SetMergedItemSetAndBroadcast(const SfxItemSet& rSet, bool bClearAllItems = false);
 
     // NotPersistAttr for Layer, ObjName, geometrical transformations etc.
-    void TakeNotPersistAttr(SfxItemSet& rAttr, bool bMerge) const;
+    void TakeNotPersistAttr(SfxItemSet& rAttr) const;
     void ApplyNotPersistAttr(const SfxItemSet& rAttr);
     void NbcApplyNotPersistAttr(const SfxItemSet& rAttr);
 
diff --git a/include/svx/svdoedge.hxx b/include/svx/svdoedge.hxx
index e14c5874a3b2..adb093e1f3a1 100644
--- a/include/svx/svdoedge.hxx
+++ b/include/svx/svdoedge.hxx
@@ -65,7 +65,7 @@ public:
     SVX_DLLPUBLIC ~SdrObjConnection();
 
     void ResetVars();
-    bool TakeGluePoint(SdrGluePoint& rGP, bool bSetAbsolutePos) const;
+    bool TakeGluePoint(SdrGluePoint& rGP) const;
 
     inline void SetBestConnection( bool rB ) { bBestConn = rB; };
     inline void SetBestVertex( bool rB ) { bBestVertex = rB; };
diff --git a/include/svx/svdoole2.hxx b/include/svx/svdoole2.hxx
index 0db25636b7ca..00525e60bc9b 100644
--- a/include/svx/svdoole2.hxx
+++ b/include/svx/svdoole2.hxx
@@ -67,7 +67,7 @@ public:
     OUString GetStyleString();
 
     SdrOle2Obj( bool bFrame_ = false );
-    SdrOle2Obj( const svt::EmbeddedObjectRef& rNewObjRef, const OUString& rNewObjName, const Rectangle& rNewRect, bool bFrame_ = false );
+    SdrOle2Obj( const svt::EmbeddedObjectRef& rNewObjRef, const OUString& rNewObjName, const Rectangle& rNewRect );
     virtual ~SdrOle2Obj();
 
     const svt::EmbeddedObjectRef& getEmbeddedObjectRef() const;
diff --git a/include/svx/svdopath.hxx b/include/svx/svdopath.hxx
index b1af6fb3f013..2d0340b68f5c 100644
--- a/include/svx/svdopath.hxx
+++ b/include/svx/svdopath.hxx
@@ -124,7 +124,7 @@ public:
     virtual void NbcSetPoint(const Point& rPnt, sal_uInt32 nHdlNum) override;
 
     // insert point
-    sal_uInt32 NbcInsPointOld(const Point& rPos, bool bNewObj, bool bHideHim);
+    sal_uInt32 NbcInsPointOld(const Point& rPos, bool bNewObj);
     sal_uInt32 NbcInsPoint(sal_uInt32 i, const Point& rPos, bool bNewObj, bool bHideHim);
 
     // rip at given point
diff --git a/include/svx/svdotable.hxx b/include/svx/svdotable.hxx
index f3162ed258ef..de68ed7589bf 100644
--- a/include/svx/svdotable.hxx
+++ b/include/svx/svdotable.hxx
@@ -126,7 +126,7 @@ public:
     const sdr::table::TableStyleSettings& getTableStyleSettings() const;
     void setTableStyleSettings( const sdr::table::TableStyleSettings& rStyle );
 
-    TableHitKind CheckTableHit( const Point& rPos, sal_Int32& rnX, sal_Int32& rnY, int nTol ) const;
+    TableHitKind CheckTableHit( const Point& rPos, sal_Int32& rnX, sal_Int32& rnY ) const;
 
     void uno_lock();
     void uno_unlock();
diff --git a/include/svx/svdundo.hxx b/include/svx/svdundo.hxx
index 21404446077d..23e65c69fd2f 100644
--- a/include/svx/svdundo.hxx
+++ b/include/svx/svdundo.hxx
@@ -550,7 +550,7 @@ protected:
 protected:
     SdrUndoPage(SdrPage& rNewPg);
 
-    static void ImpTakeDescriptionStr(sal_uInt16 nStrCacheID, OUString& rStr, sal_uInt16 n=0);
+    static void ImpTakeDescriptionStr(sal_uInt16 nStrCacheID, OUString& rStr);
 };
 
 /**
diff --git a/include/svx/svdviter.hxx b/include/svx/svdviter.hxx
index 56870623826f..f6f30a54f4a0 100644
--- a/include/svx/svdviter.hxx
+++ b/include/svx/svdviter.hxx
@@ -81,8 +81,8 @@ private:
     SVX_DLLPRIVATE bool          ImpCheckPageView(SdrPageView* pPV) const;
 
 public:
-    SdrViewIter(const SdrPage* pPage, bool bNoMasterPage = false);
-    SdrViewIter(const SdrObject* pObject, bool bNoMasterPage = false);
+    SdrViewIter(const SdrPage* pPage);
+    SdrViewIter(const SdrObject* pObject);
 
     SdrView* FirstView();
     SdrView* NextView();
diff --git a/include/svx/svxdlg.hxx b/include/svx/svxdlg.hxx
index e5f9aef610eb..cc51715258c0 100644
--- a/include/svx/svxdlg.hxx
+++ b/include/svx/svxdlg.hxx
@@ -373,10 +373,10 @@ public:
                                                 double nRadius)=0;
     virtual AbstractGraphicFilterDialog *   CreateGraphicFilterSolarize (vcl::Window* pParent,
                                                 const Graphic& rGraphic,
-                                                sal_uInt8 nGreyThreshold, bool bInvert)=0;
+                                                sal_uInt8 nGreyThreshold)=0;
     virtual AbstractGraphicFilterDialog *   CreateGraphicFilterMosaic (vcl::Window* pParent,
                                                 const Graphic& rGraphic,
-                                                sal_uInt16 nTileWidth, sal_uInt16 nTileHeight, bool bEnhanceEdges)=0;
+                                                sal_uInt16 nTileWidth, sal_uInt16 nTileHeight)=0;
     virtual AbstractSvxAreaTabDialog*       CreateSvxAreaTabDialog( vcl::Window* pParent,
                                                             const SfxItemSet* pAttr,
                                                             SdrModel* pModel,
diff --git a/include/svx/txencbox.hxx b/include/svx/txencbox.hxx
index aaf95753b715..1f8f483306e3 100644
--- a/include/svx/txencbox.hxx
+++ b/include/svx/txencbox.hxx
@@ -75,8 +75,7 @@ public:
             <TRUE/> whenever the box is used in import dialogs. */
     void                FillFromDbTextEncodingMap(
                             bool bExcludeImportSubsets = false,
-                            sal_uInt32 nExcludeInfoFlags = 0,
-                            sal_uInt32 nButIncludeInfoFlags = 0
+                            sal_uInt32 nExcludeInfoFlags = 0
                             );
 
     /** Fill with all known MIME encodings and select the best according to
diff --git a/include/svx/xmlgrhlp.hxx b/include/svx/xmlgrhlp.hxx
index f6a969000ca1..f71549a8237b 100644
--- a/include/svx/xmlgrhlp.hxx
+++ b/include/svx/xmlgrhlp.hxx
@@ -71,8 +71,7 @@ private:
                                             ImplGetGraphicStorage( const OUString& rPictureStorageName );
     SVX_DLLPRIVATE SvxGraphicHelperStream_Impl
                                             ImplGetGraphicStream( const OUString& rPictureStorageName,
-                                                      const OUString& rPictureStreamName,
-                                                      bool bTruncate );
+                                                      const OUString& rPictureStreamName );
     SVX_DLLPRIVATE OUString                 ImplGetGraphicMimeType( const OUString& rFileName ) const;
     SVX_DLLPRIVATE Graphic                  ImplReadGraphic( const OUString& rPictureStorageName,
                                                  const OUString& rPictureStreamName );