loplugin:constparams improve handling of pointer params

Change-Id: I4c0002e72703eded435bfe4985f5b0121bf8524b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122843
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

11 files changed, 14 insertions, 13 deletions

diff --git a/include/filter/msfilter/svdfppt.hxx b/include/filter/msfilter/svdfppt.hxx
index fbb0896d71d1..e8bce27fffae 100644
--- a/include/filter/msfilter/svdfppt.hxx
+++ b/include/filter/msfilter/svdfppt.hxx
@@ -1022,7 +1022,7 @@ struct PPTTextRulerInterpreter
         bool        GetTextOfs( sal_uInt32 nLevel, sal_uInt16& nValue ) const;
         bool        GetBulletOfs( sal_uInt32 nLevel, sal_uInt16& nValue ) const;
 
-        PPTTextRulerInterpreter& operator=( PPTTextRulerInterpreter& rRuler );
+        PPTTextRulerInterpreter& operator=( const PPTTextRulerInterpreter& rRuler );
 };
 
 #define PPT_SPEC_NEWLINE            0x10000
@@ -1269,7 +1269,7 @@ public:
 
     const SfxItemSet*       GetBackground() const;
 
-    PPTTextObj&             operator=( PPTTextObj& rTextObj );
+    PPTTextObj&             operator=( const PPTTextObj& rTextObj );
 };
 
 class PPTConvertOCXControls final : public SvxMSConvertOCXControls
diff --git a/include/oox/drawingml/shape.hxx b/include/oox/drawingml/shape.hxx
index 1abc9c0a211a..96686f26f03c 100644
--- a/include/oox/drawingml/shape.hxx
+++ b/include/oox/drawingml/shape.hxx
@@ -187,7 +187,7 @@ public:
                             const Theme* pTheme,
                             const css::uno::Reference< css::drawing::XShapes >& rxShapes,
                             const basegfx::B2DHomMatrix& aTransformation,
-                            FillProperties& rShapeOrParentShapeFillProps,
+                            const FillProperties& rShapeOrParentShapeFillProps,
                             ShapeIdMap* pShapeMap = nullptr,
                             oox::drawingml::ShapePtr pParentGroupShape = nullptr);
 
@@ -265,7 +265,7 @@ protected:
                             bool bClearText,
                             bool bDoNotInsertEmptyTextBody,
                             basegfx::B2DHomMatrix& aTransformation,
-                            FillProperties& rShapeOrParentShapeFillProps,
+                            const FillProperties& rShapeOrParentShapeFillProps,
                             oox::drawingml::ShapePtr pParentGroupShape = nullptr
                              );
 
diff --git a/include/sfx2/childwin.hxx b/include/sfx2/childwin.hxx
index cccfa4d87a0b..66d125accaf5 100644
--- a/include/sfx2/childwin.hxx
+++ b/include/sfx2/childwin.hxx
@@ -152,7 +152,7 @@ public:
     SAL_DLLPRIVATE void SetWorkWindow_Impl( SfxWorkWindow* );
     SAL_DLLPRIVATE void Activate_Impl();
 
-    SAL_DLLPRIVATE void SetFactory_Impl( SfxChildWinFactory* );
+    SAL_DLLPRIVATE void SetFactory_Impl( const SfxChildWinFactory* );
 };
 
 
diff --git a/include/sfx2/frame.hxx b/include/sfx2/frame.hxx
index 26af0c08f957..26560b3db1f6 100644
--- a/include/sfx2/frame.hxx
+++ b/include/sfx2/frame.hxx
@@ -134,7 +134,7 @@ public:
     SAL_DLLPRIVATE void CreateWorkWindow_Impl();
     SAL_DLLPRIVATE void GrabFocusOnComponent_Impl();
 
-    SAL_DLLPRIVATE void PrepareForDoc_Impl( SfxObjectShell& i_rDoc );
+    SAL_DLLPRIVATE void PrepareForDoc_Impl( const SfxObjectShell& i_rDoc );
     SAL_DLLPRIVATE void LockResize_Impl( bool bLock );
     SAL_DLLPRIVATE void SetMenuBarOn_Impl( bool bOn );
     SAL_DLLPRIVATE bool IsMenuBarOn_Impl() const;
diff --git a/include/sfx2/viewsh.hxx b/include/sfx2/viewsh.hxx
index f0d3938fe677..64b56e1c1293 100644
--- a/include/sfx2/viewsh.hxx
+++ b/include/sfx2/viewsh.hxx
@@ -296,7 +296,7 @@ public:
     void                        SetController( SfxBaseController* pController );
     css::uno::Reference<css::frame::XController> GetController() const;
 
-    bool                        TryContextMenuInterception( Menu& rIn, const OUString& rMenuIdentifier, VclPtr<Menu>& rpOut, css::ui::ContextMenuExecuteEvent aEvent );
+    bool                        TryContextMenuInterception( const Menu& rIn, const OUString& rMenuIdentifier, VclPtr<Menu>& rpOut, css::ui::ContextMenuExecuteEvent aEvent );
     bool                        TryContextMenuInterception( Menu& rMenu, const OUString& rMenuIdentifier, css::ui::ContextMenuExecuteEvent aEvent );
 
     void                        ExecPrint( const css::uno::Sequence < css::beans::PropertyValue >&, bool, bool );
diff --git a/include/svx/svdedtv.hxx b/include/svx/svdedtv.hxx
index 5d834d05bde7..a21eeb3e0a43 100644
--- a/include/svx/svdedtv.hxx
+++ b/include/svx/svdedtv.hxx
@@ -189,7 +189,7 @@ public:
      */
     void EndTextEditAllViews() const;
 
-    std::vector< std::unique_ptr<SdrUndoAction> > CreateConnectorUndo( SdrObject& rO );
+    std::vector< std::unique_ptr<SdrUndoAction> > CreateConnectorUndo( const SdrObject& rO );
     void AddUndoActions( std::vector< std::unique_ptr<SdrUndoAction> > );
 
     // Layermanagement with Undo.
diff --git a/include/svx/svdpagv.hxx b/include/svx/svdpagv.hxx
index 3aceb48d1d4b..2f77dfa6692a 100644
--- a/include/svx/svdpagv.hxx
+++ b/include/svx/svdpagv.hxx
@@ -87,7 +87,7 @@ private:
 
 public:
     sal_uInt32 PageWindowCount() const { return maPageWindows.size(); }
-    SdrPageWindow* FindPageWindow( SdrPaintWindow& rPaintWindow ) const;
+    SdrPageWindow* FindPageWindow( const SdrPaintWindow& rPaintWindow ) const;
     SdrPageWindow* FindPageWindow( const OutputDevice& rOutDev ) const;
     SdrPageWindow* GetPageWindow(sal_uInt32 nIndex) const;
 
diff --git a/include/svx/svdpntv.hxx b/include/svx/svdpntv.hxx
index 048c5f6b5cd8..66c1e33e378b 100644
--- a/include/svx/svdpntv.hxx
+++ b/include/svx/svdpntv.hxx
@@ -210,7 +210,7 @@ protected:
     Color                           maGridColor;
 
     // Interface to SdrPaintWindow
-    void DeletePaintWindow(SdrPaintWindow& rOld);
+    void DeletePaintWindow(const SdrPaintWindow& rOld);
     void ConfigurationChanged( ::utl::ConfigurationBroadcaster*, ConfigurationHints ) override;
     static void InitOverlayManager(rtl::Reference<sdr::overlay::OverlayManager> xOverlayManager);
 
diff --git a/include/svx/svdtext.hxx b/include/svx/svdtext.hxx
index b3c5cbbf90ec..727273454905 100644
--- a/include/svx/svdtext.hxx
+++ b/include/svx/svdtext.hxx
@@ -54,7 +54,7 @@ public:
     OutlinerParaObject* GetOutlinerParaObject();
     const OutlinerParaObject* GetOutlinerParaObject() const;
 
-    void CheckPortionInfo(SdrOutliner& rOutliner);
+    void CheckPortionInfo(const SdrOutliner& rOutliner);
     void ReformatText();
 
     // default uses GetObjectItemSet, but may be overridden to
diff --git a/include/vcl/weldutils.hxx b/include/vcl/weldutils.hxx
index b75b94d99e52..8cb591ce8140 100644
--- a/include/vcl/weldutils.hxx
+++ b/include/vcl/weldutils.hxx
@@ -425,7 +425,8 @@ VCL_DLLPUBLIC size_t GetAbsPos(const weld::TreeView& rTreeView, const weld::Tree
 VCL_DLLPUBLIC bool IsEntryVisible(const weld::TreeView& rTreeView, const weld::TreeIter& rIter);
 
 // A Parent's Children are turned into Children of the Parent which comes next in hierarchy
-VCL_DLLPUBLIC void RemoveParentKeepChildren(weld::TreeView& rTreeView, weld::TreeIter& rParent);
+VCL_DLLPUBLIC void RemoveParentKeepChildren(weld::TreeView& rTreeView,
+                                            const weld::TreeIter& rParent);
 
 // return the min height of a weld::Entry
 VCL_DLLPUBLIC int GetMinimumEditHeight();
diff --git a/include/vcl/window.hxx b/include/vcl/window.hxx
index 834f6a2d205c..ce2464a1e976 100644
--- a/include/vcl/window.hxx
+++ b/include/vcl/window.hxx
@@ -572,7 +572,7 @@ protected:
 
     SAL_DLLPRIVATE Point                ImplOutputToFrame( const Point& rPos );
 
-    SAL_DLLPRIVATE void                 ImplInvalidateParentFrameRegion( vcl::Region& rRegion );
+    SAL_DLLPRIVATE void                 ImplInvalidateParentFrameRegion( const vcl::Region& rRegion );
     SAL_DLLPRIVATE void                 ImplValidateFrameRegion( const vcl::Region* rRegion, ValidateFlags nFlags );
     SAL_DLLPRIVATE void                 ImplValidate();
     SAL_DLLPRIVATE void                 ImplMoveInvalidateRegion( const tools::Rectangle& rRect, tools::Long nHorzScroll, tools::Long nVertScroll, bool bChildren );