summaryrefslogtreecommitdiff
path: root/include
diff options
context:
space:
mode:
authorKatarina Behrens <bubli@bubli.org>2021-07-26 08:34:38 +0200
committerXisco Fauli <xiscofauli@libreoffice.org>2021-08-09 22:02:57 +0200
commite793eb0acc8f95941eaf6bf82f39a3a6185d7142 (patch)
tree6d918d28f03ea2e92653b10432890dcccc6c60dc /include
parentd366fc7861a4226d053beb4b21ba665d7c7660f5 (diff)
tdf#142817: Correctly replace animation effect that comes with a command
As effect1 with command (e.g. the one from misc/MEDIACALL category) is created, 'mnCommand' member var is set. But when it is replaced by command-less effect2 via CustomAnnimationEffect::replaceNode, this var is never reset (simply because the relevant if-else branch is never hit) so it looks as if the command was still there. This causes UI glitch in sidebar: setting incorrect category of the next selected effect To fix that, we reset 'mnCommand' in ::setNode function, just as it is done with resetting audio associated w/ the effect Change-Id: I86016dd1acadfb31f460bde749bbe15164f1eb81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119492 Tested-by: Jenkins Reviewed-by: Katarina Behrens <bubli@bubli.org> (cherry picked from commit 6146b185ab2a335de39d0562a8d34e53d3e742e0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120236 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions