tdf#42949 Fix IWYU warnings in include/vcl/s*

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Ie87d27dd2c385a63349e0b322fd067ba03d2d152
Reviewed-on: https://gerrit.libreoffice.org/64479
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

18 files changed, 19 insertions, 50 deletions

diff --git a/include/sfx2/viewsh.hxx b/include/sfx2/viewsh.hxx
index 67a304a14873..be6af0fe68ba 100644
--- a/include/sfx2/viewsh.hxx
+++ b/include/sfx2/viewsh.hxx
@@ -35,6 +35,7 @@
 #include <sfx2/shell.hxx>
 #include <sfx2/viewfac.hxx>
 #include <tools/gen.hxx>
+#include <i18nlangtag/languagetag.hxx>
 #include <vcl/IDialogRenderable.hxx>
 #include <vcl/errcode.hxx>
 #include <vcl/jobset.hxx>
diff --git a/include/vcl/salbtype.hxx b/include/vcl/salbtype.hxx
index ac2f283e7172..e20342f19184 100644
--- a/include/vcl/salbtype.hxx
+++ b/include/vcl/salbtype.hxx
@@ -20,17 +20,14 @@
 #ifndef INCLUDED_VCL_SALBTYPE_HXX
 #define INCLUDED_VCL_SALBTYPE_HXX
 
-#include <tools/debug.hxx>
 #include <vcl/checksum.hxx>
-#include <vcl/salgtype.hxx>
-#include <tools/helpers.hxx>
 #include <tools/color.hxx>
-#include <tools/solar.h>
 #include <vcl/dllapi.h>
 #include <o3tl/typed_flags_set.hxx>
 #include <vector>
 #include <memory>
 
+struct SalTwoRect;
 typedef sal_uInt8*        Scanline;
 typedef const sal_uInt8*  ConstScanline;
 
@@ -85,8 +82,6 @@ d_Col = BitmapColor( static_cast<sal_uInt8>( _def_cR | ( ( _def_cR & maR.mnOr )
     d_ALPHA )
 
 
-class Color;
-
 class VCL_DLLPUBLIC BitmapColor final
 {
 private:
@@ -142,8 +137,6 @@ inline std::basic_ostream<charT, traits>& operator <<(std::basic_ostream<charT,
         << static_cast<int>(rColor.GetGreen()) << ", mcRed: " << static_cast<int>(rColor.GetRed()) << ", mcAlpha: " << static_cast<int>(rColor.GetAlpha());
 }
 
-class Palette;
-
 class VCL_DLLPUBLIC BitmapPalette
 {
     friend class SalBitmap;
diff --git a/include/vcl/salgtype.hxx b/include/vcl/salgtype.hxx
index a373a0a62d07..3c1f59512586 100644
--- a/include/vcl/salgtype.hxx
+++ b/include/vcl/salgtype.hxx
@@ -20,7 +20,6 @@
 #ifndef INCLUDED_VCL_SALGTYPE_HXX
 #define INCLUDED_VCL_SALGTYPE_HXX
 
-#include <sal/types.h>
 #include <o3tl/typed_flags_set.hxx>
 #include <tools/color.hxx>
 #include <tools/gen.hxx>
diff --git a/include/vcl/salnativewidgets.hxx b/include/vcl/salnativewidgets.hxx
index a9a572731e3c..0d90027e8fb6 100644
--- a/include/vcl/salnativewidgets.hxx
+++ b/include/vcl/salnativewidgets.hxx
@@ -20,7 +20,6 @@
 #ifndef INCLUDED_VCL_SALNATIVEWIDGETS_HXX
 #define INCLUDED_VCL_SALNATIVEWIDGETS_HXX
 
-#include <rtl/ustring.hxx>
 #include <vcl/dllapi.h>
 #include <tools/gen.hxx>
 #include <o3tl/typed_flags_set.hxx>
diff --git a/include/vcl/scheduler.hxx b/include/vcl/scheduler.hxx
index 0d0d58962185..96979cf5d3c5 100644
--- a/include/vcl/scheduler.hxx
+++ b/include/vcl/scheduler.hxx
@@ -22,11 +22,7 @@
 
 #include <vcl/dllapi.h>
 
-class SchedulerGuard;
-class Task;
-struct TaskImpl;
 struct ImplSchedulerContext;
-struct ImplSchedulerData;
 
 class VCL_DLLPUBLIC Scheduler final
 {
diff --git a/include/vcl/scrbar.hxx b/include/vcl/scrbar.hxx
index 5fadfb5fbe0d..e900b26b152e 100644
--- a/include/vcl/scrbar.hxx
+++ b/include/vcl/scrbar.hxx
@@ -20,13 +20,10 @@
 #ifndef INCLUDED_VCL_SCRBAR_HXX
 #define INCLUDED_VCL_SCRBAR_HXX
 
-#include <tools/solar.h>
 #include <vcl/dllapi.h>
 #include <vcl/ctrl.hxx>
 #include <memory>
 
-class AutoTimer;
-
 
 enum class ScrollType
 {
diff --git a/include/vcl/seleng.hxx b/include/vcl/seleng.hxx
index 0ba81da8052a..800e767c7cba 100644
--- a/include/vcl/seleng.hxx
+++ b/include/vcl/seleng.hxx
@@ -26,7 +26,6 @@
 #include <vcl/vclenum.hxx>
 #include <o3tl/typed_flags_set.hxx>
 
-namespace vcl { class Window; }
 class CommandEvent;
 
 // Timerticks
diff --git a/include/vcl/settings.hxx b/include/vcl/settings.hxx
index adadeb39662f..3b7e5e215104 100644
--- a/include/vcl/settings.hxx
+++ b/include/vcl/settings.hxx
@@ -23,22 +23,21 @@
 #include <tools/solar.h>
 #include <vcl/dllapi.h>
 #include <tools/color.hxx>
-#include <vcl/bitmapex.hxx>
-#include <vcl/font.hxx>
-#include <vcl/accel.hxx>
-#include <vcl/wall.hxx>
-#include <i18nlangtag/languagetag.hxx>
-#include <unotools/syslocale.hxx>
+#include <tools/gen.hxx>
 #include <o3tl/typed_flags_set.hxx>
 
 #include <memory>
+#include <vector>
+
+class BitmapEx;
+class LanguageTag;
+class SvtSysLocale;
 
 namespace boost
 {
     template<typename T> class optional;
 }
 
-class CollatorWrapper;
 class LocaleDataWrapper;
 struct ImplMouseData;
 struct ImplMiscData;
@@ -48,9 +47,8 @@ struct ImplAllSettingsData;
 enum class ConfigurationHints;
 
 namespace vcl {
+    class Font;
     class I18nHelper;
-    class IconThemeScanner;
-    class IconThemeSelector;
     class IconThemeInfo;
 }
 
diff --git a/include/vcl/sound.hxx b/include/vcl/sound.hxx
index 5cc9190118f8..84d3d25c4e35 100644
--- a/include/vcl/sound.hxx
+++ b/include/vcl/sound.hxx
@@ -22,8 +22,6 @@
 
 #include <vcl/dllapi.h>
 
-namespace vcl { class Window; }
-
 
 class VCL_DLLPUBLIC Sound
 {
diff --git a/include/vcl/spin.hxx b/include/vcl/spin.hxx
index 3d77fa5c1f06..fa37bff5f504 100644
--- a/include/vcl/spin.hxx
+++ b/include/vcl/spin.hxx
@@ -20,7 +20,6 @@
 #ifndef INCLUDED_VCL_SPIN_HXX
 #define INCLUDED_VCL_SPIN_HXX
 
-#include <tools/solar.h>
 #include <vcl/dllapi.h>
 #include <vcl/ctrl.hxx>
 #include <vcl/timer.hxx>
diff --git a/include/vcl/spinfld.hxx b/include/vcl/spinfld.hxx
index 482adf40e62c..23a2b5e51c05 100644
--- a/include/vcl/spinfld.hxx
+++ b/include/vcl/spinfld.hxx
@@ -20,7 +20,6 @@
 #ifndef INCLUDED_VCL_SPINFLD_HXX
 #define INCLUDED_VCL_SPINFLD_HXX
 
-#include <tools/solar.h>
 #include <vcl/dllapi.h>
 #include <vcl/edit.hxx>
 #include <vcl/timer.hxx>
diff --git a/include/vcl/splitwin.hxx b/include/vcl/splitwin.hxx
index 7f015ce96cf0..711954920c7f 100644
--- a/include/vcl/splitwin.hxx
+++ b/include/vcl/splitwin.hxx
@@ -24,7 +24,6 @@
 #include <vcl/dockwin.hxx>
 #include <o3tl/typed_flags_set.hxx>
 
-class Wallpaper;
 class ImplSplitSet;
 
 enum class SplitWindowItemFlags
diff --git a/include/vcl/svapp.hxx b/include/vcl/svapp.hxx
index c597ba453de3..ac1c0ddfb848 100644
--- a/include/vcl/svapp.hxx
+++ b/include/vcl/svapp.hxx
@@ -24,48 +24,42 @@
 #include <sal/types.h>
 
 #include <cassert>
-#include <stdexcept>
 #include <vector>
 
 #include <comphelper/solarmutex.hxx>
 #include <osl/mutex.hxx>
 #include <rtl/ustring.hxx>
-#include <osl/thread.hxx>
+#include <osl/thread.h>
 #include <tools/gen.hxx>
 #include <tools/link.hxx>
 #include <tools/solar.h>
 #include <vcl/dllapi.h>
 #include <vcl/inputtypes.hxx>
 #include <vcl/exceptiontypes.hxx>
-#include <vcl/keycod.hxx>
 #include <vcl/vclevent.hxx>
-#include <vcl/metric.hxx>
 #include <vcl/vclenum.hxx>
-#include <unotools/localedatawrapper.hxx>
+#include <i18nlangtag/lang.h>
 #include <o3tl/typed_flags_set.hxx>
 #include <com/sun/star/uno/Reference.h>
-#include <com/sun/star/connection/XConnection.hpp>
 
 
 class BitmapEx;
 namespace weld
 {
     class Builder;
-    class Container;
     class MessageDialog;
     class Widget;
     class Window;
 }
+class LocaleDataWrapper;
 class AllSettings;
 class DataChangedEvent;
 class Accelerator;
 class Help;
 class OutputDevice;
 namespace vcl { class Window; }
+namespace vcl { class KeyCode; }
 class WorkWindow;
-class MenuBar;
-class UnoWrapperBase;
-class Reflection;
 class NotifyEvent;
 class KeyEvent;
 class MouseEvent;
diff --git a/include/vcl/svimpbox.hxx b/include/vcl/svimpbox.hxx
index 88c068874165..9753629cc3c3 100644
--- a/include/vcl/svimpbox.hxx
+++ b/include/vcl/svimpbox.hxx
@@ -23,19 +23,19 @@
 #include <vcl/dllapi.h>
 #include <vcl/seleng.hxx>
 #include <vcl/scrbar.hxx>
+#include <vcl/idle.hxx>
+#include <vcl/image.hxx>
 #include <vcl/svtaccessiblefactory.hxx>
 #include <vcl/vclevent.hxx>
-#include <unotools/intlwrapper.hxx>
+#include <vcl/treelistbox.hxx>
 #include <o3tl/enumarray.hxx>
 #include <memory>
 #include <vector>
 
-class SvTreeListBox;
-class Point;
+class SvLBoxButton;
 class SvTreeList;
 class SvImpLBox;
 class SvTreeListEntry;
-class SvLBoxTab;
 namespace comphelper
 {
     namespace string
diff --git a/include/vcl/svtabbx.hxx b/include/vcl/svtabbx.hxx
index 8fa72066dc1b..75aadf0db8f9 100644
--- a/include/vcl/svtabbx.hxx
+++ b/include/vcl/svtabbx.hxx
@@ -114,7 +114,6 @@ inline long SvTabListBox::GetTab( sal_uInt16 nTab ) const
 
 class HeaderBar;
 namespace vcl {
-    class IAccessibleTabListBox;
     struct SvHeaderTabListBoxImpl;
 }
 
diff --git a/include/vcl/svtaccessiblefactory.hxx b/include/vcl/svtaccessiblefactory.hxx
index 24ad85f8f930..1b63e20bfb12 100644
--- a/include/vcl/svtaccessiblefactory.hxx
+++ b/include/vcl/svtaccessiblefactory.hxx
@@ -21,7 +21,8 @@
 #define INCLUDED_INCLUDE_VCL_SVTACCESSIBLEFACTORY_HXX
 
 #include <vcl/dllapi.h>
-#include <vcl/accessiblefactory.hxx>
+
+namespace vcl { class IAccessibleFactory; }
 
 namespace vcl
 {
diff --git a/include/vcl/sysdata.hxx b/include/vcl/sysdata.hxx
index 794f424b4448..5c42207649d0 100644
--- a/include/vcl/sysdata.hxx
+++ b/include/vcl/sysdata.hxx
@@ -23,7 +23,6 @@
 #include <sal/types.h>
 
 #include <vector>
-#include <cstddef>
 
 #include <config_cairo_canvas.h>
 
diff --git a/include/vcl/syswin.hxx b/include/vcl/syswin.hxx
index d8dd2f3c245c..c285abe2c024 100644
--- a/include/vcl/syswin.hxx
+++ b/include/vcl/syswin.hxx
@@ -20,7 +20,6 @@
 #ifndef INCLUDED_VCL_SYSWIN_HXX
 #define INCLUDED_VCL_SYSWIN_HXX
 
-#include <tools/solar.h>
 #include <vcl/dllapi.h>
 #include <vcl/builder.hxx>
 #include <vcl/idle.hxx>