diff options
| author | Ashod Nakashian <ashod.nakashian@collabora.co.uk> | 2023-02-11 14:53:44 -0500 |
|---|---|---|
| committer | Aron Budea <aron.budea@collabora.com> | 2023-06-27 06:26:51 +0200 |
| commit | 097cf021cb946da7ebc6fe548fb035aec2d4eaa5 (patch) | |
| tree | e1fc3e4c01f22ac8be759401536493e3eb627ecc /include | |
| parent | 609a1567d0e60ca11800df56059b97b6a61ad117 (diff) | |
lok: only publish MEDIA_SHAPE to selecting view
We now publish the url for the media shape
in the LOK_CALLBACK_GRAPHIC_SELECTION message.
This has many advantages, most notably that it
only sends the URL to the view selecting the
media. Also, it is now easier to handle
the message as there is no need for both
a LOK_CALLBACK_GRAPHIC_SELECTION and
a LOK_CALLBACK_MEDIA_SHAPE. However, the
latter is still defined as we might still
use it at some point.
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Change-Id: I8d4b8794d8e590628630f2b0bfbfb5debe02515f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146848
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153009
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153369
Tested-by: Jenkins
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Diffstat (limited to 'include')
| -rw-r--r-- | include/sfx2/lokhelper.hxx | 4 | ||||
| -rw-r--r-- | include/svx/svdomedia.hxx | 3 |
2 files changed, 0 insertions, 7 deletions
diff --git a/include/sfx2/lokhelper.hxx b/include/sfx2/lokhelper.hxx index 08d66fd538cc..b46097938695 100644 --- a/include/sfx2/lokhelper.hxx +++ b/include/sfx2/lokhelper.hxx @@ -182,10 +182,6 @@ public: /// Helper for diagnosing run-time problems static void dumpState(rtl::OStringBuffer &rState); - /// Notify all views of a media update. - /// This could be a new insertion or property modifications to an existing one. - static void notifyMediaUpdate(boost::property_tree::ptree& json); - /// Process the mouse event in the currently active in-place component (if any). /// Returns true if the event has been processed, and no further processing is necessary. static bool testInPlaceComponentMouseEventHit(SfxViewShell* pViewShell, int nType, int nX, diff --git a/include/svx/svdomedia.hxx b/include/svx/svdomedia.hxx index e3120c672f3d..aead70568511 100644 --- a/include/svx/svdomedia.hxx +++ b/include/svx/svdomedia.hxx @@ -75,9 +75,6 @@ public: virtual bool shouldKeepAspectRatio() const override { return true; } - /// When Lokit is enabled, notify the media details. - void notifyPropertiesForLOKit(); - private: void mediaPropertiesChanged( const ::avmedia::MediaItem& rNewState ); virtual std::unique_ptr<sdr::contact::ViewContact> CreateObjectSpecificViewContact() override; |