diff options
author | Muhammet Kara <muhammet.kara@collabora.com> | 2019-12-18 02:11:23 +0300 |
---|---|---|
committer | Muhammet Kara <muhammet.kara@collabora.com> | 2020-02-29 02:23:22 +0100 |
commit | 150ca03b82393c8c9704885b56c2752b77bbb559 (patch) | |
tree | 429b98059c42bee84bc3da2b0c69acdf9b02aa08 /include | |
parent | bf16e836dd7094cb5679042bbd49cb8b49c869d2 (diff) |
lok: Resolves: Writer - selecting a hyperlink doesn't show link in dialog
Repro: Select text in Online, and Ctrl + K to open Hyperlink dialog,
then assign a hyperlink and close with Ok. Without removing/changing
the selection, re-open the hyperlink dialog again by Ctrl + K. You see
that the hyperlink is not recognized.
Why?
The dialog relies on the hyperlinkUnderCursor property which is
set by the SfxLokHelper::notifyVisCursorInvalidation() method, which
also relies on the current char cursor is on. So when you select a hyperlinked
text from left to right (in English), the final position of the cursor is outside
the hyperlinked text, thus the hyperlinkUnderCursor property is unset.
Solution
Check for presence of selection and hyperlink via SfxItemPool and
proceed accordingly
Change-Id: I3a7f18c8199cec243ac99f011d9aaee7c7c575b8
Reviewed-on: https://gerrit.libreoffice.org/85348
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89704
Tested-by: Jenkins
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions