improve constparam loplugin

lots of little fixes to make the logic less pessimistic

Change-Id: If368822984250b11b98c56f5890177a1402e8660
Reviewed-on: https://gerrit.libreoffice.org/44168
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

6 files changed, 15 insertions, 15 deletions

diff --git a/include/registry/registry.hxx b/include/registry/registry.hxx
index 2036c730fa9e..c36a57f9986a 100644
--- a/include/registry/registry.hxx
+++ b/include/registry/registry.hxx
@@ -53,7 +53,7 @@ struct Registry_Api
     RegError    (REGISTRY_CALLTYPE *deleteKey)          (RegKeyHandle, rtl_uString*);
     RegError    (REGISTRY_CALLTYPE *closeKey)           (RegKeyHandle);
     RegError    (REGISTRY_CALLTYPE *setValue)           (RegKeyHandle, rtl_uString*, RegValueType, RegValue, sal_uInt32);
-    RegError    (REGISTRY_CALLTYPE *setLongListValue)   (RegKeyHandle, rtl_uString*, sal_Int32*, sal_uInt32);
+    RegError    (REGISTRY_CALLTYPE *setLongListValue)   (RegKeyHandle, rtl_uString*, sal_Int32 const *, sal_uInt32);
     RegError    (REGISTRY_CALLTYPE *setStringListValue) (RegKeyHandle, rtl_uString*, sal_Char**, sal_uInt32);
     RegError    (REGISTRY_CALLTYPE *setUnicodeListValue)(RegKeyHandle, rtl_uString*, sal_Unicode**, sal_uInt32);
     RegError    (REGISTRY_CALLTYPE *getValueInfo)       (RegKeyHandle, rtl_uString*, RegValueType*, sal_uInt32*);
@@ -448,7 +448,7 @@ public:
         @return RegError::NO_ERROR if succeeds else an error code.
     */
     inline RegError setLongListValue(const rtl::OUString& keyName,
-                                         sal_Int32* pValueList,
+                                         sal_Int32 const * pValueList,
                                          sal_uInt32 len);
 
     /** sets an ascii list value of a key.
@@ -824,7 +824,7 @@ inline RegError RegistryKey::setValue(const rtl::OUString& keyName,
     }
 
 inline RegError RegistryKey::setLongListValue(const rtl::OUString& keyName,
-                                                  sal_Int32* pValueList,
+                                                  sal_Int32 const * pValueList,
                                                   sal_uInt32 len)
     {
         if (m_registry.isValid())
diff --git a/include/registry/writer.h b/include/registry/writer.h
index 56ab9c925bf7..741c9451932f 100644
--- a/include/registry/writer.h
+++ b/include/registry/writer.h
@@ -95,7 +95,7 @@ REG_DLLPUBLIC void SAL_CALL typereg_writer_destroy(void * handle) SAL_THROW_EXTE
    @since UDK 3.2.0
  */
 REG_DLLPUBLIC sal_Bool SAL_CALL typereg_writer_setSuperTypeName(
-    void * handle, sal_uInt16 index, rtl_uString const * typeName)
+    void const * handle, sal_uInt16 index, rtl_uString const * typeName)
         SAL_THROW_EXTERN_C();
 
 /**
@@ -208,7 +208,7 @@ REG_DLLPUBLIC sal_Bool SAL_CALL typereg_writer_setMethodParameterData(
    @since UDK 3.2.0
  */
 REG_DLLPUBLIC sal_Bool SAL_CALL typereg_writer_setMethodExceptionTypeName(
-    void * handle, sal_uInt16 methodIndex, sal_uInt16 exceptionIndex,
+    void const * handle, sal_uInt16 methodIndex, sal_uInt16 exceptionIndex,
     rtl_uString const * typeName)
     SAL_THROW_EXTERN_C();
 
diff --git a/include/sot/stg.hxx b/include/sot/stg.hxx
index f0d8ee70ff1b..4f2b19c0255e 100644
--- a/include/sot/stg.hxx
+++ b/include/sot/stg.hxx
@@ -129,7 +129,7 @@ protected:
                     OLEStorageBase( StgIo*, StgDirEntry*, StreamMode& );
                     ~OLEStorageBase();
     bool            Validate_Impl( bool ) const;
-    static bool     ValidateMode_Impl( StreamMode, StgDirEntry* p = nullptr );
+    static bool     ValidateMode_Impl( StreamMode, StgDirEntry const * p = nullptr );
 };
 
 class StorageStream : public BaseStorageStream, public OLEStorageBase
@@ -207,7 +207,7 @@ public:
     virtual bool                ValidateFAT() override;
     virtual bool                Validate( bool=false ) const override;
     virtual bool                ValidateMode( StreamMode ) const override;
-    bool                        ValidateMode( StreamMode, StgDirEntry* p ) const;
+    bool                        ValidateMode( StreamMode, StgDirEntry const * p ) const;
     virtual bool                Equals( const BaseStorage& rStream ) const override;
 };
 
diff --git a/include/store/store.h b/include/store/store.h
index 2e606e565856..3f6177a1af47 100644
--- a/include/store/store.h
+++ b/include/store/store.h
@@ -117,8 +117,8 @@ typedef void* storeDirectoryHandle;
  */
 STORE_DLLPUBLIC storeError SAL_CALL store_openDirectory (
     storeFileHandle       hFile,
-    rtl_uString          *pPath,
-    rtl_uString          *pName,
+    rtl_uString const    *pPath,
+    rtl_uString const    *pName,
     storeAccessMode       eAccessMode,
     storeDirectoryHandle *phDirectory
 ) SAL_THROW_EXTERN_C();
@@ -161,8 +161,8 @@ typedef void* storeStreamHandle;
  */
 STORE_DLLPUBLIC storeError SAL_CALL store_openStream (
     storeFileHandle    hFile,
-    rtl_uString       *pPath,
-    rtl_uString       *pName,
+    rtl_uString const *pPath,
+    rtl_uString const *pName,
     storeAccessMode    eMode,
     storeStreamHandle *phStrm
 ) SAL_THROW_EXTERN_C();
@@ -207,8 +207,8 @@ STORE_DLLPUBLIC storeError SAL_CALL store_writeStream (
  */
 STORE_DLLPUBLIC storeError SAL_CALL store_remove (
     storeFileHandle hFile,
-    rtl_uString    *pPath,
-    rtl_uString    *pName
+    rtl_uString const *pPath,
+    rtl_uString const *pName
 ) SAL_THROW_EXTERN_C();
 
 #ifdef __cplusplus
diff --git a/include/svl/zforlist.hxx b/include/svl/zforlist.hxx
index 969d0007380a..9c809bf30e8c 100644
--- a/include/svl/zforlist.hxx
+++ b/include/svl/zforlist.hxx
@@ -586,7 +586,7 @@ public:
 
     /** Return the corresponding edit format of a format. */
     sal_uInt32 GetEditFormat( double fNumber, sal_uInt32 nFIndex, short eType,
-                              LanguageType eLnge, SvNumberformat* pFormat );
+                              LanguageType eLnge, SvNumberformat const * pFormat );
 
     /// Return the reference date
     const Date& GetNullDate() const;
diff --git a/include/vcl/toolbox.hxx b/include/vcl/toolbox.hxx
index d5dc93a63770..92cac89f4e13 100644
--- a/include/vcl/toolbox.hxx
+++ b/include/vcl/toolbox.hxx
@@ -189,7 +189,7 @@ private:
     SAL_DLLPRIVATE void            ImplUpdateItem( ImplToolItems::size_type nIndex = ITEM_NOTFOUND );
     SAL_DLLPRIVATE bool            ImplHandleMouseMove( const MouseEvent& rMEvt, bool bRepeat = false );
     SAL_DLLPRIVATE bool            ImplHandleMouseButtonUp( const MouseEvent& rMEvt, bool bCancel = false );
-    SAL_DLLPRIVATE void            ImplChangeHighlight( ImplToolItem* pItem, bool bNoGrabFocus = false );
+    SAL_DLLPRIVATE void            ImplChangeHighlight( ImplToolItem const * pItem, bool bNoGrabFocus = false );
     SAL_DLLPRIVATE bool            ImplChangeHighlightUpDn( bool bUp, bool bNoCycle = false );
     SAL_DLLPRIVATE ImplToolItems::size_type ImplGetItemLine( ImplToolItem const * pCurrentItem );
     SAL_DLLPRIVATE ImplToolItem*   ImplGetFirstValidItem( ImplToolItems::size_type nLine );