loplugin:constantparam in svtools

Change-Id: Iceb1b57997e0369946150ef0764b71da59a6b7a6
Reviewed-on: https://gerrit.libreoffice.org/23725
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

8 files changed, 14 insertions, 28 deletions

diff --git a/include/svtools/breadcrumb.hxx b/include/svtools/breadcrumb.hxx
index e87ab6831dff..ac109ecbbfcd 100644
--- a/include/svtools/breadcrumb.hxx
+++ b/include/svtools/breadcrumb.hxx
@@ -49,7 +49,7 @@ class SVT_DLLPUBLIC Breadcrumb : public VclHBox
         DECL_LINK_TYPED( ClickLinkHdl, FixedHyperlink&, void );
 
     public:
-        Breadcrumb( vcl::Window* pParent, WinBits nWinStyle = 0 );
+        Breadcrumb( vcl::Window* pParent );
         virtual ~Breadcrumb();
 
         void dispose() override;
diff --git a/include/svtools/calendar.hxx b/include/svtools/calendar.hxx
index 362019ecd8fe..029afb2752cf 100644
--- a/include/svtools/calendar.hxx
+++ b/include/svtools/calendar.hxx
@@ -227,8 +227,8 @@ private:
     SVT_DLLPRIVATE void         ImplDrawSpin(vcl::RenderContext& rRenderContext);
     SVT_DLLPRIVATE void         ImplDrawDate(vcl::RenderContext& rRenderContext, long nX, long nY,
                                              sal_uInt16 nDay, sal_uInt16 nMonth, sal_uInt16 nYear,
-                                             DayOfWeek eDayOfWeek, bool bBack = true,
-                                             bool bOther = false, sal_uLong nToday = 0);
+                                             DayOfWeek eDayOfWeek,
+                                             bool bOther, sal_uLong nToday);
     SVT_DLLPRIVATE void         ImplDraw(vcl::RenderContext& rRenderContext);
     SVT_DLLPRIVATE void         ImplUpdateDate( const Date& rDate );
     SVT_DLLPRIVATE void         ImplUpdateSelection( IntDateSet* pOld );
diff --git a/include/svtools/editbrowsebox.hxx b/include/svtools/editbrowsebox.hxx
index 7af671faf9ab..d28511e49250 100644
--- a/include/svtools/editbrowsebox.hxx
+++ b/include/svtools/editbrowsebox.hxx
@@ -283,7 +283,7 @@ namespace svt
         Link<LinkParamNone*,void>    m_aModifyLink;
 
     public:
-        CheckBoxControl(vcl::Window* pParent, WinBits nWinStyle = 0);
+        CheckBoxControl(vcl::Window* pParent);
         virtual ~CheckBoxControl();
         virtual void dispose() override;
 
@@ -332,7 +332,7 @@ namespace svt
         friend class ComboBoxCellController;
 
     public:
-        ComboBoxControl(vcl::Window* pParent, WinBits nWinStyle = 0);
+        ComboBoxControl(vcl::Window* pParent);
 
     protected:
         virtual bool PreNotify( NotifyEvent& rNEvt ) override;
@@ -365,7 +365,7 @@ namespace svt
         friend class ListBoxCellController;
 
     public:
-        ListBoxControl(vcl::Window* pParent, WinBits nWinStyle = 0);
+        ListBoxControl(vcl::Window* pParent);
 
     protected:
         virtual bool PreNotify( NotifyEvent& rNEvt ) override;
diff --git a/include/svtools/filectrl.hxx b/include/svtools/filectrl.hxx
index 14fe9466a84f..1c677e82487c 100644
--- a/include/svtools/filectrl.hxx
+++ b/include/svtools/filectrl.hxx
@@ -28,17 +28,6 @@
 
 #define STR_FILECTRL_BUTTONTEXT     333     // ID-Range?!
 
-// Flags for FileControl
-enum class FileControlMode
-{
-    NONE                    = 0x00,
-    RESIZEBUTTONBYPATHLEN   = 0x01, //if this is set, the button will become small as soon as the Text in the Edit Field is to long to be shown completely
-};
-namespace o3tl
-{
-    template<> struct typed_flags<FileControlMode> : is_typed_flags<FileControlMode, 0x01> {};
-}
-
 // Flags for internal use of FileControl
 enum class FileControlMode_Internal
 {
@@ -60,7 +49,6 @@ private:
     OUString        maButtonText;
     bool            mbOpenDlg;
 
-    FileControlMode             mnFlags;
     FileControlMode_Internal    mnInternalFlags;
 
 private:
@@ -74,7 +62,7 @@ protected:
     DECL_DLLPRIVATE_LINK_TYPED( ButtonHdl, Button*, void );
 
 public:
-                    FileControl( vcl::Window* pParent, WinBits nStyle, FileControlMode = FileControlMode::NONE );
+                    FileControl( vcl::Window* pParent, WinBits nStyle );
     virtual         ~FileControl();
     virtual void    dispose() override;
 
diff --git a/include/svtools/headbar.hxx b/include/svtools/headbar.hxx
index 60f05ec53882..8ebef5e9b6ee 100644
--- a/include/svtools/headbar.hxx
+++ b/include/svtools/headbar.hxx
@@ -256,10 +256,10 @@ private:
     using Window::ImplHitTest;
     SVT_DLLPRIVATE sal_uInt16               ImplHitTest( const Point& rPos, long& nMouseOff, sal_uInt16& nPos ) const;
     SVT_DLLPRIVATE void             ImplInvertDrag( sal_uInt16 nStartPos, sal_uInt16 nEndPos );
-    SVT_DLLPRIVATE void             ImplDrawItem(vcl::RenderContext& rRenderContext, sal_uInt16 nPos, bool bHigh, bool bDrag,
+    SVT_DLLPRIVATE void             ImplDrawItem(vcl::RenderContext& rRenderContext, sal_uInt16 nPos, bool bHigh,
                                                  const Rectangle& rItemRect, const Rectangle* pRect, DrawFlags nFlags);
-    SVT_DLLPRIVATE void             ImplDrawItem(vcl::RenderContext& rRenderContext, sal_uInt16 nPos, bool bHigh = false,
-                                                 bool bDrag = false, const Rectangle* pRect = nullptr);
+    SVT_DLLPRIVATE void             ImplDrawItem(vcl::RenderContext& rRenderContext, sal_uInt16 nPos, bool bHigh,
+                                                 const Rectangle* pRect);
     SVT_DLLPRIVATE void             ImplUpdate( sal_uInt16 nPos,
                                        bool bEnd = false );
     SVT_DLLPRIVATE void             ImplStartDrag( const Point& rPos, bool bCommand );
diff --git a/include/svtools/ivctrl.hxx b/include/svtools/ivctrl.hxx
index 0e5896512066..2f37b12b01ab 100644
--- a/include/svtools/ivctrl.hxx
+++ b/include/svtools/ivctrl.hxx
@@ -153,12 +153,11 @@ class SvxIconChoiceCtrlColumnInfo
     Image                   aColImage;
     long                    nWidth;
     SvxIconChoiceCtrlColumnAlign    eAlignment;
-    sal_uInt16                  nSubItem;
+    sal_uInt16              nSubItem;
 
 public:
-                            SvxIconChoiceCtrlColumnInfo( sal_uInt16 nSub, long nWd,
-                                SvxIconChoiceCtrlColumnAlign eAlign ) :
-                                nWidth( nWd ), eAlignment( eAlign ), nSubItem( nSub ) {}
+                            SvxIconChoiceCtrlColumnInfo( long nWd ) :
+                                nWidth( nWd ), eAlignment( IcnViewAlignLeft ), nSubItem( 0 ) {}
                             SvxIconChoiceCtrlColumnInfo( const SvxIconChoiceCtrlColumnInfo& );
 
     void                    SetWidth( long nWd ) { nWidth = nWd; }
diff --git a/include/svtools/scrwin.hxx b/include/svtools/scrwin.hxx
index 05ba486195a9..0a67f288290d 100644
--- a/include/svtools/scrwin.hxx
+++ b/include/svtools/scrwin.hxx
@@ -62,7 +62,7 @@ private:
     DECL_DLLPRIVATE_LINK_TYPED( EndScrollHdl, ScrollBar *, void );
 
 public:
-                    ScrollableWindow( vcl::Window* pParent, WinBits nBits = 0,
+                    ScrollableWindow( vcl::Window* pParent,
                                       ScrollableWindowFlags = ScrollableWindowFlags::DEFAULT );
     virtual         ~ScrollableWindow();
     virtual void    dispose() override;
diff --git a/include/svtools/treelistbox.hxx b/include/svtools/treelistbox.hxx
index 8375dbd757b6..75f27ba02f1b 100644
--- a/include/svtools/treelistbox.hxx
+++ b/include/svtools/treelistbox.hxx
@@ -318,7 +318,6 @@ protected:
     // In-place editing
     SvInplaceEdit2*  pEdCtrl;
     void            EditText( const OUString&, const Rectangle&,const Selection&);
-    void            EditText( const OUString&, const Rectangle&,const Selection&, bool bMulti);
     void            CancelTextEditing();
     bool            EditingCanceled() const;
     bool            IsEmptyTextAllowed() const;