loplugin:constantparam in svx

Change-Id: Ib2a432fc334898c75ab5e5cf629a21fd310bd467

6 files changed, 16 insertions, 24 deletions

diff --git a/include/svx/framelink.hxx b/include/svx/framelink.hxx
index 752f81890351..adc16dbae326 100644
--- a/include/svx/framelink.hxx
+++ b/include/svx/framelink.hxx
@@ -320,9 +320,6 @@ long GetBLDiagOffset( long nVerOffs, long nDiagOffs, double fAngle );
     bottom-right diagonal frame border, connected to the right end of a
     horizontal frame border.
 
-    @param nVerOffs
-        The vertical position of the point to be calculated, relative to the Y
-        coordinate of the reference point.
     @param nDiagOffs
         The width offset across the diagonal frame border (0 = middle),
         regardless of the gradient of the diagonal frame border (always
@@ -332,7 +329,7 @@ long GetBLDiagOffset( long nVerOffs, long nDiagOffs, double fAngle );
     @param fAngle
         Inner (left) angle between diagonal and horizontal frame border.
  */
-long GetBRDiagOffset( long nVerOffs, long nDiagOffs, double fAngle );
+long GetBRDiagOffset( long nDiagOffs, double fAngle );
 
 /** Returns an X coordinate for a diagonal frame border in the specified height.
 
@@ -340,9 +337,6 @@ long GetBRDiagOffset( long nVerOffs, long nDiagOffs, double fAngle );
     top-right diagonal frame border, connected to the right end of a horizontal
     frame border.
 
-    @param nVerOffs
-        The vertical position of the point to be calculated, relative to the Y
-        coordinate of the reference point.
     @param nDiagOffs
         The width offset across the diagonal frame border (0 = middle),
         regardless of the gradient of the diagonal frame border (always
@@ -352,7 +346,7 @@ long GetBRDiagOffset( long nVerOffs, long nDiagOffs, double fAngle );
     @param fAngle
         Inner (left) angle between diagonal and horizontal frame border.
  */
-long GetTRDiagOffset( long nVerOffs, long nDiagOffs, double fAngle );
+long GetTRDiagOffset( long nDiagOffs, double fAngle );
 
 
 /** Checks whether two horizontal frame borders are "connectable".
diff --git a/include/svx/framelinkarray.hxx b/include/svx/framelinkarray.hxx
index 774b55036cb8..2ae5e577d2dd 100644
--- a/include/svx/framelinkarray.hxx
+++ b/include/svx/framelinkarray.hxx
@@ -328,11 +328,9 @@ public:
     // mirroring --------------------------------------------------------------
 
     /** Mirrors the entire array horizontally.
-        @param bMirrorStyles
-            true = Swap primary and secondary line of all vertical double frame borders.
         @param bSwapDiag
             true = Swap top-left to bottom-right and bottom-left to top-right frame borders. */
-    void                MirrorSelfX( bool bMirrorStyles, bool bSwapDiag );
+    void                MirrorSelfX( bool bSwapDiag );
 
     // drawing ----------------------------------------------------------------
 
diff --git a/include/svx/sdr/contact/viewcontact.hxx b/include/svx/sdr/contact/viewcontact.hxx
index f11c188ca789..6f16ff125600 100644
--- a/include/svx/sdr/contact/viewcontact.hxx
+++ b/include/svx/sdr/contact/viewcontact.hxx
@@ -94,9 +94,9 @@ public:
     // ObjectContact (->View). Always needs to return something.
     ViewObjectContact& GetViewObjectContact(ObjectContact& rObjectContact);
 
-    // Test if this ViewContact has ViewObjectContacts at all. This can
+    // Test if this ViewContact has ViewObjectContacts(excluding previews) at all. This can
     // be used to test if this ViewContact is visualized ATM or not
-    bool HasViewObjectContacts(bool bExcludePreviews = false) const;
+    bool HasViewObjectContacts() const;
 
     // Check if this primitive is animated in any OC (View) which means it has
     // generated a PrimitiveAnimation in its VOC
diff --git a/include/svx/svdedtv.hxx b/include/svx/svdedtv.hxx
index 0b4511cecb92..6380ee0b6d1a 100644
--- a/include/svx/svdedtv.hxx
+++ b/include/svx/svdedtv.hxx
@@ -339,8 +339,8 @@ public:
     // return sal_True, if at least one marked object could be converted.
     // Also member objects of group objects are converted.
     // For a better description see: SdrObj.HXX
-    bool IsConvertToPathObjPossible(bool bLineToArea) const { ForcePossibilities(); return bLineToArea ? bCanConvToPathLineToArea : bCanConvToPath; }
-    bool IsConvertToPolyObjPossible(bool bLineToArea) const { ForcePossibilities(); return bLineToArea ? bCanConvToPolyLineToArea : bCanConvToPoly; }
+    bool IsConvertToPathObjPossible() const { ForcePossibilities(); return bCanConvToPath; }
+    bool IsConvertToPolyObjPossible() const { ForcePossibilities(); return bCanConvToPoly; }
     bool IsConvertToContourPossible() const { ForcePossibilities(); return bCanConvToContour; }
     void ConvertMarkedToPathObj(bool bLineToArea);
     void ConvertMarkedToPolyObj(bool bLineToArea);
diff --git a/include/svx/svxdlg.hxx b/include/svx/svxdlg.hxx
index c6617dd4c565..f6ddfdf5cb99 100644
--- a/include/svx/svxdlg.hxx
+++ b/include/svx/svxdlg.hxx
@@ -283,10 +283,10 @@ public:
                                         const SdrView* pView,
                                         sal_uInt16 nAnchorTypes = 0 ) = 0;
 
-    virtual AbstractSvxDistributeDialog*    CreateSvxDistributeDialog(vcl::Window* pParent,
+    virtual AbstractSvxDistributeDialog*    CreateSvxDistributeDialog(
                                             const SfxItemSet& rAttr)= 0;
 
-    virtual AbstractFmShowColsDialog * CreateFmShowColsDialog( vcl::Window* pParent ) = 0;
+    virtual AbstractFmShowColsDialog * CreateFmShowColsDialog() = 0;
 
     virtual AbstractSvxZoomDialog * CreateSvxZoomDialog( vcl::Window* pParent,
                                             const SfxItemSet& rCoreSet )=0;
@@ -301,7 +301,7 @@ public:
                                              const OUString& rOldText ) = 0;
     virtual AbstractGalleryIdDialog * CreateGalleryIdDialog( vcl::Window* pParent,
                                             GalleryTheme* pThm ) = 0;
-    virtual VclAbstractDialog2 * CreateGalleryThemePropertiesDialog( vcl::Window* pParent,
+    virtual VclAbstractDialog2 * CreateGalleryThemePropertiesDialog(
                                             ExchangeData* pData,
                                             SfxItemSet* pItemSet ) = 0;
     virtual AbstractURLDlg * CreateURLDialog( vcl::Window* pParent,
@@ -339,7 +339,7 @@ public:
     virtual AbstractSvxJSearchOptionsDialog * CreateSvxJSearchOptionsDialog( vcl::Window* pParent,
                                                             const SfxItemSet& rOptionsSet,
                                                             sal_Int32 nInitialFlags )=0;
-    virtual AbstractFmInputRecordNoDialog * CreateFmInputRecordNoDialog( vcl::Window* pParent ) = 0;
+    virtual AbstractFmInputRecordNoDialog * CreateFmInputRecordNoDialog() = 0;
     virtual AbstractSvxNewDictionaryDialog* CreateSvxNewDictionaryDialog( vcl::Window* pParent ) = 0;
     virtual VclAbstractDialog *     CreateSvxEditDictionaryDialog( vcl::Window* pParent,
                                             const OUString& rName,
@@ -348,8 +348,8 @@ public:
                                             const OUString& rName, const OUString& rDesc ) = 0;
 
     // #i68101#
-    virtual AbstractSvxObjectNameDialog* CreateSvxObjectNameDialog(vcl::Window* pParent, const OUString& rName ) = 0;
-    virtual AbstractSvxObjectTitleDescDialog* CreateSvxObjectTitleDescDialog(vcl::Window* pParent, const OUString& rTitle, const OUString& rDescription) = 0;
+    virtual AbstractSvxObjectNameDialog* CreateSvxObjectNameDialog(const OUString& rName ) = 0;
+    virtual AbstractSvxObjectTitleDescDialog* CreateSvxObjectTitleDescDialog(const OUString& rTitle, const OUString& rDescription) = 0;
 
     virtual AbstractSvxMultiPathDialog *    CreateSvxMultiPathDialog(vcl::Window* pParent) = 0 ;
     virtual AbstractSvxMultiPathDialog *    CreateSvxPathSelectDialog(vcl::Window* pParent) = 0 ;
@@ -420,11 +420,11 @@ public:
                 const sal_uInt16 _nInitiallySelectedEvent
             ) = 0;
 
-    virtual SfxAbstractTabDialog* CreateSvxFormatCellsDialog( vcl::Window* pParent, const SfxItemSet* pAttr, SdrModel* pModel, const SdrObject* pObj = nullptr )=0;
+    virtual SfxAbstractTabDialog* CreateSvxFormatCellsDialog( const SfxItemSet* pAttr, SdrModel* pModel, const SdrObject* pObj = nullptr )=0;
 
     virtual SvxAbstractSplittTableDialog* CreateSvxSplittTableDialog( vcl::Window* pParent, bool bIsTableVertical, long nMaxVertical, long nMaxHorizontal )=0;
 
-    virtual SvxAbstractNewTableDialog* CreateSvxNewTableDialog( vcl::Window* pParent ) = 0;
+    virtual SvxAbstractNewTableDialog* CreateSvxNewTableDialog() = 0;
 
     virtual SvxAbstractInsRowColDlg* CreateSvxInsRowColDlg( vcl::Window* pParent, bool bCol, const OString& sHelpId ) = 0;
 };
diff --git a/include/svx/view3d.hxx b/include/svx/view3d.hxx
index cf2cc0530ba0..66962f1d3ab2 100644
--- a/include/svx/view3d.hxx
+++ b/include/svx/view3d.hxx
@@ -108,7 +108,7 @@ public:
 
     // Means to create all Extrudes in a certain depth order.
     static void DoDepthArrange(E3dScene* pScene, double fDepth);
-    void ConvertMarkedToPolyObj(bool bLineToArea);
+    void ConvertMarkedToPolyObj();
     E3dScene* SetCurrent3DObj(E3dObject* p3DObj);
     void Start3DCreation();