loplugin:unusedmethods unused return value in include/svl

Change-Id: I759fe8769daccea07c2157bfb5912df8ba285534

24 files changed, 26 insertions, 59 deletions

diff --git a/include/editeng/boxitem.hxx b/include/editeng/boxitem.hxx
index 563a1b5711bb..58ccb21ac086 100644
--- a/include/editeng/boxitem.hxx
+++ b/include/editeng/boxitem.hxx
@@ -85,7 +85,7 @@ public:
     virtual SvStream&        Store(SvStream &, sal_uInt16 nItemVersion ) const override;
     virtual sal_uInt16           GetVersion( sal_uInt16 nFileVersion ) const override;
 
-    virtual bool             ScaleMetrics( long nMult, long nDiv ) override;
+    virtual void             ScaleMetrics( long nMult, long nDiv ) override;
     virtual bool             HasMetrics() const override;
 
     const   editeng::SvxBorderLine* GetTop()    const { return pTop; }
@@ -198,7 +198,7 @@ public:
     virtual SfxPoolItem*    Clone( SfxItemPool *pPool = nullptr ) const override;
     virtual SfxPoolItem*    Create(SvStream &, sal_uInt16) const override;
     virtual SvStream&       Store(SvStream &, sal_uInt16 nItemVersion ) const override;
-    virtual bool            ScaleMetrics( long nMult, long nDiv ) override;
+    virtual void            ScaleMetrics( long nMult, long nDiv ) override;
     virtual bool            HasMetrics() const override;
 
     const editeng::SvxBorderLine*   GetHori() const { return pHori; }
diff --git a/include/editeng/fhgtitem.hxx b/include/editeng/fhgtitem.hxx
index cbd2a5fa0b09..c352e8e2bed9 100644
--- a/include/editeng/fhgtitem.hxx
+++ b/include/editeng/fhgtitem.hxx
@@ -61,7 +61,7 @@ public:
     virtual SfxPoolItem*     Create(SvStream &, sal_uInt16) const override;
     virtual SvStream&        Store(SvStream &, sal_uInt16 nItemVersion) const override;
     virtual sal_uInt16           GetVersion( sal_uInt16 nItemVersion) const override;
-    virtual bool                 ScaleMetrics( long nMult, long nDiv ) override;
+    virtual void                 ScaleMetrics( long nMult, long nDiv ) override;
     virtual bool                 HasMetrics() const override;
 
     inline SvxFontHeightItem& operator=(const SvxFontHeightItem& rSize)
diff --git a/include/editeng/fwdtitem.hxx b/include/editeng/fwdtitem.hxx
index 24525a869382..b3e10ca0947f 100644
--- a/include/editeng/fwdtitem.hxx
+++ b/include/editeng/fwdtitem.hxx
@@ -54,7 +54,7 @@ public:
     virtual SfxPoolItem*     Clone( SfxItemPool *pPool = nullptr ) const override;
     virtual SfxPoolItem*     Create(SvStream &, sal_uInt16) const override;
     virtual SvStream&        Store(SvStream &, sal_uInt16 nItemVersion) const override;
-    virtual bool             ScaleMetrics( long nMult, long nDiv ) override;
+    virtual void             ScaleMetrics( long nMult, long nDiv ) override;
     virtual bool             HasMetrics() const override;
 
     inline SvxFontWidthItem& operator=(const SvxFontWidthItem& rItem )
diff --git a/include/editeng/kernitem.hxx b/include/editeng/kernitem.hxx
index 46581c67c2d3..0398d46553f4 100644
--- a/include/editeng/kernitem.hxx
+++ b/include/editeng/kernitem.hxx
@@ -45,7 +45,7 @@ public:
     virtual SfxPoolItem*    Clone( SfxItemPool *pPool = nullptr ) const override;
     virtual SfxPoolItem*    Create(SvStream &, sal_uInt16) const override;
     virtual SvStream&       Store(SvStream &, sal_uInt16 nItemVersion) const override;
-    virtual bool            ScaleMetrics( long nMult, long nDiv ) override;
+    virtual void            ScaleMetrics( long nMult, long nDiv ) override;
     virtual bool            HasMetrics() const override;
 
     virtual bool GetPresentation( SfxItemPresentation ePres,
diff --git a/include/editeng/lineitem.hxx b/include/editeng/lineitem.hxx
index 70ebf75515fb..3f354dd8c8e3 100644
--- a/include/editeng/lineitem.hxx
+++ b/include/editeng/lineitem.hxx
@@ -57,7 +57,7 @@ public:
     virtual SfxPoolItem*     Clone( SfxItemPool *pPool = nullptr ) const override;
     virtual SfxPoolItem*     Create(SvStream &, sal_uInt16) const override;
     virtual SvStream&        Store(SvStream &, sal_uInt16 nItemVersion ) const override;
-    virtual bool             ScaleMetrics( long nMult, long nDiv ) override;
+    virtual void             ScaleMetrics( long nMult, long nDiv ) override;
     virtual bool             HasMetrics() const override;
 
     const   editeng::SvxBorderLine*  GetLine     () const { return pLine; }
diff --git a/include/editeng/lrspitem.hxx b/include/editeng/lrspitem.hxx
index 191aa4b88156..895aefc068e2 100644
--- a/include/editeng/lrspitem.hxx
+++ b/include/editeng/lrspitem.hxx
@@ -87,7 +87,7 @@ public:
     virtual SfxPoolItem*     Create(SvStream &, sal_uInt16) const override;
     virtual SvStream&        Store(SvStream &, sal_uInt16 nItemVersion ) const override;
     virtual sal_uInt16           GetVersion( sal_uInt16 nFileVersion ) const override;
-    virtual bool                 ScaleMetrics( long nMult, long nDiv ) override;
+    virtual void                 ScaleMetrics( long nMult, long nDiv ) override;
     virtual bool                 HasMetrics() const override;
 
     // Die "Layout-Schnittstelle":
diff --git a/include/editeng/shaditem.hxx b/include/editeng/shaditem.hxx
index a4b6ff363960..eb6dd819a062 100644
--- a/include/editeng/shaditem.hxx
+++ b/include/editeng/shaditem.hxx
@@ -60,7 +60,7 @@ public:
     virtual SfxPoolItem*     Clone( SfxItemPool *pPool = nullptr ) const override;
     virtual SfxPoolItem*     Create(SvStream &, sal_uInt16) const override;
     virtual SvStream&        Store(SvStream &, sal_uInt16 nItemVersion ) const override;
-    virtual bool             ScaleMetrics( long nMult, long nDiv ) override;
+    virtual void             ScaleMetrics( long nMult, long nDiv ) override;
     virtual bool             HasMetrics() const override;
 
     const Color& GetColor() const { return aShadowColor;}
diff --git a/include/editeng/sizeitem.hxx b/include/editeng/sizeitem.hxx
index 1cd8a328660c..3615adff4dec 100644
--- a/include/editeng/sizeitem.hxx
+++ b/include/editeng/sizeitem.hxx
@@ -56,7 +56,7 @@ public:
     virtual SfxPoolItem*     Clone( SfxItemPool *pPool = nullptr ) const override;
     virtual SfxPoolItem*     Create(SvStream &, sal_uInt16) const override;
     virtual SvStream&        Store(SvStream &, sal_uInt16 nItemVersion ) const override;
-    virtual bool             ScaleMetrics( long nMult, long nDiv ) override;
+    virtual void             ScaleMetrics( long nMult, long nDiv ) override;
     virtual bool             HasMetrics() const override;
 
     const Size& GetSize() const { return aSize; }
diff --git a/include/editeng/ulspitem.hxx b/include/editeng/ulspitem.hxx
index 40f5b7eeb924..bae95b19dc1d 100644
--- a/include/editeng/ulspitem.hxx
+++ b/include/editeng/ulspitem.hxx
@@ -61,7 +61,7 @@ public:
     virtual SfxPoolItem*     Create(SvStream &, sal_uInt16) const override;
     virtual SvStream&        Store(SvStream &, sal_uInt16 nItemVersion ) const override;
     virtual sal_uInt16           GetVersion( sal_uInt16 nFileVersion ) const override;
-    virtual bool                 ScaleMetrics( long nMult, long nDiv ) override;
+    virtual void                 ScaleMetrics( long nMult, long nDiv ) override;
     virtual bool                 HasMetrics() const override;
 
     inline void SetUpper( const sal_uInt16 nU, const sal_uInt16 nProp = 100 );
diff --git a/include/svl/filerec.hxx b/include/svl/filerec.hxx
index 58271cc50488..b5685f33949f 100644
--- a/include/svl/filerec.hxx
+++ b/include/svl/filerec.hxx
@@ -87,8 +87,6 @@ public:
     inline          SfxMiniRecordWriter( SvStream *pStream, sal_uInt8 nTag );
     inline          ~SfxMiniRecordWriter();
 
-    inline SvStream& operator*() const;
-
     sal_uInt32      Close( bool bSeekToEndOfRec = true );
 
 private:
@@ -257,8 +255,6 @@ public:
     SfxMiniRecordReader( SvStream *pStream, sal_uInt8 nTag );
     inline              ~SfxMiniRecordReader();
 
-    inline SvStream&    operator*() const;
-
     inline void         Skip();
 
 private:
@@ -577,16 +573,6 @@ inline SfxMiniRecordWriter::~SfxMiniRecordWriter()
         Close();
 }
 
-/** Get the record's stream
- * @return The stream containing the record
- * @note The record must not be already closed!
- */
-inline SvStream& SfxMiniRecordWriter::operator*() const
-{
-    DBG_ASSERT( !_bHeaderOk, "getting Stream of closed record" );
-    return *_pStream;
-}
-
 /** The dtor moves the stream automatically to the position directly behind the record */
 inline SfxMiniRecordReader::~SfxMiniRecordReader()
 {
@@ -601,17 +587,6 @@ inline void SfxMiniRecordReader::Skip()
     _bSkipped = true;
 }
 
-/** get the owning stream
- *
- * This method returns the stream in which the record is contained.
- * The current position of the stream must be inside the record.
- */
-inline SvStream& SfxMiniRecordReader::operator*() const
-{
-    DBG_ASSERT( _pStream->Tell() < _nEofRec, "read behind record" );
-    return *_pStream;
-}
-
 /// @see SfxMiniRecordWriter::Close()
 inline sal_uInt32 SfxSingleRecordWriter::Close( bool bSeekToEndOfRec )
 {
diff --git a/include/svl/itemset.hxx b/include/svl/itemset.hxx
index 455be97b809f..16122cec4176 100644
--- a/include/svl/itemset.hxx
+++ b/include/svl/itemset.hxx
@@ -147,9 +147,9 @@ public:
     void                        MergeRange( sal_uInt16 nFrom, sal_uInt16 nTo );
     const SfxItemSet*           GetParent() const { return m_pParent; }
 
-    SvStream &                  Load( SvStream &, bool bDirect = false,
+    void                        Load( SvStream &, bool bDirect = false,
                                       const SfxItemPool *pRefPool = nullptr );
-    SvStream &                  Store( SvStream &, bool bDirect = false ) const;
+    void                        Store( SvStream &, bool bDirect = false ) const;
 
     bool                        operator==(const SfxItemSet &) const;
     sal_Int32                   getHash() const;
diff --git a/include/svl/macitem.hxx b/include/svl/macitem.hxx
index 38babec730ef..a6d78aa638c5 100644
--- a/include/svl/macitem.hxx
+++ b/include/svl/macitem.hxx
@@ -87,7 +87,7 @@ public:
     SvxMacroTableDtor& operator=( const SvxMacroTableDtor &rCpy );
     bool operator==( const SvxMacroTableDtor& rOther ) const;
 
-    SvStream&   Read( SvStream &, sal_uInt16 nVersion = SVX_MACROTBL_AKTVERSION );
+    void        Read( SvStream &, sal_uInt16 nVersion = SVX_MACROTBL_AKTVERSION );
     SvStream&   Write( SvStream & ) const;
 
     static sal_uInt16 GetVersion() { return SVX_MACROTBL_AKTVERSION; }
@@ -108,7 +108,7 @@ public:
     // This stores a copy of the rMacro parameter
     SvxMacro& Insert(sal_uInt16 nEvent, const SvxMacro& rMacro);
     // If the entry exists, remove it from the map and release it's storage
-    bool Erase(sal_uInt16 nEvent);
+    void Erase(sal_uInt16 nEvent);
 };
 
 
diff --git a/include/svl/metitem.hxx b/include/svl/metitem.hxx
index 39ce85159159..7dda419f245e 100644
--- a/include/svl/metitem.hxx
+++ b/include/svl/metitem.hxx
@@ -30,7 +30,7 @@ public:
                              SfxMetricItem( const SfxMetricItem& );
                              virtual ~SfxMetricItem() {}
 
-    virtual bool             ScaleMetrics( long lMult, long lDiv ) override;
+    virtual void             ScaleMetrics( long lMult, long lDiv ) override;
     virtual bool             HasMetrics() const override;
 
 };
diff --git a/include/svl/nranges.hxx b/include/svl/nranges.hxx
index 4cc9fc213f89..def27ace1258 100644
--- a/include/svl/nranges.hxx
+++ b/include/svl/nranges.hxx
@@ -39,8 +39,6 @@ public:
                                 { delete [] _pRanges; }
 
     bool                        operator == ( const SfxUShortRanges & ) const;
-    bool                        operator != ( const SfxUShortRanges & rRanges ) const
-                                { return !( *this == rRanges ); }
 
     SfxUShortRanges&            operator = ( const SfxUShortRanges & );
 
diff --git a/include/svl/ondemand.hxx b/include/svl/ondemand.hxx
index b32dc3608663..cfc729b9b518 100644
--- a/include/svl/ondemand.hxx
+++ b/include/svl/ondemand.hxx
@@ -207,8 +207,6 @@ public:
                                         return pPtr;
                                     }
 
-            CalendarWrapper*    operator->()    { return get(); }
-            CalendarWrapper&    operator*()     { return *get(); }
 };
 
 /** Load a transliteration only if it's needed.
@@ -286,7 +284,6 @@ public:
                                     }
 
     const   ::utl::TransliterationWrapper*  operator->() const  { return get(); }
-    const   ::utl::TransliterationWrapper&  operator*() const   { return *get(); }
 };
 
 /** Load a native number service wrapper only if it's needed.
@@ -340,8 +337,6 @@ public:
                                         return pPtr;
                                     }
 
-            NativeNumberWrapper*    operator->()    { return get(); }
-            NativeNumberWrapper&    operator*()     { return *get(); }
 };
 
 #endif // INCLUDED_SVL_ONDEMAND_HXX
diff --git a/include/svl/ownlist.hxx b/include/svl/ownlist.hxx
index 171d38deab44..460c4a3c0f83 100644
--- a/include/svl/ownlist.hxx
+++ b/include/svl/ownlist.hxx
@@ -62,10 +62,10 @@ private:
     ::std::vector< SvCommand >  aCommandList;
 
 public:
-    SvCommand&      Append( const OUString & rCommand, const OUString & rArg );
-    bool        AppendCommands( const OUString & rCmd, sal_Int32 * pEaten );
+    void           Append( const OUString & rCommand, const OUString & rArg );
+    void           AppendCommands( const OUString & rCmd, sal_Int32 * pEaten );
 
-    bool FillFromSequence( const css::uno::Sequence < css::beans::PropertyValue >& );
+    void FillFromSequence( const css::uno::Sequence < css::beans::PropertyValue >& );
     void FillSequence( css::uno::Sequence < css::beans::PropertyValue >& );
 
     size_t          size() const { return aCommandList.size(); }
diff --git a/include/svl/poolitem.hxx b/include/svl/poolitem.hxx
index 0ae6bea2c512..5d7e4235d6bc 100644
--- a/include/svl/poolitem.hxx
+++ b/include/svl/poolitem.hxx
@@ -177,7 +177,7 @@ public:
                                     const IntlWrapper * pIntlWrapper = nullptr ) const;
 
     virtual sal_uInt16       GetVersion( sal_uInt16 nFileFormatVersion ) const;
-    virtual bool             ScaleMetrics( long lMult, long lDiv );
+    virtual void             ScaleMetrics( long lMult, long lDiv );
     virtual bool             HasMetrics() const;
 
     virtual bool             QueryValue( css::uno::Any& rVal, sal_uInt8 nMemberId = 0 ) const;
diff --git a/include/svl/style.hxx b/include/svl/style.hxx
index 174986e7300c..82173676de2e 100644
--- a/include/svl/style.hxx
+++ b/include/svl/style.hxx
@@ -259,7 +259,7 @@ public:
     /** Add a style sheet.
      * Not an actual public function. Do not call it from non-subclasses.
      */
-    SfxStyleSheetBase&          Add( const SfxStyleSheetBase& );
+    void                        Add( const SfxStyleSheetBase& );
 };
 
 class SVL_DLLPUBLIC SfxStyleSheet: public SfxStyleSheetBase,
diff --git a/include/svl/zforlist.hxx b/include/svl/zforlist.hxx
index 0ca556598823..6178de7eb2d9 100644
--- a/include/svl/zforlist.hxx
+++ b/include/svl/zforlist.hxx
@@ -876,10 +876,9 @@ private:
     // Adjust a sequence of format codes to contain only one (THE) default
     // instead of multiple defaults for short/medium/long types.
     // If there is no medium but a short and a long default the long is taken.
-    // Return the default index in the sequence.
     // Non-PRODUCT version may check locale data for matching defaults in one
     // FormatElement group.
-    SVL_DLLPRIVATE sal_Int32 ImpAdjustFormatCodeDefault( css::i18n::NumberFormatCode * pFormatArr,
+    SVL_DLLPRIVATE void ImpAdjustFormatCodeDefault( css::i18n::NumberFormatCode * pFormatArr,
                                                          sal_Int32 nCount, bool bCheckCorrectness = true );
 
     // Obtain the format entry for a given key index.
diff --git a/include/svl/zformat.hxx b/include/svl/zformat.hxx
index c204702d168c..b66006b1f6fb 100644
--- a/include/svl/zformat.hxx
+++ b/include/svl/zformat.hxx
@@ -208,7 +208,7 @@ public:
     bool GetOutputString( double fNumber, sal_uInt16 nCharCount, OUString& rOutString ) const;
 
     bool GetOutputString( double fNumber, OUString& OutString, Color** ppColor );
-    bool GetOutputString( const OUString& sString, OUString& OutString, Color** ppColor );
+    void GetOutputString( const OUString& sString, OUString& OutString, Color** ppColor );
 
     // True if type text
     bool IsTextFormat() const { return (eType & css::util::NumberFormat::TEXT) != 0; }
diff --git a/include/svx/sdmetitm.hxx b/include/svx/sdmetitm.hxx
index 2ec9ba0c33aa..d9dfc83e16c2 100644
--- a/include/svx/sdmetitm.hxx
+++ b/include/svx/sdmetitm.hxx
@@ -36,7 +36,7 @@ public:
     virtual SfxPoolItem* Clone(SfxItemPool* pPool=nullptr) const override;
     virtual SfxPoolItem* Create(SvStream& rIn, sal_uInt16 nVer) const override;
     virtual bool HasMetrics() const override;
-    virtual bool ScaleMetrics(long nMul, long nDiv) override;
+    virtual void ScaleMetrics(long nMul, long nDiv) override;
 
     virtual bool GetPresentation(SfxItemPresentation ePres,
                                                 SfxMapUnit eCoreMetric,
diff --git a/include/svx/sdtaaitm.hxx b/include/svx/sdtaaitm.hxx
index ed4a40ad6136..3083e2f33262 100644
--- a/include/svx/sdtaaitm.hxx
+++ b/include/svx/sdtaaitm.hxx
@@ -30,7 +30,7 @@ public:
     virtual SfxPoolItem* Clone(SfxItemPool* pPool=nullptr) const override;
     virtual SfxPoolItem* Create(SvStream& rIn, sal_uInt16 nVer) const override;
     virtual bool HasMetrics() const override;
-    virtual bool ScaleMetrics(long nMul, long nDiv) override;
+    virtual void ScaleMetrics(long nMul, long nDiv) override;
 
     virtual bool GetPresentation(SfxItemPresentation ePres, SfxMapUnit eCoreMetric, SfxMapUnit ePresMetric, OUString& rText, const IntlWrapper * = nullptr) const override;
 };
diff --git a/include/svx/xflhtit.hxx b/include/svx/xflhtit.hxx
index 20cb18b399fd..b30c3f6fe229 100644
--- a/include/svx/xflhtit.hxx
+++ b/include/svx/xflhtit.hxx
@@ -53,7 +53,7 @@ public:
                                     SfxMapUnit ePresMetric,
                                     OUString &rText, const IntlWrapper * = nullptr ) const override;
     virtual bool            HasMetrics() const override;
-    virtual bool            ScaleMetrics(long nMul, long nDiv) override;
+    virtual void            ScaleMetrics(long nMul, long nDiv) override;
 
     const XHatch&           GetHatchValue() const { return aHatch;} // GetValue -> GetHatchValue
     void                    SetHatchValue(const XHatch& rNew)  { aHatch = rNew; Detach(); } // SetValue -> SetHatchValue
diff --git a/include/svx/xlndsit.hxx b/include/svx/xlndsit.hxx
index 8868558b4835..04bfa03d0bb1 100644
--- a/include/svx/xlndsit.hxx
+++ b/include/svx/xlndsit.hxx
@@ -55,7 +55,7 @@ public:
                                     SfxMapUnit ePresMetric,
                                     OUString &rText, const IntlWrapper * = nullptr ) const override;
     virtual bool            HasMetrics() const override;
-    virtual bool            ScaleMetrics(long nMul, long nDiv) override;
+    virtual void            ScaleMetrics(long nMul, long nDiv) override;
 
     const XDash&            GetDashValue() const { return aDash;}
     void                    SetDashValue(const XDash& rNew)   { aDash = rNew; Detach(); } // SetValue -> SetDashValue