diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-04-04 14:34:07 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-04-11 09:48:10 +0200 |
| commit | 49eb02f07a5af44da59008a238e828b4a9532bef (patch) | |
| tree | 43c4b4eaacd79fe0bff784a4ef71f4c1080c3912 /include | |
| parent | 5823ecd54b16974ffe8821a5ae061cd0ecc4cf84 (diff) | |
new loplugin:unusedvariablemore
collection of heuristics to look for local variables that are never read
from i.e. do not contribute to the surrounding logic
This is an expensive plugin, since it walks up the parent tree,
so it is off by default.
Change-Id: Ib8ba292241bd16adf299e8bba4502cb473513a06
Reviewed-on: https://gerrit.libreoffice.org/52450
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'include')
| -rw-r--r-- | include/test/testinteractionhandler.hxx | 4 | ||||
| -rw-r--r-- | include/vcl/edit.hxx | 2 |
2 files changed, 1 insertions, 5 deletions
diff --git a/include/test/testinteractionhandler.hxx b/include/test/testinteractionhandler.hxx index 805d72ba0d0b..950127ae185d 100644 --- a/include/test/testinteractionhandler.hxx +++ b/include/test/testinteractionhandler.hxx @@ -102,13 +102,10 @@ public: bool bIsRequestPasswordToModify = false; css::task::PasswordRequestMode mode{}; - OString sUrl; - css::task::DocumentPasswordRequest2 passwordRequest2; if (rRequest >>= passwordRequest2) { bIsRequestPasswordToModify = passwordRequest2.IsRequestPasswordToModify; - sUrl = passwordRequest2.Name.toUtf8(); mode = passwordRequest2.Mode; bPasswordRequestFound = true; } @@ -116,7 +113,6 @@ public: if (rRequest >>= passwordMSRequest2) { bIsRequestPasswordToModify = passwordMSRequest2.IsRequestPasswordToModify; - sUrl = passwordMSRequest2.Name.toUtf8(); mode = passwordMSRequest2.Mode; bPasswordRequestFound = true; } diff --git a/include/vcl/edit.hxx b/include/vcl/edit.hxx index c55a19eb02c0..a29a0f21ec33 100644 --- a/include/vcl/edit.hxx +++ b/include/vcl/edit.hxx @@ -115,7 +115,7 @@ private: SAL_DLLPRIVATE void ImplInsertText( const OUString& rStr, const Selection* pNewSelection = nullptr, bool bIsUserInput = false ); SAL_DLLPRIVATE static OUString ImplGetValidString( const OUString& rString ); SAL_DLLPRIVATE void ImplClearBackground(vcl::RenderContext& rRenderContext, const tools::Rectangle& rRectangle, long nXStart, long nXEnd); - SAL_DLLPRIVATE void ImplPaintBorder(vcl::RenderContext const & rRenderContext, long nXStart, long nXEnd); + SAL_DLLPRIVATE void ImplPaintBorder(vcl::RenderContext const & rRenderContext); SAL_DLLPRIVATE void ImplShowCursor( bool bOnlyIfVisible = true ); SAL_DLLPRIVATE void ImplAlign(); SAL_DLLPRIVATE void ImplAlignAndPaint(); |