summaryrefslogtreecommitdiff
path: root/include
diff options
context:
space:
mode:
authorMichael Weghorn <m.weghorn@posteo.de>2024-08-13 13:33:47 +0200
committerMichael Weghorn <m.weghorn@posteo.de>2024-08-13 19:31:15 +0200
commit612d20103f4fd26020c7f5ab7af80a4f504f06a3 (patch)
tree679344a11909907a00ac95d6770dbcf7a366c4ac /include
parent2833ba26c85b468960f69133941182be0c4ad74e (diff)
tdf#130857 VclBuilder: Move handleItems to base class
Let the base class do the parsing for items and return a `ComboBoxTextItem`. It has nothing `vcl::Window` specific. (`vcl::Window` specific part is only when this gets applied in `insertItems`, which could probably be reimplemented differently for other subclasses). Change-Id: Ica2f435b48c69fbdfff450b713d91a6fbe985de6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171820 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Diffstat (limited to 'include')
-rw-r--r--include/vcl/builder.hxx3
1 files changed, 2 insertions, 1 deletions
diff --git a/include/vcl/builder.hxx b/include/vcl/builder.hxx
index 85a32d3fb5e6..0e2426149b07 100644
--- a/include/vcl/builder.hxx
+++ b/include/vcl/builder.hxx
@@ -103,6 +103,8 @@ protected:
OUString finalizeValue(const OString& rContext, const OString& rValue,
const bool bTranslate) const;
+
+ std::vector<ComboBoxTextItem> handleItems(xmlreader::XmlReader& reader) const;
void handleListStore(xmlreader::XmlReader& reader, const OUString& rID, std::u16string_view rClass);
void handleRow(xmlreader::XmlReader& reader, const OUString& rID);
const ListStore* get_model_by_name(const OUString& sID) const;
@@ -393,7 +395,6 @@ private:
void handleTabChild(vcl::Window *pParent, xmlreader::XmlReader &reader);
void handleMenu(xmlreader::XmlReader& reader, vcl::Window* pParent, const OUString& rID,
bool bMenuBar);
- std::vector<ComboBoxTextItem> handleItems(xmlreader::XmlReader &reader) const;
stringmap handleAtkObject(xmlreader::XmlReader &reader) const;