vba: small fixes for GetOpenFilename and documenting structs

Check the XFileDialogSelectedItems is using the expected impl.
after dynamic_casting.

Rename VbaKeyBinding to VbaMacroKeyAndMethodBinding and document
the struct.

Change-Id: Ica4b24fed3013c5efa97a14e98bf9bdc2c74b68d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129320
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

1 files changed, 9 insertions, 2 deletions

diff --git a/include/oox/ole/vbamodule.hxx b/include/oox/ole/vbamodule.hxx
index 3028136375bc..4cbb4a41c948 100644
--- a/include/oox/ole/vbamodule.hxx
+++ b/include/oox/ole/vbamodule.hxx
@@ -40,9 +40,14 @@ namespace oox {
 
 namespace oox::ole {
 
-struct VbaKeyBinding
+/** Stores, which key shortcut maps to which VBA macro method. */
+struct VbaMacroKeyAndMethodBinding
 {
+    // This describes a key combinaton in "raw" VBA Macro form, that
+    // still needs translated to a key event that can be used in
+    // LibreOffice.
     OUString msApiKey;
+    // The name of the macro method
     OUString msMethodName;
 };
 
@@ -105,7 +110,9 @@ private:
     bool                mbReadOnly;
     bool                mbPrivate;
     bool                mbExecutable;
-    std::vector<VbaKeyBinding> maKeyBindings;
+
+    /** Keys and VBA macro method bindings */
+    std::vector<VbaMacroKeyAndMethodBinding> maKeyBindings;
 };