diff options
| author | Noel Grandin <noelgrandin@gmail.com> | 2020-11-04 08:04:24 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-11-10 17:10:31 +0100 |
| commit | 8523fb2b37a2cdd2c3743795bb33cf30a57c5385 (patch) | |
| tree | a4e596966d98dfc320772bd0efa78ea1032fbf98 /include | |
| parent | f37b87ea5c87a683a39758a2875539f6bf59cf93 (diff) | |
remove pimpl from SvXMLAttributeList
and add some asserts to catch bad index params
Change-Id: I3551358282da2218a5a1a39eed63f8d358a6a118
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105278
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'include')
| -rw-r--r-- | include/xmloff/attrlist.hxx | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/include/xmloff/attrlist.hxx b/include/xmloff/attrlist.hxx index d7993062f60f..7f4fef2b9544 100644 --- a/include/xmloff/attrlist.hxx +++ b/include/xmloff/attrlist.hxx @@ -28,17 +28,19 @@ #include <comphelper/servicehelper.hxx> #include <cppuhelper/implbase.hxx> -#include <memory> - -struct SvXMLAttributeList_Impl; +#include <vector> class XMLOFF_DLLPUBLIC SvXMLAttributeList final : public ::cppu::WeakImplHelper< css::xml::sax::XAttributeList, css::util::XCloneable, css::lang::XUnoTunnel> { - std::unique_ptr<SvXMLAttributeList_Impl> m_pImpl; - + struct SvXMLTagAttribute_Impl + { + OUString sName; + OUString sValue; + }; + std::vector<SvXMLTagAttribute_Impl> vecAttribute; public: SvXMLAttributeList(); SvXMLAttributeList( const SvXMLAttributeList& ); @@ -69,9 +71,6 @@ public: void RemoveAttributeByIndex( sal_Int16 i ); void RenameAttributeByIndex( sal_Int16 i, const OUString& rNewName ); sal_Int16 GetIndexByName( const OUString& rName ) const; - - private: - const OUString sType; // "CDATA" }; |