diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-04-10 09:40:19 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-04-10 10:38:23 +0200 |
| commit | e9586cf0b5fda0092fdca3ab4db470e8fd765adf (patch) | |
| tree | e0340048f9eff52dd72ded1de84324fd6ae211b2 /include | |
| parent | 77e2d29bce92639498324814be56656f85a0f0fd (diff) | |
loplugin:unusedfield improvements
improve the read-only check to ignore reads from fields that are guarded
by a boolean check, something like:
if (field)
field.foo();
this produces some false positives at the moment because I'm not
correctly handling the else block, but also some useful new dead code.
Change-Id: Id21fa1a56c171d09d979769b978b6eef14e8b695
Reviewed-on: https://gerrit.libreoffice.org/52664
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'include')
| -rw-r--r-- | include/sfx2/charwin.hxx | 3 | ||||
| -rw-r--r-- | include/svtools/inettbc.hxx | 10 |
2 files changed, 0 insertions, 13 deletions
diff --git a/include/sfx2/charwin.hxx b/include/sfx2/charwin.hxx index 976e1f3999cb..0db93a2f1302 100644 --- a/include/sfx2/charwin.hxx +++ b/include/sfx2/charwin.hxx @@ -91,8 +91,6 @@ public: void setMouseClickHdl(const Link<SvxCharViewControl*,void> &rLink); - DECL_LINK(ContextMenuSelectHdl, Menu*, bool); - protected: virtual void Paint(vcl::RenderContext& rRenderContext, const ::tools::Rectangle&) override; @@ -107,7 +105,6 @@ private: bool maHasInsert; Link<SvxCharViewControl*, void> maMouseClickHdl; - Link<SvxCharViewControl*, void> maClearClickHdl; }; #endif diff --git a/include/svtools/inettbc.hxx b/include/svtools/inettbc.hxx index 46debbb9fafb..c3fa0e4bf530 100644 --- a/include/svtools/inettbc.hxx +++ b/include/svtools/inettbc.hxx @@ -97,14 +97,8 @@ class SVT_DLLPUBLIC URLBox friend class SvtURLBox_Impl; Idle aChangedIdle; - OUString aBaseURL; - OUString aPlaceHolder; rtl::Reference< MatchContext_Impl > pCtx; std::unique_ptr<SvtURLBox_Impl> pImpl; - INetProtocol eSmartProtocol; - bool bAutoCompleteMode : 1; - bool bOnlyDirectories : 1; - bool bHistoryDisabled : 1; std::unique_ptr<weld::ComboBoxText> m_xWidget; @@ -125,13 +119,9 @@ public: void append_text(const OUString& rStr) { m_xWidget->append_text(rStr); } void EnableAutocomplete() { m_xWidget->set_entry_completion(true); } - INetProtocol GetSmartProtocol() const { return eSmartProtocol; } OUString GetURL(); static OUString ParseSmart( const OUString& aText, const OUString& aBaseURL ); - - bool MatchesPlaceHolder( const OUString& sToMatch ) const - { return ( !aPlaceHolder.isEmpty() ) && ( aPlaceHolder == sToMatch ); } }; #endif |