summaryrefslogtreecommitdiff
path: root/install-sh
diff options
context:
space:
mode:
authorJan-Marek Glogowski <glogow@fbihome.de>2022-05-24 11:34:59 +0200
committerAndras Timar <andras.timar@collabora.com>2022-05-28 12:05:25 +0200
commitcbcd0c8c5043b644d7a436519b5900209e96666c (patch)
tree90a4d9afb2b159afdf47b2a55848ead6988f053c /install-sh
parente53eda1cbd720870d8a86ff96fabb3b1a89ea748 (diff)
tdf#148864 Qt switch QtObjectWindow to QWidget
... and therefore rename it to QtObjectWidget Replacement of the QWidget with QWindow originally happened in commit 56b19f9a814ae5a39ed760ee542d715493cd0bf3 ("tdf#121247, tdf#121266 KDE5: Add basic support for OpenGL"), but that unfortunately has a very sparce commit message with no reason for this change. Then the code was further complicated in commit 25edbded9946801effd117b9c46de0f8b4bc5632 ("tdf#125517 Qt5 implement a minimal Qt5ObjectWindow") and a few follow up fixes to restore input and focus handling. But appearingly all this QWindow handling isn't necessary and just returning to a QWidget based class fixes the problems with the video overlay (AKA QWidget::winId()) and video playback for good. The OpenGL Impress transition (Fade) mentioned in the original tdf#121266 bug still works. This also adds the previously missing SolarMutexGuard to all the overridden QtObjectWidget functions, which call the SalObject's Callback function. I accidently triggered a DBG_TESTSOLARMUTEX crashing Impress while debugging this. Change-Id: Ia22cabfd4f3585dc7fa3f9f18a913c5bd1987dd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134864 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins (cherry picked from commit 4366e0605214260e55a937173b0c2e02225dc843) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134903 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Diffstat (limited to 'install-sh')
0 files changed, 0 insertions, 0 deletions