Clarify that rtl::ToStringHelper::length must be precise

d87f5d30879aca73fff271c254589fc41a91fdd0 "support for fast O(U)String
concatenation using operator+", introducing rtl::ToStringHelper, had intended
that length can return an optimistic maximum value if the exact value cannot be
determined (e.g., when creating the textual representation of a numerical value
only on the fly, not upfront), witness the comments removed now, but never made
use of that, always returning precise values from the various
rtl::ToStringHelper::length specializations.

And then cbe3b2fe0b9d745e22a2bf436ce55141b15f9502 "Avoid conversion warning in
O[U]String[Buffer] constructors", not being aware that length could
theoretically return an imprecise value, made certain code rely on it always
returning a precise value.

So clarify the status quo, that length always returns a precise value.  (See
also the discussion in the comments of abandoned
<https://gerrit.libreoffice.org/c/core/+/110129> "Drop obsolete comments".)

Change-Id: I7dc72e9e15304779cc4d2edc01331959b6fbe869
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112397
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins

0 files changed, 0 insertions, 0 deletions