diff options
author | Sarper Akdemir <sarper.akdemir@allotropia.de> | 2024-12-02 12:45:27 +0100 |
---|---|---|
committer | Adolfo Jayme Barrientos <fitojb@ubuntu.com> | 2024-12-03 03:04:12 +0100 |
commit | 379857ddce35cf20d489a05e7aed73fb61d6cbf6 (patch) | |
tree | cb4870e59ee897bf12631ebedb8b72631c7c5fdd /io | |
parent | f0c41fb62d40e14a3fce4f2dc73f4950f07ce801 (diff) |
tdf#163948: fix crash when NotesPane is enabled on Tabbed UI
Pane shells (BottomImpressPane, LeftImpressPane etc.) do not implement any slot
handling, so make sure they are not activated on the top of the shellstack.
Another solution for this could have been getting ChildWindowPanes properly
dispose instead of Hide() at BasicPaneFactory::releaseResource, and adapting the
rest of the code which assumes these Panes are recycled.
This is since ConfigurationUpdater::UpdateCore attempts at releasing via
ConfigurationUpdater::CheckPureAnchors and
ConfigurationControllerResourceManager::DeactivateResources calls.
But in the end the ChildWindowPane is hidden on the DeactivateResource call
instead of being diposed, so the "PureAnchor"'s Shell stays at the shellstack.
Change-Id: I52788d350b66ae22875683f57d87326f4a9a77de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177686
Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
Tested-by: Jenkins
(cherry picked from commit ae281b51456196246a5b21929f6624bf6c030294)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177712
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Diffstat (limited to 'io')
0 files changed, 0 insertions, 0 deletions