diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-10-31 09:07:27 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-10-31 13:09:29 +0100 |
| commit | eb5d232342b1d0f596b6e9c5f8df740a6ec614ff (patch) | |
| tree | 9c5a4563ba98c427fa43aef7ee01581789708a66 /jvmfwk | |
| parent | 33a3de2f0ce2b18d8149dc68c3de16541adfc530 (diff) | |
loplugin:constantparam in i18nlangtag
Change-Id: I148a47a9b63b78651ec18cd947f45b8f4dbb9345
Reviewed-on: https://gerrit.libreoffice.org/44094
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'jvmfwk')
| -rw-r--r-- | jvmfwk/source/elements.cxx | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/jvmfwk/source/elements.cxx b/jvmfwk/source/elements.cxx index 696d6b616d75..96ef388933d4 100644 --- a/jvmfwk/source/elements.cxx +++ b/jvmfwk/source/elements.cxx @@ -48,7 +48,7 @@ namespace jfw { OString getElement(OString const & docPath, - xmlChar const * pathExpression, bool bThrowIfEmpty) + xmlChar const * pathExpression) { //Prepare the xml document and context OSL_ASSERT(!docPath.isEmpty()); @@ -70,10 +70,9 @@ OString getElement(OString const & docPath, OString sValue; if (xmlXPathNodeSetIsEmpty(pathObj->nodesetval)) { - if (bThrowIfEmpty) - throw FrameworkException( - JFW_E_ERROR, - "[Java framework] Error in function getElement (elements.cxx)"); + throw FrameworkException( + JFW_E_ERROR, + "[Java framework] Error in function getElement (elements.cxx)"); } else { @@ -85,7 +84,7 @@ OString getElement(OString const & docPath, OString getElementUpdated() { return getElement(jfw::getVendorSettingsPath(), - reinterpret_cast<xmlChar const *>("/jf:javaSelection/jf:updated/text()"), true); + reinterpret_cast<xmlChar const *>("/jf:javaSelection/jf:updated/text()")); } void createSettingsStructure(xmlDoc * document, bool * bNeedsSave) |