diff options
| author | Noel <noelgrandin@gmail.com> | 2020-11-06 20:01:50 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-11-11 11:58:37 +0100 |
| commit | 93c64a61f2c84e684050294a1391cd32425b7837 (patch) | |
| tree | 00aad2cb8f3ee29ba4ac99e159e26fb8d71d2f33 /l10ntools/source/treemerge.cxx | |
| parent | 1fde62018c8d3344a3408c7b6317120aefc778fb (diff) | |
loplugin:stringview
Add new methods "subView" to O(U)String to return substring views
of the underlying data.
Add a clang plugin to warn when replacing existing calls to copy()
would be better to use subView().
Change-Id: I03a5732431ce60808946f2ce2c923b22845689ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105420
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'l10ntools/source/treemerge.cxx')
| -rw-r--r-- | l10ntools/source/treemerge.cxx | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/l10ntools/source/treemerge.cxx b/l10ntools/source/treemerge.cxx index 933edb79fad1..2920734eea4d 100644 --- a/l10ntools/source/treemerge.cxx +++ b/l10ntools/source/treemerge.cxx @@ -72,9 +72,9 @@ namespace // Update id attribute of topic { OString sNewID = - sID.copy( 0, nFirstSlash + 1 ) + - rXhpRoot.copy( rXhpRoot.lastIndexOf('/') + 1 ) + - sID.copy( sID.indexOf( '/', nFirstSlash + 1 ) ); + OString::Concat(sID.subView( 0, nFirstSlash + 1 )) + + rXhpRoot.subView( rXhpRoot.lastIndexOf('/') + 1 ) + + sID.subView( sID.indexOf( '/', nFirstSlash + 1 ) ); xmlSetProp( pReturn, reinterpret_cast<const xmlChar*>("id"), reinterpret_cast<const xmlChar*>(sNewID.getStr())); @@ -82,7 +82,7 @@ namespace const OString sXhpPath = rXhpRoot + - sID.copy(sID.indexOf('/', nFirstSlash + 1)); + sID.subView(sID.indexOf('/', nFirstSlash + 1)); xmlDocPtr pXhpFile = xmlParseFile( sXhpPath.getStr() ); // if xhpfile is missing than put this topic into comment if ( !pXhpFile ) |