diff options
| author | Noel Grandin <noel@peralex.com> | 2015-11-10 13:36:34 +0200 |
|---|---|---|
| committer | Noel Grandin <noelgrandin@gmail.com> | 2015-11-11 07:16:20 +0000 |
| commit | db17d3c17c40d6b0e92392cf3c6e343d1d17b771 (patch) | |
| tree | 9d562fcf764e7717df9585ef0e735a12ea4aaa16 /l10ntools | |
| parent | 2ce9e4be4a438203382cb9cca824ce3e90647f3a (diff) | |
new loplugin: memoryvar
detect when we can convert a new/delete sequence on a local variable to
use std::unique_ptr
Change-Id: Iecae4e4197eccdfacfce2eed39aa4a69e4a660bc
Reviewed-on: https://gerrit.libreoffice.org/19884
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'l10ntools')
| -rw-r--r-- | l10ntools/source/helpex.cxx | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/l10ntools/source/helpex.cxx b/l10ntools/source/helpex.cxx index aaf2dfd561e0..207f7ada700e 100644 --- a/l10ntools/source/helpex.cxx +++ b/l10ntools/source/helpex.cxx @@ -31,6 +31,7 @@ #include "helpmerge.hxx" #include "common.hxx" +#include <memory> #ifndef TESTDRIVER @@ -81,10 +82,10 @@ SAL_IMPLEMENT_MAIN_WITH_ARGS(argc, argv) std::cerr << "Helpex error: cannot open input file\n"; return 1; } - MergeDataFile* pMergeDataFile = nullptr; + std::unique_ptr<MergeDataFile> pMergeDataFile; if( aArgs.m_sLanguage != "qtz") { - pMergeDataFile = new MergeDataFile(aArgs.m_sMergeSrc, OString(), false, false ); + pMergeDataFile.reset(new MergeDataFile(aArgs.m_sMergeSrc, OString(), false, false )); } std::string sTemp; aInput >> sTemp; @@ -97,28 +98,26 @@ SAL_IMPLEMENT_MAIN_WITH_ARGS(argc, argv) aArgs.m_sOutputFile + sXhpFile.copy( sXhpFile.lastIndexOf('/') )); if( !aParser.Merge( aArgs.m_sMergeSrc, sOutput, - aArgs.m_sLanguage, pMergeDataFile )) + aArgs.m_sLanguage, pMergeDataFile.get() )) { hasNoError = false; } aInput >> sTemp; } aInput.close(); - delete pMergeDataFile; } else { HelpParser aParser( aArgs.m_sInputFile ); - MergeDataFile* pMergeDataFile = nullptr; + std::unique_ptr<MergeDataFile> pMergeDataFile; if( aArgs.m_sLanguage != "qtz") { - pMergeDataFile = new MergeDataFile(aArgs.m_sMergeSrc, aArgs.m_sInputFile, false, false ); + pMergeDataFile.reset(new MergeDataFile(aArgs.m_sMergeSrc, aArgs.m_sInputFile, false, false )); } hasNoError = aParser.Merge( aArgs.m_sMergeSrc, aArgs.m_sOutputFile, - aArgs.m_sLanguage, pMergeDataFile ); - delete pMergeDataFile; + aArgs.m_sLanguage, pMergeDataFile.get() ); } } else |