diff options
| author | Noel Grandin <noel@peralex.com> | 2015-01-20 12:38:10 +0200 |
|---|---|---|
| committer | Noel Grandin <noel@peralex.com> | 2015-01-26 08:42:28 +0200 |
| commit | b44cbb26efe1d0b0950b1e1613e131b506dc3876 (patch) | |
| tree | 9b4d5d99e5dad0971079b997a02a6d96536709ca /l10ntools | |
| parent | 26ad60aec69310fecd918f1c2e09056aa4782320 (diff) | |
new loplugin: change virtual methods to non-virtual
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
Diffstat (limited to 'l10ntools')
| -rw-r--r-- | l10ntools/inc/xmlparse.hxx | 4 | ||||
| -rw-r--r-- | l10ntools/source/po.cxx | 33 |
2 files changed, 16 insertions, 21 deletions
diff --git a/l10ntools/inc/xmlparse.hxx b/l10ntools/inc/xmlparse.hxx index 474bee685f95..ab3f0e26e9e1 100644 --- a/l10ntools/inc/xmlparse.hxx +++ b/l10ntools/inc/xmlparse.hxx @@ -155,7 +155,7 @@ public: virtual ~XMLFile(); void Print( XMLNode *pCur = NULL, sal_uInt16 nLevel = 0 ); - virtual void SearchL10NElements( XMLChildNode *pCur, int pos = 0 ); + void SearchL10NElements( XMLChildNode *pCur, int pos = 0 ); void Extract( XMLFile *pCur = NULL ); XMLHashMap* GetStrings(){ return m_pXMLStrings; } @@ -248,7 +248,7 @@ public: void SetPos ( int nPos ) { m_nPos = nPos; } void SetOldRef ( OString const & sOldRef ) { m_sOldRef = sOldRef; } - virtual int GetPos() { return m_nPos; } + int GetPos() { return m_nPos; } OString GetProject() const { return m_sProject; } OString GetFileName() const { return m_sFilename; } OString GetId() const { return m_sId; } diff --git a/l10ntools/source/po.cxx b/l10ntools/source/po.cxx index a4e60b91e6a6..c2acc2e25e8a 100644 --- a/l10ntools/source/po.cxx +++ b/l10ntools/source/po.cxx @@ -52,41 +52,36 @@ public: virtual ~GenPoEntry(); // Default copy constructor and copy operator work well - virtual OString getExtractCom() const { return m_sExtractCom; } - virtual OString getReference() const { return m_sReference; } - virtual OString getMsgCtxt() const { return m_sMsgCtxt; } - virtual OString getMsgId() const { return m_sMsgId; } - virtual OString getMsgStr() const { return m_sMsgStr; } - virtual bool isFuzzy() const { return m_bFuzzy; } - virtual bool isNull() const { return m_bNull; } - - virtual void setExtractCom(const OString& rExtractCom) + OString getReference() const { return m_sReference; } + OString getMsgCtxt() const { return m_sMsgCtxt; } + OString getMsgId() const { return m_sMsgId; } + OString getMsgStr() const { return m_sMsgStr; } + bool isFuzzy() const { return m_bFuzzy; } + bool isNull() const { return m_bNull; } + + void setExtractCom(const OString& rExtractCom) { m_sExtractCom = rExtractCom; } - virtual void setReference(const OString& rReference) + void setReference(const OString& rReference) { m_sReference = rReference; } - virtual void setMsgCtxt(const OString& rMsgCtxt) + void setMsgCtxt(const OString& rMsgCtxt) { m_sMsgCtxt = rMsgCtxt; } - virtual void setMsgId(const OString& rMsgId) + void setMsgId(const OString& rMsgId) { m_sMsgId = rMsgId; } - virtual void setMsgStr(const OString& rMsgStr) + void setMsgStr(const OString& rMsgStr) { m_sMsgStr = rMsgStr; } - virtual void setFuzzy(const bool bFuzzy) - { - m_bFuzzy = bFuzzy; - } - virtual void writeToFile(std::ofstream& rOFStream) const; - virtual void readFromFile(std::ifstream& rIFStream); + void writeToFile(std::ofstream& rOFStream) const; + void readFromFile(std::ifstream& rIFStream); }; namespace |