summaryrefslogtreecommitdiff
path: root/libreofficekit
diff options
context:
space:
mode:
authorMiklos Vajna <vmiklos@collabora.co.uk>2015-02-05 18:09:30 +0100
committerMiklos Vajna <vmiklos@collabora.co.uk>2015-02-09 08:12:11 +0100
commit5d483a6751afd6f524a5c154c1be2a8a60ba0328 (patch)
tree70a80303fac91ac698c9e98ad930ff5b30babfe2 /libreofficekit
parent4b707104207e96d4e6666be7ad6e00ac4c6a10bc (diff)
lokdocview: fix memory leak in lcl_payloadToRectangle()
Change-Id: I2894c693d11b025d23ebbf0ae75f67532efe315f
Diffstat (limited to 'libreofficekit')
-rw-r--r--libreofficekit/source/gtk/lokdocview.c25
1 files changed, 14 insertions, 11 deletions
diff --git a/libreofficekit/source/gtk/lokdocview.c b/libreofficekit/source/gtk/lokdocview.c
index 3e791a7b6705..c5f8dab53a71 100644
--- a/libreofficekit/source/gtk/lokdocview.c
+++ b/libreofficekit/source/gtk/lokdocview.c
@@ -330,24 +330,27 @@ static GdkRectangle lcl_payloadToRectangle(const char* pPayload)
{
GdkRectangle aRet;
gchar** ppCoordinates;
+ gchar** ppCoordinate;
aRet.width = aRet.height = aRet.x = aRet.y = 0;
ppCoordinates = g_strsplit(pPayload, ", ", 4);
- if (!*ppCoordinates)
+ ppCoordinate = ppCoordinates;
+ if (!*ppCoordinate)
return aRet;
- aRet.width = atoi(*ppCoordinates);
- ++ppCoordinates;
- if (!*ppCoordinates)
+ aRet.width = atoi(*ppCoordinate);
+ ++ppCoordinate;
+ if (!*ppCoordinate)
return aRet;
- aRet.height = atoi(*ppCoordinates);
- ++ppCoordinates;
- if (!*ppCoordinates)
+ aRet.height = atoi(*ppCoordinate);
+ ++ppCoordinate;
+ if (!*ppCoordinate)
return aRet;
- aRet.x = atoi(*ppCoordinates);
- ++ppCoordinates;
- if (!*ppCoordinates)
+ aRet.x = atoi(*ppCoordinate);
+ ++ppCoordinate;
+ if (!*ppCoordinate)
return aRet;
- aRet.y = atoi(*ppCoordinates);
+ aRet.y = atoi(*ppCoordinate);
+ g_strfreev(ppCoordinates);
return aRet;
}