Extend loplugin:stringview to OUStringBuffer::copy

(Somewhat oddly, there is no OStringBuffer::copy counterpart.)

This required some modification to StringView::VisitCXXConstructExpr to avoid

> In file included from odk/qa/checkapi/checkapi.cxx:29:
> In file included from workdir/CustomTarget/odk/allheaders/allheaders.hxx:351:
> In file included from instdir/sdk/include/rtl/math.hxx:31:
> instdir/sdk/include/rtl/ustrbuf.hxx:1687:16: error: rather than copy, pass with a view using subView() [loplugin:stringview]
>         return copy( beginIndex, getLength() - beginIndex );
>                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

while building CppunitTest_odk_checkapi as external C++03 code, where the
returned value is wrapped in a CXXConstructExpr.  And testing for that case
required a new CompilerTest_compilerplugins_clang-c++03 that uses gb_CXX03FLAGS
and needs to not set LIBO_INTERNAL_ONLY (via gb_CompilerTest_set_external_code),
as compiling as C++03 would otherwise generate lots of errors like unknown
char16_t at include/sal/types.h:118.  (There was a choice whether to name the
new test "-c++03" or "-external", but the issue it tests is caused more by the
code being compiled with C++03 than by this being external code, see above.)

Change-Id: I873a9c5a70d3ea949cf13a169d46920b71282712
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130036
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

1 files changed, 1 insertions, 1 deletions

diff --git a/linguistic/source/hyphdsp.cxx b/linguistic/source/hyphdsp.cxx
index 17c0bff0e872..6113960d4c9e 100644
--- a/linguistic/source/hyphdsp.cxx
+++ b/linguistic/source/hyphdsp.cxx
@@ -158,7 +158,7 @@ Reference<XHyphenatedWord>  HyphenatorDispatcher::buildHyphWord(
                         OUStringBuffer aTmp2 ( aTmp.copy(0, std::max (nHyphenationPos + 1 - split, 0) ) );
                         aTmp2.append( aText.subView( nOrigHyphPos + 1, endhyphpat - nOrigHyphPos - 1) );
                         nHyphenPos = aTmp2.getLength();
-                        aTmp2.append( aTmp.copy( nHyphenationPos + 1 ) );
+                        aTmp2.append( aTmp.subView( nHyphenationPos + 1 ) );
                         //! take care of #i22591#
                         if (rOrigWord[ rOrigWord.getLength() - 1 ] == '.')
                             aTmp2.append( '.' );