no need to take SolarMutex when calling Idle::Start

but it is wise to hold our own mutex while accessing our own field

Change-Id: Ic66ab8dde5711e0a91b6c31cebf42a6066e638b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146309
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 9 insertions, 14 deletions

diff --git a/linguistic/source/lngsvcmgr.cxx b/linguistic/source/lngsvcmgr.cxx
index f38ee262099c..73abcf92abd5 100644
--- a/linguistic/source/lngsvcmgr.cxx
+++ b/linguistic/source/lngsvcmgr.cxx
@@ -439,22 +439,17 @@ LngSvcMgr::LngSvcMgr()
 // css::util::XModifyListener
 void LngSvcMgr::modified(const lang::EventObject&)
 {
-    {
-        osl::MutexGuard aGuard(GetLinguMutex());
-        //assume that if an extension has been added/removed that
-        //it might be a dictionary extension, so drop our cache
+    osl::MutexGuard aGuard(GetLinguMutex());
+    //assume that if an extension has been added/removed that
+    //it might be a dictionary extension, so drop our cache
 
-        pAvailSpellSvcs.reset();
-        pAvailGrammarSvcs.reset();
-        pAvailHyphSvcs.reset();
-        pAvailThesSvcs.reset();
-    }
+    pAvailSpellSvcs.reset();
+    pAvailGrammarSvcs.reset();
+    pAvailHyphSvcs.reset();
+    pAvailThesSvcs.reset();
 
-    {
-        SolarMutexGuard aGuard;
-        //schedule in an update to execute in the main thread
-        aUpdateIdle.Start();
-    }
+    //schedule in an update to execute in the main thread
+    aUpdateIdle.Start();
 }
 
 //run update, and inform everyone that dictionaries (may) have changed, this