new compilerplugin returnbyref

Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
class A {
struct X x;
public X* getX() { return &x; }
}
which can be:
public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7

1 files changed, 8 insertions, 8 deletions

diff --git a/lotuswordpro/source/filter/lwpsection.hxx b/lotuswordpro/source/filter/lwpsection.hxx
index 3e2fa83777ab..6c714e44a5a8 100644
--- a/lotuswordpro/source/filter/lwpsection.hxx
+++ b/lotuswordpro/source/filter/lwpsection.hxx
@@ -77,8 +77,8 @@ public:
     LwpOrderedObject(LwpObjectHeader &objHdr, LwpSvStream* pStrm);
     virtual ~LwpOrderedObject(){}
     void Read() SAL_OVERRIDE;
-    LwpObjectID* GetPosition(){ return &m_Para;}
-    LwpObjectID* GetListList(){ return &m_ListList;}
+    LwpObjectID& GetPosition(){ return m_Para;}
+    LwpObjectID& GetListList(){ return m_ListList;}
 protected:
     LwpObjectID m_ListList;//lwplistlist object,
     LwpObjectID m_Para;
@@ -97,8 +97,8 @@ public:
     virtual ~LwpSection();
     inline sal_uInt16 GetFlags();
     inline LwpPageLayout* GetPageLayout();
-    inline LwpColor* GetColor();
-    inline LwpAtomHolder* GetAtomHolder();
+    inline LwpColor& GetColor();
+    inline LwpAtomHolder& GetAtomHolder();
     void Parse(IXFStream* pOutputStream) SAL_OVERRIDE;
     OUString GetSectionName(){return m_AtomHolder.str();}
 
@@ -134,18 +134,18 @@ inline LwpPageLayout* LwpSection::GetPageLayout()
  * @descr get section tab color
  *
  */
-inline LwpColor* LwpSection::GetColor()
+inline LwpColor& LwpSection::GetColor()
 {
-    return &m_Color;
+    return m_Color;
 }
 
 /**
  * @descr get section atom holder pointer
  *
  */
-inline LwpAtomHolder* LwpSection::GetAtomHolder()
+inline LwpAtomHolder& LwpSection::GetAtomHolder()
 {
-    return &m_AtomHolder;
+    return m_AtomHolder;
 }
 
 class LwpIndexSection : public LwpSection